From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org,
boost.lists@gmail.com, quintela@redhat.com, jasowang@redhat.com,
mst@redhat.com, zuban32s@gmail.com,
maria.klimushenkova@ispras.ru, dovgaluk@ispras.ru,
kraxel@redhat.com, pavel.dovgaluk@ispras.ru, pbonzini@redhat.com,
alex.bennee@linaro.org
Subject: [Qemu-devel] [RFC PATCH v3 26/30] scripts/analyse-locks-simpletrace.py: script to analyse lock times
Date: Thu, 11 Jan 2018 11:27:22 +0300 [thread overview]
Message-ID: <20180111082722.27295.91989.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20180111082452.27295.85707.stgit@pasha-VirtualBox>
From: Alex Bennée <alex.bennee@linaro.org>
This script allows analysis of mutex acquisition and hold times based
on a trace file. Given a trace control file of:
qemu_mutex_lock
qemu_mutex_locked
qemu_mutex_unlock
And running with:
$QEMU $QEMU_ARGS -trace events=./lock-trace
You can analyse the results with:
./scripts/analyse-locks-simpletrace.py trace-events-all ./trace-21812
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
scripts/analyse-locks-simpletrace.py | 99 ++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
create mode 100755 scripts/analyse-locks-simpletrace.py
diff --git a/scripts/analyse-locks-simpletrace.py b/scripts/analyse-locks-simpletrace.py
new file mode 100755
index 0000000..b72c951
--- /dev/null
+++ b/scripts/analyse-locks-simpletrace.py
@@ -0,0 +1,99 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+#
+# Analyse lock events and
+#
+# Author: Alex Bennée <alex.bennee@linaro.org>
+#
+
+import os
+import simpletrace
+import argparse
+import numpy as np
+
+class MutexAnalyser(simpletrace.Analyzer):
+ "A simpletrace Analyser for checking locks."
+
+ def __init__(self):
+ self.locks = 0
+ self.locked = 0
+ self.unlocks = 0
+ self.mutex_records = {}
+
+ def _get_mutex(self, mutex):
+ if not mutex in self.mutex_records:
+ self.mutex_records[mutex] = {"locks": 0,
+ "lock_time": 0,
+ "acquire_times": [],
+ "locked": 0,
+ "locked_time": 0,
+ "held_times": [],
+ "unlocked": 0}
+
+ return self.mutex_records[mutex]
+
+ def qemu_mutex_lock(self, timestamp, mutex, filename, line):
+ self.locks += 1
+ rec = self._get_mutex(mutex)
+ rec["locks"] += 1
+ rec["lock_time"] = timestamp[0]
+ rec["lock_loc"] = (filename, line)
+
+ def qemu_mutex_locked(self, timestamp, mutex, filename, line):
+ self.locked += 1
+ rec = self._get_mutex(mutex)
+ rec["locked"] += 1
+ rec["locked_time"] = timestamp[0]
+ acquire_time = rec["locked_time"] - rec["lock_time"]
+ rec["locked_loc"] = (filename, line)
+ rec["acquire_times"].append(acquire_time)
+
+ def qemu_mutex_unlock(self, timestamp, mutex, filename, line):
+ self.unlocks += 1
+ rec = self._get_mutex(mutex)
+ rec["unlocked"] += 1
+ held_time = timestamp[0] - rec["locked_time"]
+ rec["held_times"].append(held_time)
+ rec["unlock_loc"] = (filename, line)
+
+
+def get_args():
+ "Grab options"
+ parser = argparse.ArgumentParser()
+ parser.add_argument("--output", "-o", type=str, help="Render plot to file")
+ parser.add_argument("events", type=str, help='trace file read from')
+ parser.add_argument("tracefile", type=str, help='trace file read from')
+ return parser.parse_args()
+
+if __name__ == '__main__':
+ args = get_args()
+
+ # Gather data from the trace
+ analyser = MutexAnalyser()
+ simpletrace.process(args.events, args.tracefile, analyser)
+
+ print ("Total locks: %d, locked: %d, unlocked: %d" %
+ (analyser.locks, analyser.locked, analyser.unlocks))
+
+ # Now dump the individual lock stats
+ for key, val in sorted(analyser.mutex_records.iteritems(),
+ key=lambda (k,v): v["locks"]):
+ print ("Lock: %#x locks: %d, locked: %d, unlocked: %d" %
+ (key, val["locks"], val["locked"], val["unlocked"]))
+
+ acquire_times = np.array(val["acquire_times"])
+ if len(acquire_times) > 0:
+ print (" Acquire Time: min:%d median:%d avg:%.2f max:%d" %
+ (acquire_times.min(), np.median(acquire_times),
+ acquire_times.mean(), acquire_times.max()))
+
+ held_times = np.array(val["held_times"])
+ if len(held_times) > 0:
+ print (" Held Time: min:%d median:%d avg:%.2f max:%d" %
+ (held_times.min(), np.median(held_times),
+ held_times.mean(), held_times.max()))
+
+ # Check if any locks still held
+ if val["locks"] > val["locked"]:
+ print (" LOCK HELD (%s:%s)" % (val["locked_loc"]))
+ print (" BLOCKED (%s:%s)" % (val["lock_loc"]))
next prev parent reply other threads:[~2018-01-11 8:27 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 8:24 [Qemu-devel] [RFC PATCH v3 00/30] replay additions Pavel Dovgalyuk
2018-01-11 8:24 ` [Qemu-devel] [RFC PATCH v3 01/30] hpet: recover timer offset correctly Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 02/30] cpu: flush TB cache when loading VMState Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 03/30] This patch adds a condition before overwriting exception_index fields Pavel Dovgalyuk
2018-01-11 12:29 ` Paolo Bonzini
2018-01-12 6:12 ` Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 04/30] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 05/30] blkreplay: create temporary overlay for underlaying devices Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 06/30] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 07/30] replay: fix processing async events Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 08/30] replay: fixed replay_enable_events Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 09/30] replay: fix save/load vm for non-empty queue Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 10/30] replay: added replay log format description Pavel Dovgalyuk
2018-01-11 8:25 ` [Qemu-devel] [RFC PATCH v3 11/30] replay: make safe vmstop at record/replay Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 12/30] replay: save prior value of the host clock Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 13/30] icount: fixed saving/restoring of icount warp timers Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 14/30] target/arm/arm-powertctl: drop BQL assertions Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 15/30] cpus: push BQL lock to qemu_*_wait_io_event Pavel Dovgalyuk
2018-01-11 12:50 ` Paolo Bonzini
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 16/30] cpus: only take BQL for sleeping threads Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 17/30] replay/replay.c: bump REPLAY_VERSION again Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 18/30] replay/replay-internal.c: track holding of replay_lock Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 19/30] replay: make locking visible outside replay code Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 20/30] replay: push replay_mutex_lock up the call tree Pavel Dovgalyuk
2018-01-11 8:26 ` [Qemu-devel] [RFC PATCH v3 21/30] replay: don't destroy mutex at exit Pavel Dovgalyuk
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 22/30] replay: check return values of fwrite Pavel Dovgalyuk
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 23/30] replay: avoid recursive call of checkpoints Pavel Dovgalyuk
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 24/30] scripts/qemu-gdb: add simple tcg lock status helper Pavel Dovgalyuk
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 25/30] util/qemu-thread-*: add qemu_lock, locked and unlock trace events Pavel Dovgalyuk
2018-01-11 8:27 ` Pavel Dovgalyuk [this message]
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 27/30] scripts/replay-dump.py: replay log dumper Pavel Dovgalyuk
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 28/30] scripts/qemu-gdb/timers.py: new helper to dump timer state Pavel Dovgalyuk
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 29/30] replay: improve replay performance Pavel Dovgalyuk
2018-01-11 12:55 ` Paolo Bonzini
2018-01-11 13:12 ` Pavel Dovgalyuk
2018-01-11 13:22 ` Paolo Bonzini
2018-01-12 6:13 ` Pavel Dovgalyuk
2018-01-12 12:10 ` Paolo Bonzini
2018-01-12 12:41 ` Pavel Dovgalyuk
2018-01-11 8:27 ` [Qemu-devel] [RFC PATCH v3 30/30] replay: don't process async events when warping the clock Pavel Dovgalyuk
2018-01-11 12:37 ` Paolo Bonzini
2018-01-12 7:20 ` Pavel Dovgalyuk
2018-01-11 8:54 ` [Qemu-devel] [RFC PATCH v3 00/30] replay additions no-reply
2018-01-11 8:55 ` no-reply
2018-01-11 12:56 ` Paolo Bonzini
2018-01-12 9:32 ` Paolo Bonzini
2018-01-12 12:07 ` Pavel Dovgalyuk
2018-01-12 12:11 ` Paolo Bonzini
2018-01-19 6:35 ` Pavel Dovgalyuk
2018-01-19 7:41 ` Paolo Bonzini
2018-01-19 7:45 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111082722.27295.91989.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=boost.lists@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.