From: Peter Zijlstra <peterz@infradead.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Woodhouse, David" <dwmw@amazon.co.uk>,
"Thomas.Lendacky@amd.com" <Thomas.Lendacky@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
"Ghitulete, Razvan-alin" <rga@amazon.com>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"riel@redhat.com" <riel@redhat.com>,
"keescook@google.com" <keescook@google.com>,
"gnomes@lxorguk.ukuu.org.uk" <gnomes@lxorguk.ukuu.org.uk>,
"pjt@google.com" <pjt@google.com>,
"dave.hansen@intel.com" <dave.hansen@intel.com>,
"luto@amacapital.net" <luto@amacapital.net>,
"jikos@kernel.org" <jikos@kernel.org>,
"gregkh@linux-foundation.org" <gregkh@linux-foundation.org>
Subject: Re: [PATCH] x86/retpoline: Fill return stack buffer on vmexit
Date: Thu, 11 Jan 2018 10:58:30 +0100 [thread overview]
Message-ID: <20180111095830.GY6176@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180111094759.aohvm5tqztza72es@pd.tnic>
On Thu, Jan 11, 2018 at 10:47:59AM +0100, Borislav Petkov wrote:
> On Thu, Jan 11, 2018 at 10:32:31AM +0100, Peter Zijlstra wrote:
> > can't you do lovely things like:
> >
> > volatile asm ("call __fill_rsb_thunk_%1" : : "r" (dummy))
> >
> > which would still let gcc select the register ?
>
> Calling a function from asm is nasty because you need to pay attention
> to clobbered registers as gcc doesn't see the function.
The point is that this is an asm function, much like the retpoline
thunks, replicated for each register.
And by stuffing the register in the function name and using a dummy
argument you let GCC pick which register to clobber.
Heck we could even pass in the actual stuff-count instead of treating it
as a pure dummy.
next prev parent reply other threads:[~2018-01-11 9:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 22:51 [PATCH] x86/retpoline: Fill return stack buffer on vmexit David Woodhouse
2018-01-10 23:22 ` David Lang
2018-01-10 23:32 ` Woodhouse, David
2018-01-10 23:47 ` Tim Chen
2018-01-11 0:04 ` Woodhouse, David
2018-01-11 8:42 ` Peter Zijlstra
2018-01-11 8:49 ` Boris Petkov
2018-01-11 9:07 ` Woodhouse, David
2018-01-11 9:32 ` Peter Zijlstra
2018-01-11 9:47 ` Borislav Petkov
2018-01-11 9:58 ` Peter Zijlstra [this message]
2018-01-11 9:58 ` Woodhouse, David
2018-01-10 23:47 ` David Woodhouse
2018-01-11 0:14 ` Tom Lendacky
2018-01-11 1:04 ` David Woodhouse
2018-01-11 1:12 ` David Woodhouse
2018-01-12 0:34 ` Tom Lendacky
2018-01-11 8:49 ` Peter Zijlstra
2018-01-11 12:10 ` Woodhouse, David
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111095830.GY6176@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Thomas.Lendacky@amd.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linux-foundation.org \
--cc=jikos@kernel.org \
--cc=keescook@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=pjt@google.com \
--cc=rga@amazon.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.