From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [V3,2/6] usb: serial: f81534: add auto RTS direction support From: Johan Hovold Message-Id: <20180111100556.GA11344@localhost> Date: Thu, 11 Jan 2018 11:05:56 +0100 To: "Ji-Ze Hong \(Peter Hong\)" Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong \(Peter Hong\)" List-ID: T24gVGh1LCBKYW4gMTEsIDIwMTggYXQgMDI6NDc6MTZQTSArMDgwMCwgSmktWmUgSG9uZyAoUGV0 ZXIgSG9uZykgd3JvdGU6Cj4gVGhlIEY4MTUzMi81MzQgaGFkIGF1dG8gUlRTIGRpcmVjdGlvbiBz dXBwb3J0IGZvciBSUzQ4NSBtb2RlLgo+IFdlJ2xsIHJlYWQgaXQgZnJvbSBpbnRlcm5hbCBGbGFz aCB3aXRoIGFkZHJlc3MgMHgyZjAxfjB4MmYwNCBmb3IgNCBwb3J0cy4KPiBUaGVyZSBhcmUgNCBj b25kaXRpb25zIGJlbG93Ogo+IAkwOiBGODE1MzRfUE9SVF9DT05GX1JTMjMyLgo+IAkxOiBGODE1 MzRfUE9SVF9DT05GX1JTNDg1Lgo+IAkyOiB2YWx1ZSBlcnJvciwgZGVmYXVsdCB0byBGODE1MzRf UE9SVF9DT05GX1JTMjMyLgo+IAkzOiBGODE1MzRfUE9SVF9DT05GX1JTNDg1X0lOVkVSVC4KPiAK PiBGODE1MzIvNTM0IENsb2NrIHJlZ2lzdGVyIChvZmZzZXQgKzA4aCkKPiAKPiBCaXQwOglVQVJU IEVuYWJsZSAoYWx3YXlzIG9uKQo+IEJpdDItMToJQ2xvY2sgc291cmNlIHNlbGVjdG9yCj4gCQkJ MDA6IDEuODQ2TUh6Lgo+IAkJCTAxOiAxOC40Nk1Iei4KPiAJCQkxMDogMjRNSHouCj4gCQkJMTE6 IDE0Ljc3TUh6Lgo+IEJpdDQ6CUF1dG8gZGlyZWN0aW9uKFJUUykgY29udHJvbCAoUlRTIHBpbiBM b3cgd2hlbiBUWCkKPiBCaXQ1OglJbnZlcnQgZGlyZWN0aW9uKFJUUykgd2hlbiBCaXQ0IGVuYWJs ZWQgKFJUUyBwaW4gaGlnaCB3aGVuIFRYKQo+IAo+IFNpZ25lZC1vZmYtYnk6IEppLVplIEhvbmcg KFBldGVyIEhvbmcpIDxocGV0ZXIrbGludXhfa2VybmVsQGdtYWlsLmNvbT4KPiAtLS0KPiBWMzoK PiAJMTogY2hhbmdlIHNvbWUgQklUKCkgb3BlcmF0aW9uIHRvIEdFTk1BU0soKS4KPiAJMjogY2hh bmdlIHNvbWUgZGV2X2luZm8oKSB0byBkZXZfZGJnKCkuCj4gCj4gVjI6Cj4gCTE6IFJlYWQgdGhl IGNvbmZpZ3VyZSBkYXRhIGZyb20gZmxhc2ggYW5kIHNhdmUgaXQgdG8gc2hhZG93IGNsb2NrCj4g CSAgIHJlZ2lzdGVyLgoKU2VyaWVzIG5vdyBhcHBsaWVkIHdpdGggYSBmZXcgbWlub3IgdHdlYWtz LgoKPiArI2RlZmluZSBGODE1MzRfUE9SVF9DT05GX1JTMjMyCQkwCj4gKyNkZWZpbmUgRjgxNTM0 X1BPUlRfQ09ORl9SUzQ4NQkJQklUKDApCj4gKyNkZWZpbmUgRjgxNTM0X1BPUlRfQ09ORl9SUzQ4 NV9JTlZFUlQJR0VOTUFTSygxLCAwKQoKSSByZXBsYWNlZCBHRU5NQVNLKCkgd2l0aCB5b3VyIG9y aWdpbmFsIChCSVQoeCkgfCBCSVQoeSkpIGZvciByZWdpc3Rlcgp2YWx1ZXMgbGlrZSB0aGlzIG9u ZS4KCj4gICNkZWZpbmUgRjgxNTM0X1BPUlRfQ09ORl9ESVNBQkxFX1BPUlQJQklUKDMpCj4gICNk ZWZpbmUgRjgxNTM0X1BPUlRfQ09ORl9OT1RfRVhJU1RfUE9SVAlCSVQoNykKPiAgI2RlZmluZSBG ODE1MzRfUE9SVF9VTkFWQUlMQUJMRQkJXAo+ICAJKEY4MTUzNF9QT1JUX0NPTkZfRElTQUJMRV9Q T1JUIHwgRjgxNTM0X1BPUlRfQ09ORl9OT1RfRVhJU1RfUE9SVCkKPiAgCj4gKyNkZWZpbmUgRjgx NTM0X1VBUlRfTU9ERV9NQVNLCQlHRU5NQVNLKDEsIDApCgpBbmQgcmVuYW1lZCB0aGlzIG1hc2sg dG8gRjgxNTM0X1BPUlRfQ09ORl9NT0RFX01BU0sgc28gaXRzIG1vcmUKb2J2aW91cyB0byB3aGF0 IGl0IGFwcGxpZXMuCgpUaGFua3MsCkpvaGFuCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMg bGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBv ZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBp bmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933055AbeAKKGB (ORCPT + 1 other); Thu, 11 Jan 2018 05:06:01 -0500 Received: from mail-lf0-f43.google.com ([209.85.215.43]:44308 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388AbeAKKF7 (ORCPT ); Thu, 11 Jan 2018 05:05:59 -0500 X-Google-Smtp-Source: ACJfBoshYk8+lKe4Jcfa0dpjrvhZb+OrBO8PKFyeDGPKa+K7mXxJhn1BJFtflGYvdVsE37E39VFA/A== Date: Thu, 11 Jan 2018 11:05:56 +0100 From: Johan Hovold To: "Ji-Ze Hong (Peter Hong)" Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" Subject: Re: [PATCH V3 2/6] usb: serial: f81534: add auto RTS direction support Message-ID: <20180111100556.GA11344@localhost> References: <1515653240-5420-1-git-send-email-hpeter+linux_kernel@gmail.com> <1515653240-5420-2-git-send-email-hpeter+linux_kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1515653240-5420-2-git-send-email-hpeter+linux_kernel@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Jan 11, 2018 at 02:47:16PM +0800, Ji-Ze Hong (Peter Hong) wrote: > The F81532/534 had auto RTS direction support for RS485 mode. > We'll read it from internal Flash with address 0x2f01~0x2f04 for 4 ports. > There are 4 conditions below: > 0: F81534_PORT_CONF_RS232. > 1: F81534_PORT_CONF_RS485. > 2: value error, default to F81534_PORT_CONF_RS232. > 3: F81534_PORT_CONF_RS485_INVERT. > > F81532/534 Clock register (offset +08h) > > Bit0: UART Enable (always on) > Bit2-1: Clock source selector > 00: 1.846MHz. > 01: 18.46MHz. > 10: 24MHz. > 11: 14.77MHz. > Bit4: Auto direction(RTS) control (RTS pin Low when TX) > Bit5: Invert direction(RTS) when Bit4 enabled (RTS pin high when TX) > > Signed-off-by: Ji-Ze Hong (Peter Hong) > --- > V3: > 1: change some BIT() operation to GENMASK(). > 2: change some dev_info() to dev_dbg(). > > V2: > 1: Read the configure data from flash and save it to shadow clock > register. Series now applied with a few minor tweaks. > +#define F81534_PORT_CONF_RS232 0 > +#define F81534_PORT_CONF_RS485 BIT(0) > +#define F81534_PORT_CONF_RS485_INVERT GENMASK(1, 0) I replaced GENMASK() with your original (BIT(x) | BIT(y)) for register values like this one. > #define F81534_PORT_CONF_DISABLE_PORT BIT(3) > #define F81534_PORT_CONF_NOT_EXIST_PORT BIT(7) > #define F81534_PORT_UNAVAILABLE \ > (F81534_PORT_CONF_DISABLE_PORT | F81534_PORT_CONF_NOT_EXIST_PORT) > > +#define F81534_UART_MODE_MASK GENMASK(1, 0) And renamed this mask to F81534_PORT_CONF_MODE_MASK so its more obvious to what it applies. Thanks, Johan