From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: uas: unconditionally bring back host after reset From: Greg Kroah-Hartman Message-Id: <20180111112234.GA16268@kroah.com> Date: Thu, 11 Jan 2018 12:22:34 +0100 To: Oliver Neukum Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org List-ID: T24gVGh1LCBKYW4gMTEsIDIwMTggYXQgMTE6NTk6NTRBTSArMDEwMCwgT2xpdmVyIE5ldWt1bSB3 cm90ZToKPiBRdW90aW5nIEhhbnM6Cj4gCj4gSWYgd2UgcmV0dXJuIDEgZnJvbSBvdXIgcG9zdF9y ZXNldCBoYW5kbGVyLCB0aGVuIG91ciBkaXNjb25uZWN0IGhhbmRsZXIKPiB3aWxsIGJlIGNhbGxl ZCBpbW1lZGlhdGVseSBhZnRlcndhcmRzLiBTaW5jZSBwcmVfcmVzZXQgYmxvY2tzIGFsbCBzY3Np Cj4gcmVxdWVzdHMgb3VyIGRpc2Nvbm5lY3QgaGFuZGxlciB3aWxsIHRoZW4gaGFuZyBpbiB0aGUg c2NzaV9yZW1vdmVfaG9zdAo+IGNhbGwuCj4gCj4gVGhpcyBpcyBlc3AuIGJhZCBiZWNhdXNlIG91 ciBkaXNjb25uZWN0IGhhbmRsZXIgaGFuZ2luZyBmb3IgZXZlciBhbHNvCj4gc3RvcHMgdGhlIFVT QiBzdWJzeXMgZnJvbSBlbnVtZXJhdGluZyBhbnkgbmV3IFVTQiBkZXZpY2VzLCBjYXVzZXMgY29t bWFuZHMKPiBsaWtlIGxzdXNiIHRvIGhhbmcsIGV0Yy4KPiAKPiBJbiBwcmFjdGljZSB0aGlzIGhh cHBlbnMgd2hlbiB1bnBsdWdnaW5nIHNvbWUgdWFzIGRldmljZXMgYmVjYXVzZSB0aGUgaHViCj4g Y29kZSBtYXkgc2VlIHRoZSBkZXZpY2UgYXMgbmVlZGluZyBhIHdhcm0tcmVzZXQgYW5kIGNhbGxz IHVzYl9yZXNldF9kZXZpY2UKPiBiZWZvcmUgc2VlaW5nIHRoZSBkaXNjb25uZWN0LiBJbiB0aGlz IGNhc2UgdWFzX2NvbmZpZ3VyZV9lbmRwb2ludHMgZmFpbHMKPiB3aXRoIC1FTk9ERVYuIFdlIGRv IG5vdCB3YW50IHRvIHByaW50IGFuIGVycm9yIGZvciB0aGlzLCBzbyB0aGlzIGNvbW1pdAo+IGFs c28gc2lsZW5jZXMgdGhlIHNob3N0X3ByaW50ayBmb3IgLUVOT0RFVi4KPiAKPiBFTkRRVU9URQo+ IAo+IEhvd2V2ZXIsIGlmIHdlIGRvIHRoYXQgd2UgYmV0dGVyIGRyb3AgYW55IHVuY29uZGl0aW9u YWwgZXhlY3V0aW9uCj4gYW5kIHJlcG9ydCB0byB0aGUgU0NTSSBzdWJzeXN0ZW0gdGhhdCB3ZSBo YXZlIHVuZGVyZ29uZSBhIHJlc2V0Cj4gYnV0IHdlIGFyZSBub3Qgb3BlcmF0aW9uYWwgbm93Lgo+ IAo+IFNpZ25lZC1vZmYtYnk6IE9saXZlciBOZXVrdW0gPG9uZXVrdW1Ac3VzZS5jb20+Cj4gUmVw b3J0ZWQtYnk6IEhhbnMgZGUgR29lZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+Cj4gQ0M6IHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmcKPiAtLS0KPiAgTWFrZWZpbGUgICAgICAgICAgICAgICAgICB8IDIg Ky0KCkkgZG9uJ3QgdGhpbmsgeW91IHdhbnQgbWUgdG8gcGF0Y2ggdGhpcyBmaWxlIDopCi0tLQpU byB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUg bGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2Vy bmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21h am9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:57313 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbeAKLWd (ORCPT ); Thu, 11 Jan 2018 06:22:33 -0500 Date: Thu, 11 Jan 2018 12:22:34 +0100 From: Greg KH To: Oliver Neukum Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] usb: uas: unconditionally bring back host after reset Message-ID: <20180111112234.GA16268@kroah.com> References: <20180111105954.8024-1-oneukum@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180111105954.8024-1-oneukum@suse.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Jan 11, 2018 at 11:59:54AM +0100, Oliver Neukum wrote: > Quoting Hans: > > If we return 1 from our post_reset handler, then our disconnect handler > will be called immediately afterwards. Since pre_reset blocks all scsi > requests our disconnect handler will then hang in the scsi_remove_host > call. > > This is esp. bad because our disconnect handler hanging for ever also > stops the USB subsys from enumerating any new USB devices, causes commands > like lsusb to hang, etc. > > In practice this happens when unplugging some uas devices because the hub > code may see the device as needing a warm-reset and calls usb_reset_device > before seeing the disconnect. In this case uas_configure_endpoints fails > with -ENODEV. We do not want to print an error for this, so this commit > also silences the shost_printk for -ENODEV. > > ENDQUOTE > > However, if we do that we better drop any unconditional execution > and report to the SCSI subsystem that we have undergone a reset > but we are not operational now. > > Signed-off-by: Oliver Neukum > Reported-by: Hans de Goede > CC: stable@vger.kernel.org > --- > Makefile | 2 +- I don't think you want me to patch this file :)