From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>, bhelgaas@google.com
Cc: thierry.reding@gmail.com, cyndis@kapsi.fi, jonathanh@nvidia.com,
robh+dt@kernel.org, frowand.list@gmail.com, rjw@rjwysocki.net,
tglx@linutronix.de, vidyas@nvidia.com, kthota@nvidia.com,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH V5 3/7] PCI: tegra: Remove PCI_REASSIGN_ALL_BUS flag for Tegra PCIe
Date: Thu, 11 Jan 2018 13:49:25 +0000 [thread overview]
Message-ID: <20180111134925.GA10168@red-moon> (raw)
In-Reply-To: <1515489577-2197-4-git-send-email-mmaddireddy@nvidia.com>
Hi Bjorn,
On Tue, Jan 09, 2018 at 02:49:33PM +0530, Manikanta Maddireddy wrote:
> Primary, secondary and subordinate default bus numbers are 0 in Tegra and
> it is expecting SW to program these numbers in configration space.
>
> pci_scan_bridge_extend() function programs these numbers in configuration
> space if secondary & subordinate bus numbers are 0 or PCI_REASSIGN_ALL_BUS
> flag is set. Since secondary & subordinate default bus numbers are 0,
> PCI_REASSIGN_ALL_BUS flag can be removed for Tegra PCIe.
>
> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Would you mind applying this patch (NB: it is the patch in the v5
version - this patch - not the one in v6 that is a rebased version):
https://patchwork.ozlabs.org/patch/857318/
to your pci/resource branch please (there is a dependency) ?
This would allow me to apply the rest of the patches in the series
that I consider mergeable independently of your tree branches, to
simplify the dependency.
Thanks !
Lorenzo
> ---
> V3:
> * new patch in V3
> V4:
> * no change in this patch
> V5:
> * no change in this patch
>
> drivers/pci/host/pci-tegra.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
> index d790a26ad87e..e4b47ebc91fe 100644
> --- a/drivers/pci/host/pci-tegra.c
> +++ b/drivers/pci/host/pci-tegra.c
> @@ -2293,7 +2293,6 @@ static int tegra_pcie_probe(struct platform_device *pdev)
>
> tegra_pcie_enable_ports(pcie);
>
> - pci_add_flags(PCI_REASSIGN_ALL_BUS);
> host->busnr = pcie->busn.start;
> host->dev.parent = &pdev->dev;
> host->ops = &tegra_pcie_ops;
> --
> 2.1.4
>
next prev parent reply other threads:[~2018-01-11 13:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 9:19 [PATCH V5 0/7] Add loadable kernel module and power management support Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-09 9:19 ` [PATCH V5 1/7] of: Export of_pci_range_to_resource() Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-09 9:19 ` [PATCH V5 2/7] PCI: tegra: Use bus->sysdata to store and get host private data Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-09 9:19 ` [PATCH V5 3/7] PCI: tegra: Remove PCI_REASSIGN_ALL_BUS flag for Tegra PCIe Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-11 13:49 ` Lorenzo Pieralisi [this message]
2018-01-11 18:27 ` Bjorn Helgaas
2018-01-11 18:27 ` Bjorn Helgaas
2018-01-09 9:19 ` [PATCH V5 4/7] PCI: tegra: Free resources on probe failure Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-09 9:19 ` [PATCH V5 5/7] PCI: tegra: Add loadable kernel module support Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-09 9:19 ` [PATCH V5 6/7] PCI: tegra: Broadcast PME_Turn_Off message before link goes to L2 Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-09 9:19 ` [PATCH V5 7/7] PCI: tegra: Add power management support Manikanta Maddireddy
2018-01-09 9:19 ` Manikanta Maddireddy
2018-01-10 17:15 ` [PATCH V5 0/7] Add loadable kernel module and " Lorenzo Pieralisi
2018-01-11 6:15 ` Manikanta Maddireddy
2018-01-11 6:15 ` Manikanta Maddireddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111134925.GA10168@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=cyndis@kapsi.fi \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mmaddireddy@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.