From: Igor Mammedov <imammedo@redhat.com>
To: Jay Zhou <jianjay.zhou@huawei.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, weidong.huang@huawei.com,
wangxinxin.wang@huawei.com, arei.gonglei@huawei.com,
liuzhe13@huawei.com
Subject: Re: [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring
Date: Thu, 11 Jan 2018 14:05:20 +0100 [thread overview]
Message-ID: <20180111140057.61f36a8f@redhat.com> (raw)
In-Reply-To: <1515515942-33692-1-git-send-email-jianjay.zhou@huawei.com>
On Wed, 10 Jan 2018 00:39:02 +0800
Jay Zhou <jianjay.zhou@huawei.com> wrote:
Jay,
considering how non trivial touched code is, would you mind
first adding 'make check' testcases for success/failure paths
that you are touching?
It would help with merging and ensure that future changes to
vhost won't break memslots handling.
> v4 -> v5:
> Making the followed up device_add to fall back to userspace
> virtio when netdev_add fails if vhost force flag does not set.
>
> Jay Zhou (4):
> vhost: remove assertion to prevent crash
> tap: do not close fd if only vhost failed to initialize
> vhost: fix memslot limit check
> vhost: used_memslots refactoring
>
> hw/virtio/vhost-backend.c | 15 +++++++-
> hw/virtio/vhost-user.c | 74 +++++++++++++++++++++++++++------------
> hw/virtio/vhost.c | 30 +++++++++-------
> include/hw/virtio/vhost-backend.h | 6 ++--
> net/tap.c | 25 +++++++++----
> 5 files changed, 104 insertions(+), 46 deletions(-)
>
> --
> 1.8.3.1
>
>
next prev parent reply other threads:[~2018-01-11 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 16:39 [Qemu-devel] [PATCH v5 0/4] vhost: two fixes and used_memslots refactoring Jay Zhou
2018-01-11 13:05 ` Igor Mammedov [this message]
2018-01-11 13:55 ` Zhoujian (jay)
2018-01-11 19:55 ` Michael S. Tsirkin
2018-01-12 1:41 ` Zhoujian (jay)
2018-01-11 20:13 ` Michael S. Tsirkin
2018-01-12 9:18 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111140057.61f36a8f@redhat.com \
--to=imammedo@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=jianjay.zhou@huawei.com \
--cc=liuzhe13@huawei.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wangxinxin.wang@huawei.com \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.