From: "Theodore Ts'o" <tytso@mit.edu>
To: Eric Whitney <enwlinux@gmail.com>
Cc: fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling
Date: Thu, 11 Jan 2018 13:21:24 -0500 [thread overview]
Message-ID: <20180111182124.GA30608@thunk.org> (raw)
In-Reply-To: <20180110211905.4ulqeqnwbs2bh66o@localhost.localdomain>
On Wed, Jan 10, 2018 at 04:19:05PM -0500, Eric Whitney wrote:
> Modify _require_odirect() to skip O_DIRECT tests if the ext4 mount
> option data=journal has been applied. Because ext4 disables its
> O_DIRECT support when in data journaling mode, no significant value is
> obtained by running these tests and they consume a significant amount
> of run time. Additionally, this change eliminates the need to triage
> false negative O_DIRECT test results caused by test problems, as has
> occurred from time to time.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2018-01-11 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 21:19 [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling Eric Whitney
2018-01-11 18:21 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111182124.GA30608@thunk.org \
--to=tytso@mit.edu \
--cc=enwlinux@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.