Re: [PATCH rdma-next v3 1/7] RDMA/restrack: Add general infrastructure to track RDMA resources

[Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

On Thu, Jan 11, 2018 at 07:47:27PM +0000, Bart Van Assche wrote:
> On Thu, 2018-01-11 at 17:31 +0200, Leon Romanovsky wrote:
> > +struct rdma_restrack_entry {
> > +       struct list_head        list;
> > +
> > +       /*
> > +        * The entries are filled during rdma_restrack_add,
> > +        * can be attempted to be free during rdma_restrack_del.
> > +        *
> > +        * As an example for that, see mlx5 QPs with type MLX5_IB_QPT_HW_GSI
> > +        */
> > +       bool                    valid;
> > +
> > +       /*
> > +        * Sleepabale RCU to protect object data.
> > +        */
> > +       struct srcu_struct      srcu;
> > +
> > +       struct task_struct      *task;
> > +       char                    *task_comm;
> > +};
> 
> Please use the kernel-doc syntax to document the meaning of the names of the
> fields in this structure. It is e.g. nontrivial to guess what "task_comm" stands
> for. The presense of a task_struct pointer is also nontrivial.

And task_comm doesn't seem like a great name anymore, and should be
const char *, right ?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html