From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/7] drm/i915: Disable preemption and sleeping while using the punit sideband Date: Thu, 11 Jan 2018 22:10:45 +0200 Message-ID: <20180111201045.GZ10981@intel.com> References: <20180110125511.11127-1-chris@chris-wilson.co.uk> <20180110125511.11127-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5FB546E455 for ; Thu, 11 Jan 2018 20:10:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20180110125511.11127-2-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Hans de Goede List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMTAsIDIwMTggYXQgMTI6NTU6MDVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFdoaWxlIHdlIHRhbGsgdG8gdGhlIHB1bml0IG92ZXIgaXRzIHNpZGViYW5kLCB3ZSBu ZWVkIHRvIHByZXZlbnQgdGhlIGNwdQo+IGZyb20gc2xlZXBpbmcgaW4gb3JkZXIgdG8gcHJldmVu dCBhIHBvdGVudGlhbCBtYWNoaW5lIGhhbmcuCj4gCj4gTm90ZSB0aGF0IGJ5IGl0c2VsZiwgaXQg YXBwZWFycyB0aGF0IHBtX3Fvc191cGRhdGVfcmVxdWVzdCAodmlhCj4gaW50ZWxfaWRsZSkgZG9l c24ndCBwcm92aWRlIGEgc3VmZmljaWVudCBiYXJyaWVyIHRvIGVuc3VyZSB0aGF0IGFsbCBjb3Jl Cj4gYXJlIGluZGVlZCBhd2FrZSAob3V0IG9mIENzdGF0ZSkgYW5kIHRoYXQgdGhlIHBhY2thZ2Ug aXMgYXdha2UuIFRvIGRvIHNvLAo+IHdlIG5lZWQgdG8gc3VwcGxlbWVudCB0aGUgcG1fcW9zIHdp dGggYSBtYW51YWwgcGluZyBvbl9lYWNoX2NwdS4KPiAKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWd6 aWxsYS5rZXJuZWwub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDkwNTEKPiBSZWZlcmVuY2VzOiBodHRw czovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDI2NTcKPiBSZWZlcmVu Y2VzOiBodHRwczovL2J1Z3ppbGxhLmtlcm5lbC5vcmcvc2hvd19idWcuY2dpP2lkPTE5NTI1NQo+ IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzog SGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuYyAgICAgICB8ICA2ICsrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaCAgICAgICB8ICAxICsKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf c2lkZWJhbmQuYyB8IDYxICsrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCj4gIDMg ZmlsZXMgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggNmM4ZGE5ZDIwYzMzLi5kNGI5MGNjMDEzMGIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBAQCAtOTAyLDYgKzkwMiw5IEBAIHN0YXRpYyBp bnQgaTkxNV9kcml2ZXJfaW5pdF9lYXJseShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gIAlzcGluX2xvY2tfaW5pdCgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsKPiAgCj4gIAlt dXRleF9pbml0KCZkZXZfcHJpdi0+c2JfbG9jayk7Cj4gKwlwbV9xb3NfYWRkX3JlcXVlc3QoJmRl dl9wcml2LT5zYl9xb3MsCj4gKwkJCSAgIFBNX1FPU19DUFVfRE1BX0xBVEVOQ1ksIFBNX1FPU19E RUZBVUxUX1ZBTFVFKTsKPiArCj4gIAltdXRleF9pbml0KCZkZXZfcHJpdi0+bW9kZXNldF9yZXN0 b3JlX2xvY2spOwo+ICAJbXV0ZXhfaW5pdCgmZGV2X3ByaXYtPmF2X211dGV4KTsKPiAgCW11dGV4 X2luaXQoJmRldl9wcml2LT53bS53bV9tdXRleCk7Cj4gQEAgLTk1Myw2ICs5NTYsOSBAQCBzdGF0 aWMgdm9pZCBpOTE1X2RyaXZlcl9jbGVhbnVwX2Vhcmx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdikKPiAgCWludGVsX2lycV9maW5pKGRldl9wcml2KTsKPiAgCWk5MTVfd29ya3F1 ZXVlc19jbGVhbnVwKGRldl9wcml2KTsKPiAgCWk5MTVfZW5naW5lc19jbGVhbnVwKGRldl9wcml2 KTsKPiArCj4gKwlwbV9xb3NfcmVtb3ZlX3JlcXVlc3QoJmRldl9wcml2LT5zYl9xb3MpOwo+ICsJ bXV0ZXhfZGVzdHJveSgmZGV2X3ByaXYtPnNiX2xvY2spOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50 IGk5MTVfbW1pb19zZXR1cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggYTY4OTM5NmQwZmY2Li5mZjNmOWVmZmMwYmIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMTg4Nyw2ICsxODg3LDcgQEAgc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgewo+ICAKPiAgCS8qIFNpZGViYW5kIG1haWxib3ggcHJvdGVjdGlv biAqLwo+ICAJc3RydWN0IG11dGV4IHNiX2xvY2s7Cj4gKwlzdHJ1Y3QgcG1fcW9zX3JlcXVlc3Qg c2JfcW9zOwo+ICAKPiAgCS8qKiBDYWNoZWQgdmFsdWUgb2YgSU1SIHRvIGF2b2lkIHJlYWRzIGlu IHVwZGF0aW5nIHRoZSBiaXRmaWVsZCAqLwo+ICAJdW5pb24gewo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfc2lkZWJhbmQuYwo+IGluZGV4IDc1Yzg3MmJiOGNjOS4uMDJiZGQyZTJjZWY2IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3NpZGViYW5kLmMKPiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9zaWRlYmFuZC5jCj4gQEAgLTIyLDYgKzIyLDggQEAK PiAgICoKPiAgICovCj4gIAo+ICsjaW5jbHVkZSA8YXNtL2lvc2ZfbWJpLmg+Cj4gKwo+ICAjaW5j bHVkZSAiaTkxNV9kcnYuaCIKPiAgI2luY2x1ZGUgImludGVsX2Rydi5oIgo+ICAKPiBAQCAtMzks MTggKzQxLDIwIEBACj4gIC8qIFByaXZhdGUgcmVnaXN0ZXIgd3JpdGUsIGRvdWJsZS13b3JkIGFk ZHJlc3NpbmcsIG5vbi1wb3N0ZWQgKi8KPiAgI2RlZmluZSBTQl9DUldSREFfTlAJMHgwNwo+ICAK PiAtc3RhdGljIGludCB2bHZfc2lkZWJhbmRfcncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2LCB1MzIgZGV2Zm4sCj4gLQkJCSAgIHUzMiBwb3J0LCB1MzIgb3Bjb2RlLCB1MzIgYWRk ciwgdTMyICp2YWwpCj4gK3N0YXRpYyB2b2lkIHBpbmcodm9pZCAqaW5mbykKPiAgewo+IC0JdTMy IGNtZCwgYmUgPSAweGYsIGJhciA9IDA7Cj4gLQlib29sIGlzX3JlYWQgPSAob3Bjb2RlID09IFNC X01SRF9OUCB8fCBvcGNvZGUgPT0gU0JfQ1JSRERBX05QKTsKPiArfQo+ICAKPiAtCWNtZCA9IChk ZXZmbiA8PCBJT1NGX0RFVkZOX1NISUZUKSB8IChvcGNvZGUgPDwgSU9TRl9PUENPREVfU0hJRlQp IHwKPiAtCQkocG9ydCA8PCBJT1NGX1BPUlRfU0hJRlQpIHwgKGJlIDw8IElPU0ZfQllURV9FTkFC TEVTX1NISUZUKSB8Cj4gLQkJKGJhciA8PCBJT1NGX0JBUl9TSElGVCk7Cj4gK3N0YXRpYyBpbnQg dmx2X3NpZGViYW5kX3J3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiArCQkJ ICAgdTMyIGRldmZuLCB1MzIgcG9ydCwgdTMyIG9wY29kZSwKPiArCQkJICAgdTMyIGFkZHIsIHUz MiAqdmFsKQo+ICt7Cj4gKwljb25zdCBib29sIGlzX3JlYWQgPSAob3Bjb2RlID09IFNCX01SRF9O UCB8fCBvcGNvZGUgPT0gU0JfQ1JSRERBX05QKTsKPiArCWludCBlcnI7Cj4gIAo+IC0JV0FSTl9P TighbXV0ZXhfaXNfbG9ja2VkKCZkZXZfcHJpdi0+c2JfbG9jaykpOwo+ICsJbG9ja2RlcF9hc3Nl cnRfaGVsZCgmZGV2X3ByaXYtPnNiX2xvY2spOwo+ICAKPiArCS8qIEZsdXNoIHRoZSBwcmV2aW91 cyBjb21tcywganVzdCBpbiBjYXNlIGl0IGZhaWxlZCBsYXN0IHRpbWUuICovCj4gIAlpZiAoaW50 ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gIAkJCQkgICAgVkxWX0lPU0ZfRE9PUkJF TExfUkVRLCBJT1NGX1NCX0JVU1ksIDAsCj4gIAkJCQkgICAgNSkpIHsKPiBAQCAtNTksMjIgKzYz LDQzIEBAIHN0YXRpYyBpbnQgdmx2X3NpZGViYW5kX3J3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwgdTMyIGRldmZuLAo+ICAJCXJldHVybiAtRUFHQUlOOwo+ICAJfQo+ICAKPiAt CUk5MTVfV1JJVEUoVkxWX0lPU0ZfQUREUiwgYWRkcik7Cj4gLQlJOTE1X1dSSVRFKFZMVl9JT1NG X0RBVEEsIGlzX3JlYWQgPyAwIDogKnZhbCk7Cj4gLQlJOTE1X1dSSVRFKFZMVl9JT1NGX0RPT1JC RUxMX1JFUSwgY21kKTsKPiArCWlvc2ZfbWJpX3B1bml0X2FjcXVpcmUoKTsKPiAgCj4gLQlpZiAo aW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsCj4gLQkJCQkgICAgVkxWX0lPU0ZfRE9P UkJFTExfUkVRLCBJT1NGX1NCX0JVU1ksIDAsCj4gLQkJCQkgICAgNSkpIHsKPiArCS8qCj4gKwkg KiBQcmV2ZW50IHRoZSBjcHUgZnJvbSBzbGVlcGluZyB3aGlsZSB3ZSB1c2UgdGhpcyBzaWRlYmFu ZCwgb3RoZXJ3aXNlCj4gKwkgKiB0aGUgcHVuaXQgbWF5IGNhdXNlIGEgbWFjaGluZSBoYW5nLgo+ ICsJICovCj4gKwlwbV9xb3NfdXBkYXRlX3JlcXVlc3QoJmRldl9wcml2LT5zYl9xb3MsIDApOwo+ ICsJb25fZWFjaF9jcHUocGluZywgTlVMTCwgMSk7CgpwbV9xb3NfdXBkYXRlX3JlcXVlc3QoKSBk b2Vzbid0IHdha2UgdXAgdGhlIGNwdXMgb24gaXRzIG93bj8gSSB3b25kZXIKa2luZCBvZiBsYXRl bmN5IGd1YXJhbnRlZXMgaXQgY2FuIGFjdHVhbGx5IGdpdmUgd2l0aG91dCBkb2luZyB0aGF0LgoK U2hvdWxkbid0IHdlIGNoZWNrIGlmIHdlJ3JlIGFjdHVhbGx5IGJlIHRhbGtpbmcgdG8gdGhlIHB1 bml0IGFuZCBub3QKc29tZSBvdGhlciB1bml0IGJlZm9yZSB3ZSBkbyBhbGwgdGhpcyBleHRyYSB3 b3JrPwoKPiArCXByZWVtcHRfZGlzYWJsZSgpOwo+ICsKPiArCUk5MTVfV1JJVEVfRlcoVkxWX0lP U0ZfQUREUiwgYWRkcik7Cj4gKwlJOTE1X1dSSVRFX0ZXKFZMVl9JT1NGX0RBVEEsIGlzX3JlYWQg PyAwIDogKnZhbCk7Cj4gKwlJOTE1X1dSSVRFX0ZXKFZMVl9JT1NGX0RPT1JCRUxMX1JFUSwKPiAr CQkgICAgICAoZGV2Zm4gPDwgSU9TRl9ERVZGTl9TSElGVCkgfAo+ICsJCSAgICAgIChvcGNvZGUg PDwgSU9TRl9PUENPREVfU0hJRlQpIHwKPiArCQkgICAgICAocG9ydCA8PCBJT1NGX1BPUlRfU0hJ RlQpIHwKPiArCQkgICAgICAoMHhmIDw8IElPU0ZfQllURV9FTkFCTEVTX1NISUZUKSB8Cj4gKwkJ ICAgICAgKDAgPDwgSU9TRl9CQVJfU0hJRlQpIHwKPiArCQkgICAgICBJT1NGX1NCX0JVU1kpOwo+ ICsKPiArCWlmIChfX2ludGVsX3dhaXRfZm9yX3JlZ2lzdGVyX2Z3KGRldl9wcml2LAo+ICsJCQkJ CSBWTFZfSU9TRl9ET09SQkVMTF9SRVEsIElPU0ZfU0JfQlVTWSwgMCwKPiArCQkJCQkgMTAwMDAs IDAsIE5VTEwpID09IDApIHsKPiArCQlpZiAoaXNfcmVhZCkKPiArCQkJKnZhbCA9IEk5MTVfUkVB RF9GVyhWTFZfSU9TRl9EQVRBKTsKPiArCQllcnIgPSAwOwo+ICsJfSBlbHNlIHsKPiAgCQlEUk1f REVCVUdfRFJJVkVSKCJJT1NGIHNpZGViYW5kIGZpbmlzaCB3YWl0ICglcykgdGltZWQgb3V0XG4i LAo+ICAJCQkJIGlzX3JlYWQgPyAicmVhZCIgOiAid3JpdGUiKTsKPiAtCQlyZXR1cm4gLUVUSU1F RE9VVDsKPiArCQllcnIgPSAtRVRJTUVET1VUOwo+ICAJfQo+ICAKPiAtCWlmIChpc19yZWFkKQo+ IC0JCSp2YWwgPSBJOTE1X1JFQUQoVkxWX0lPU0ZfREFUQSk7Cj4gKwlwcmVlbXB0X2VuYWJsZSgp Owo+ICsJcG1fcW9zX3VwZGF0ZV9yZXF1ZXN0KCZkZXZfcHJpdi0+c2JfcW9zLCBQTV9RT1NfREVG QVVMVF9WQUxVRSk7Cj4gKwlpb3NmX21iaV9wdW5pdF9yZWxlYXNlKCk7Cj4gIAo+IC0JcmV0dXJu IDA7Cj4gKwlyZXR1cm4gZXJyOwo+ICB9Cj4gIAo+ICB1MzIgdmx2X3B1bml0X3JlYWQoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgYWRkcikKPiAtLSAKPiAyLjE1LjEKCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=