Re: [Qemu-devel] [PATCH v2 2.5/6] hmp: Add name parameter to nbd_server_add

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Eric Blake (eblake@redhat.com) wrote:
> On 01/11/2018 11:59 AM, Dr. David Alan Gilbert wrote:
> > * Eric Blake (eblake@redhat.com) wrote:
> >> Extend the flexibility of the previous QMP patch to also work
> >> in HMP.
> >>
> >> Signed-off-by: Eric Blake <eblake@redhat.com>
> > 
> > Thanks, that looks good to me from the HMP side; let me
> > know which way you want to take it; I can take it via
> > HMP once the code that uses it is in; whichever is easiest.
> > 
> > 
> > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> 
> I'll take it through the NBD tree, along with the rest of the series,
> once I get more answers on my open questions on the second half of the
> series.

Sure.

> > 
> >> ---
> >>
> >> In response to Dave's request.
> >> I could also squash this into Vladimir's 2/6 if desired.
> 
> At this point, I'm thinking it's better to leave it separate from
> Vladimir's QMP patch, since you've only reviewed this one.

Feel free to do either way.

Dave

> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
> 



--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK