From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/7] drm/i915: Disable preemption and sleeping while using the punit sideband Date: Thu, 11 Jan 2018 23:17:57 +0200 Message-ID: <20180111211757.GA10981@intel.com> References: <20180110125511.11127-1-chris@chris-wilson.co.uk> <20180110125511.11127-2-chris@chris-wilson.co.uk> <20180111201045.GZ10981@intel.com> <151570402215.23681.2997454528847692944@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8621E6E2AE for ; Thu, 11 Jan 2018 21:18:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <151570402215.23681.2997454528847692944@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, Hans de Goede List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKYW4gMTEsIDIwMTggYXQgMDg6NTM6NDJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyasOkbMOkICgyMDE4LTAxLTExIDIwOjEwOjQ1KQo+ID4g T24gV2VkLCBKYW4gMTAsIDIwMTggYXQgMTI6NTU6MDVQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+ID4gPiBXaGlsZSB3ZSB0YWxrIHRvIHRoZSBwdW5pdCBvdmVyIGl0cyBzaWRlYmFuZCwg d2UgbmVlZCB0byBwcmV2ZW50IHRoZSBjcHUKPiA+ID4gZnJvbSBzbGVlcGluZyBpbiBvcmRlciB0 byBwcmV2ZW50IGEgcG90ZW50aWFsIG1hY2hpbmUgaGFuZy4KPiA+ID4gCj4gPiA+IE5vdGUgdGhh dCBieSBpdHNlbGYsIGl0IGFwcGVhcnMgdGhhdCBwbV9xb3NfdXBkYXRlX3JlcXVlc3QgKHZpYQo+ ID4gPiBpbnRlbF9pZGxlKSBkb2Vzbid0IHByb3ZpZGUgYSBzdWZmaWNpZW50IGJhcnJpZXIgdG8g ZW5zdXJlIHRoYXQgYWxsIGNvcmUKPiA+ID4gYXJlIGluZGVlZCBhd2FrZSAob3V0IG9mIENzdGF0 ZSkgYW5kIHRoYXQgdGhlIHBhY2thZ2UgaXMgYXdha2UuIFRvIGRvIHNvLAo+ID4gPiB3ZSBuZWVk IHRvIHN1cHBsZW1lbnQgdGhlIHBtX3FvcyB3aXRoIGEgbWFudWFsIHBpbmcgb25fZWFjaF9jcHUu Cj4gPiA+IAo+ID4gPiBCdWd6aWxsYTogaHR0cHM6Ly9idWd6aWxsYS5rZXJuZWwub3JnL3Nob3df YnVnLmNnaT9pZD0xMDkwNTEKPiA+ID4gUmVmZXJlbmNlczogaHR0cHM6Ly9idWdzLmZyZWVkZXNr dG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNjU3Cj4gPiA+IFJlZmVyZW5jZXM6IGh0dHBzOi8v YnVnemlsbGEua2VybmVsLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk1MjU1Cj4gPiA+IFNpZ25lZC1v ZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ID4gPiBDYzog TWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IENjOiBI YW5zIGRlIEdvZWRlIDxoZGVnb2VkZUByZWRoYXQuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgICAgICAgfCAgNiArKysrCj4gPiA+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAgIHwgIDEgKwo+ID4gPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQuYyB8IDYxICsrKysrKysrKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tCj4gPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDUwIGluc2VydGlvbnMoKyksIDE4IGRl bGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiA+IGluZGV4 IDZjOGRhOWQyMGMzMy4uZDRiOTBjYzAxMzBiIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmMKPiA+ID4gQEAgLTkwMiw2ICs5MDIsOSBAQCBzdGF0aWMgaW50IGk5MTVfZHJpdmVy X2luaXRfZWFybHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiAgICAg ICBzcGluX2xvY2tfaW5pdCgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsKPiA+ID4gIAo+ID4gPiAg ICAgICBtdXRleF9pbml0KCZkZXZfcHJpdi0+c2JfbG9jayk7Cj4gPiA+ICsgICAgIHBtX3Fvc19h ZGRfcmVxdWVzdCgmZGV2X3ByaXYtPnNiX3FvcywKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgIFBNX1FPU19DUFVfRE1BX0xBVEVOQ1ksIFBNX1FPU19ERUZBVUxUX1ZBTFVFKTsKPiA+ID4g Kwo+ID4gPiAgICAgICBtdXRleF9pbml0KCZkZXZfcHJpdi0+bW9kZXNldF9yZXN0b3JlX2xvY2sp Owo+ID4gPiAgICAgICBtdXRleF9pbml0KCZkZXZfcHJpdi0+YXZfbXV0ZXgpOwo+ID4gPiAgICAg ICBtdXRleF9pbml0KCZkZXZfcHJpdi0+d20ud21fbXV0ZXgpOwo+ID4gPiBAQCAtOTUzLDYgKzk1 Niw5IEBAIHN0YXRpYyB2b2lkIGk5MTVfZHJpdmVyX2NsZWFudXBfZWFybHkoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gPiAgICAgICBpbnRlbF9pcnFfZmluaShkZXZfcHJp dik7Cj4gPiA+ICAgICAgIGk5MTVfd29ya3F1ZXVlc19jbGVhbnVwKGRldl9wcml2KTsKPiA+ID4g ICAgICAgaTkxNV9lbmdpbmVzX2NsZWFudXAoZGV2X3ByaXYpOwo+ID4gPiArCj4gPiA+ICsgICAg IHBtX3Fvc19yZW1vdmVfcmVxdWVzdCgmZGV2X3ByaXYtPnNiX3Fvcyk7Cj4gPiA+ICsgICAgIG11 dGV4X2Rlc3Ryb3koJmRldl9wcml2LT5zYl9sb2NrKTsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiAg c3RhdGljIGludCBpOTE1X21taW9fc2V0dXAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+ID4gaW5kZXggYTY4OTM5NmQwZmY2 Li5mZjNmOWVmZmMwYmIgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4g PiBAQCAtMTg4Nyw2ICsxODg3LDcgQEAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgewo+ID4gPiAg Cj4gPiA+ICAgICAgIC8qIFNpZGViYW5kIG1haWxib3ggcHJvdGVjdGlvbiAqLwo+ID4gPiAgICAg ICBzdHJ1Y3QgbXV0ZXggc2JfbG9jazsKPiA+ID4gKyAgICAgc3RydWN0IHBtX3Fvc19yZXF1ZXN0 IHNiX3FvczsKPiA+ID4gIAo+ID4gPiAgICAgICAvKiogQ2FjaGVkIHZhbHVlIG9mIElNUiB0byBh dm9pZCByZWFkcyBpbiB1cGRhdGluZyB0aGUgYml0ZmllbGQgKi8KPiA+ID4gICAgICAgdW5pb24g ewo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfc2lkZWJhbmQu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3NpZGViYW5kLmMKPiA+ID4gaW5kZXggNzVj ODcyYmI4Y2M5Li4wMmJkZDJlMmNlZjYgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3NpZGViYW5kLmMKPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfc2lkZWJhbmQuYwo+ID4gPiBAQCAtMjIsNiArMjIsOCBAQAo+ID4gPiAgICoKPiA+ID4g ICAqLwo+ID4gPiAgCj4gPiA+ICsjaW5jbHVkZSA8YXNtL2lvc2ZfbWJpLmg+Cj4gPiA+ICsKPiA+ ID4gICNpbmNsdWRlICJpOTE1X2Rydi5oIgo+ID4gPiAgI2luY2x1ZGUgImludGVsX2Rydi5oIgo+ ID4gPiAgCj4gPiA+IEBAIC0zOSwxOCArNDEsMjAgQEAKPiA+ID4gIC8qIFByaXZhdGUgcmVnaXN0 ZXIgd3JpdGUsIGRvdWJsZS13b3JkIGFkZHJlc3NpbmcsIG5vbi1wb3N0ZWQgKi8KPiA+ID4gICNk ZWZpbmUgU0JfQ1JXUkRBX05QIDB4MDcKPiA+ID4gIAo+ID4gPiAtc3RhdGljIGludCB2bHZfc2lk ZWJhbmRfcncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1MzIgZGV2Zm4sCj4g PiA+IC0gICAgICAgICAgICAgICAgICAgICAgICB1MzIgcG9ydCwgdTMyIG9wY29kZSwgdTMyIGFk ZHIsIHUzMiAqdmFsKQo+ID4gPiArc3RhdGljIHZvaWQgcGluZyh2b2lkICppbmZvKQo+ID4gPiAg ewo+ID4gPiAtICAgICB1MzIgY21kLCBiZSA9IDB4ZiwgYmFyID0gMDsKPiA+ID4gLSAgICAgYm9v bCBpc19yZWFkID0gKG9wY29kZSA9PSBTQl9NUkRfTlAgfHwgb3Bjb2RlID09IFNCX0NSUkREQV9O UCk7Cj4gPiA+ICt9Cj4gPiA+ICAKPiA+ID4gLSAgICAgY21kID0gKGRldmZuIDw8IElPU0ZfREVW Rk5fU0hJRlQpIHwgKG9wY29kZSA8PCBJT1NGX09QQ09ERV9TSElGVCkgfAo+ID4gPiAtICAgICAg ICAgICAgIChwb3J0IDw8IElPU0ZfUE9SVF9TSElGVCkgfCAoYmUgPDwgSU9TRl9CWVRFX0VOQUJM RVNfU0hJRlQpIHwKPiA+ID4gLSAgICAgICAgICAgICAoYmFyIDw8IElPU0ZfQkFSX1NISUZUKTsK PiA+ID4gK3N0YXRpYyBpbnQgdmx2X3NpZGViYW5kX3J3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgIHUzMiBkZXZmbiwgdTMy IHBvcnQsIHUzMiBvcGNvZGUsCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICB1MzIgYWRk ciwgdTMyICp2YWwpCj4gPiA+ICt7Cj4gPiA+ICsgICAgIGNvbnN0IGJvb2wgaXNfcmVhZCA9IChv cGNvZGUgPT0gU0JfTVJEX05QIHx8IG9wY29kZSA9PSBTQl9DUlJEREFfTlApOwo+ID4gPiArICAg ICBpbnQgZXJyOwo+ID4gPiAgCj4gPiA+IC0gICAgIFdBUk5fT04oIW11dGV4X2lzX2xvY2tlZCgm ZGV2X3ByaXYtPnNiX2xvY2spKTsKPiA+ID4gKyAgICAgbG9ja2RlcF9hc3NlcnRfaGVsZCgmZGV2 X3ByaXYtPnNiX2xvY2spOwo+ID4gPiAgCj4gPiA+ICsgICAgIC8qIEZsdXNoIHRoZSBwcmV2aW91 cyBjb21tcywganVzdCBpbiBjYXNlIGl0IGZhaWxlZCBsYXN0IHRpbWUuICovCj4gPiA+ICAgICAg IGlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiA+ID4gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFZMVl9JT1NGX0RPT1JCRUxMX1JFUSwgSU9TRl9TQl9CVVNZ LCAwLAo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgNSkpIHsKPiA+ID4g QEAgLTU5LDIyICs2Myw0MyBAQCBzdGF0aWMgaW50IHZsdl9zaWRlYmFuZF9ydyhzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBkZXZmbiwKPiA+ID4gICAgICAgICAgICAgICBy ZXR1cm4gLUVBR0FJTjsKPiA+ID4gICAgICAgfQo+ID4gPiAgCj4gPiA+IC0gICAgIEk5MTVfV1JJ VEUoVkxWX0lPU0ZfQUREUiwgYWRkcik7Cj4gPiA+IC0gICAgIEk5MTVfV1JJVEUoVkxWX0lPU0Zf REFUQSwgaXNfcmVhZCA/IDAgOiAqdmFsKTsKPiA+ID4gLSAgICAgSTkxNV9XUklURShWTFZfSU9T Rl9ET09SQkVMTF9SRVEsIGNtZCk7Cj4gPiA+ICsgICAgIGlvc2ZfbWJpX3B1bml0X2FjcXVpcmUo KTsKPiA+ID4gIAo+ID4gPiAtICAgICBpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3By aXYsCj4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBWTFZfSU9TRl9ET09S QkVMTF9SRVEsIElPU0ZfU0JfQlVTWSwgMCwKPiA+ID4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIDUpKSB7Cj4gPiA+ICsgICAgIC8qCj4gPiA+ICsgICAgICAqIFByZXZlbnQgdGhl IGNwdSBmcm9tIHNsZWVwaW5nIHdoaWxlIHdlIHVzZSB0aGlzIHNpZGViYW5kLCBvdGhlcndpc2UK PiA+ID4gKyAgICAgICogdGhlIHB1bml0IG1heSBjYXVzZSBhIG1hY2hpbmUgaGFuZy4KPiA+ID4g KyAgICAgICovCj4gPiA+ICsgICAgIHBtX3Fvc191cGRhdGVfcmVxdWVzdCgmZGV2X3ByaXYtPnNi X3FvcywgMCk7Cj4gPiA+ICsgICAgIG9uX2VhY2hfY3B1KHBpbmcsIE5VTEwsIDEpOwo+ID4gCj4g PiBwbV9xb3NfdXBkYXRlX3JlcXVlc3QoKSBkb2Vzbid0IHdha2UgdXAgdGhlIGNwdXMgb24gaXRz IG93bj8gSSB3b25kZXIKPiA+IGtpbmQgb2YgbGF0ZW5jeSBndWFyYW50ZWVzIGl0IGNhbiBhY3R1 YWxseSBnaXZlIHdpdGhvdXQgZG9pbmcgdGhhdC4KPiAKPiBpbnRlbF9pZGxlIHBsdWdzIGludG8g dGhlIHVwZGF0ZSB0byB3YWtlIHVwIGlkbGUgY3B1cywgYnV0IGl0IGlzIG5vdAo+IHN5bmNocm9u b3VzLiBJZiB3ZSBkb24ndCBoYXZlIHRoZSBvbl9lYWNoX2NwdSgpIGhlcmUsIHRoZSBoYW5ncyBy ZW9jY3VyOwo+IHRoZSBlYXNpZXN0IGFuc3dlciBzZWVtcyB0byBiZSB0aGF0IHRoZSBvbl9lYWNo X2NwdSgpIGlzIGNhdXNpbmcgYQo+IHNjaGVkdWxlIG9mIHRoZSBSVCBtaWdyYXRpb24gdGhyZWFk IHdoaWNoIGlzIGVub3VnaCB0byBlbnN1cmUgdGhhdCB0aGUKPiB3YWtldXAgaGFzIG9jY3VycmVk Lgo+ICAKPiA+IFNob3VsZG4ndCB3ZSBjaGVjayBpZiB3ZSdyZSBhY3R1YWxseSBiZSB0YWxraW5n IHRvIHRoZSBwdW5pdCBhbmQgbm90Cj4gPiBzb21lIG90aGVyIHVuaXQgYmVmb3JlIHdlIGRvIGFs bCB0aGlzIGV4dHJhIHdvcms/Cj4gCj4gQ2hlY2tpbmcgcG9ydD8gSSBhbSBzdXNwaWNpb3VzIG9m IHRoZSB3aG9sZSBpb3NmIG1lY2hhbmlzbS4uLgoKSSBkb3VidCBpb3NmIHNiIGl0c2VsZiBpcyBi dXN0ZWQuIFRoYXQgd291bGQgcHJvYmFibHkgbWFrZSB0aGUgZW50aXJlCnNvYyBwcmV0dHkgbXVj aCBkZWFkLiBJIHN1c3BlY3QgdGhlIHByb2JsZW0gaXMgZWl0aGVyIGluIHRoZSBwdW5pdApmaXJt d2FyZSwgb3Igc29tZXRoaW5nIGZpc2h5IGlzIGdvaW5nIG9uIHdpdGggcG93ZXIgZGVsaXZlcnkg YW5kCnJlZHVjaW5nIHRoZSByYXRlIGF0IHdoaWNoIHdlIGNoYW5nZSB0aGUgdm9sdGFnZXMgYW5k IHdoYXRub3QgaGVscHMKa2VlcCB0aGluZ3MgYSBiaXQgbW9yZSBzdGFibGUuCgpTbyB5ZWFoLCBJ IHdvdWxkIGxpbWl0IHRoaXMgdG8gcHVuaXQgb25seSBieSBjaGVja2luZyB0aGUgcG9ydC4KCj4g Cj4gQWxzbyBkZWJhdGluZyB3aGV0aGVyIHRvIG9ubHkgYXBwbHkgaXQgdG8gajE5MDAgb3IgYWxs LiBJcyBpdCBqdXN0IHB1cmUKPiBmbHVrZSB0aGF0IHdlIGNhbiBlYXNpbHkgcmVwcm9kdWNlIGl0 IG9uIHRoZSBxdWFkIGNvcmUgQmF5dHJhaWwgYXMKPiBvcHBvc2VkIHRvIHRoZSBkdWFsIGNvcmUg dmx2IG9yIGNodj8KCk5vdCBzdXJlLiBJIGd1ZXNzIGlmIHRoZSBwcm9ibGVtIGlzIGFyb3VuZCBw b3dlciBkZWxpdmVyeSBpdCBtaWdodCBldmVuCmJlIGJvYXJkIHNwZWNpZmljIHRvIHNvbWUgZGVn cmVlLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==