Re: [Qemu-devel] [PATCH v4 3/9] block: Add VFIO based NVMe driver

[Fam Zheng <famz@redhat.com>]

On Wed, 01/10 08:44, Eric Blake wrote:
> On 01/10/2018 03:18 AM, Fam Zheng wrote:
> > This is a new protocol driver that exclusively opens a host NVMe
> > controller through VFIO. It achieves better latency than linux-aio by
> > completely bypassing host kernel vfs/block layer.
> > 
> 
> > +static BlockDriver bdrv_nvme = {
> > +    .format_name              = "nvme",
> > +    .protocol_name            = "nvme",
> > +    .instance_size            = sizeof(BDRVNVMeState),
> > +
> > +    .bdrv_parse_filename      = nvme_parse_filename,
> > +    .bdrv_file_open           = nvme_file_open,
> > +    .bdrv_close               = nvme_close,
> > +    .bdrv_getlength           = nvme_getlength,
> > +
> > +    .bdrv_co_preadv           = nvme_co_preadv,
> > +    .bdrv_co_pwritev          = nvme_co_pwritev,
> > +    .bdrv_co_flush_to_disk    = nvme_co_flush,
> > +    .bdrv_reopen_prepare      = nvme_reopen_prepare,
> > +
> > +    .bdrv_co_get_block_status = nvme_co_get_block_status,
> 
> Semantic conflict with my pending patches to switch to byte-based block
> status in the drivers.

Should be very easy to rebase for either of us. :)

Fam