From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
RDMA mailing list
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Bodong Wang <bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jack Morgenstein
<jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: [PATCH rdma-rc 4/4] RDMA/core: Fix avoid decoding iWarp port as RoCE
Date: Fri, 12 Jan 2018 07:58:42 +0200 [thread overview]
Message-ID: <20180112055842.23125-5-leon@kernel.org> (raw)
In-Reply-To: <20180112055842.23125-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
rdma_ah_find_type() incorrectly decodes iWARP port as RoCE type,
avoid such incorrect decoding.
Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Fixes: 44c58487d51a ("IB/core: Define 'ib' and 'roce' rdma_ah_attr types")
Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
---
include/rdma/ib_verbs.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 0d6a110dae7c..20ebf9061962 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -3793,8 +3793,7 @@ static inline void rdma_ah_set_grh(struct rdma_ah_attr *attr,
static inline enum rdma_ah_attr_type rdma_ah_find_type(struct ib_device *dev,
u32 port_num)
{
- if ((rdma_protocol_roce(dev, port_num)) ||
- (rdma_protocol_iwarp(dev, port_num)))
+ if (rdma_protocol_roce(dev, port_num))
return RDMA_AH_ATTR_TYPE_ROCE;
else if ((rdma_protocol_ib(dev, port_num)) &&
(rdma_cap_opa_ah(dev, port_num)))
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-12 5:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 5:58 [PATCH rdma-rc 0/4] RDMA mlx4/mlx5 fixes Leon Romanovsky
[not found] ` <20180112055842.23125-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-12 5:58 ` [PATCH rdma-rc 1/4] RDMA/mlx5: Fix out-of-bound access while querying AH Leon Romanovsky
[not found] ` <20180112055842.23125-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-15 21:30 ` Jason Gunthorpe
2018-01-12 5:58 ` [PATCH rdma-rc 2/4] IB/mlx4: Fix incorrectly releasing steerable UD QPs when have only ETH ports Leon Romanovsky
2018-01-12 5:58 ` [PATCH rdma-rc 3/4] IB/core: Fix ib_wc structure size to remain in 64 bytes boundary Leon Romanovsky
2018-01-12 5:58 ` Leon Romanovsky [this message]
2018-01-12 14:15 ` [PATCH rdma-rc 0/4] RDMA mlx4/mlx5 fixes Chien Tin Tung
[not found] ` <20180112141524.GA16256-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2018-01-12 15:06 ` Leon Romanovsky
[not found] ` <20180112150602.GN15760-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-12 15:34 ` Chien Tin Tung
[not found] ` <20180112153402.GA12452-TZeIlv3TuzOfrEmaQUPKxl95YUYmaKo1UNDiOz3kqAs@public.gmane.org>
2018-01-12 16:58 ` Jason Gunthorpe
[not found] ` <20180112165843.GC15974-uk2M96/98Pc@public.gmane.org>
2018-01-17 20:31 ` Doug Ledford
2018-01-12 17:02 ` Jason Gunthorpe
[not found] ` <20180112170228.GD15974-uk2M96/98Pc@public.gmane.org>
2018-01-12 18:39 ` Leon Romanovsky
[not found] ` <20180112183958.GP15760-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-13 19:18 ` Jason Gunthorpe
[not found] ` <20180113191806.GD32353-uk2M96/98Pc@public.gmane.org>
2018-01-13 20:11 ` Leon Romanovsky
[not found] ` <20180113201118.GQ15760-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-13 20:46 ` Jason Gunthorpe
[not found] ` <20180113204609.GE32353-uk2M96/98Pc@public.gmane.org>
2018-01-14 7:20 ` Leon Romanovsky
2018-01-22 22:51 ` Don Dutile
2018-01-14 17:15 ` jackm
[not found] ` <20180114191502.00001940-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2018-01-14 18:22 ` Jason Gunthorpe
[not found] ` <20180114182256.GA9088-uk2M96/98Pc@public.gmane.org>
2018-01-16 9:43 ` jackm
2018-01-15 23:06 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112055842.23125-5-leon@kernel.org \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bodong-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.