From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] Iputils not setting suid root?
Date: Fri, 12 Jan 2018 11:57:49 +0100 [thread overview]
Message-ID: <20180112115749.1fee6110@windsurf.lan> (raw)
In-Reply-To: <CABhNV23FhwkRdDwmNimoeKa++i3vQbErgVHg_8fUG_SWWi-Z=Q@mail.gmail.com>
Hello,
On Fri, 12 Jan 2018 11:54:40 +0100, Einar J?n wrote:
> > That's a bug. Could you submit a proper patch that fixes this ?
> >
>
> Attached one below, done against current master (84e835e)
> I hope that's the way you want it.
It is almost good :)
Things to adjust:
- We need your Signed-off-by at the end of the commit log.
- Please send the patch inline, using "git send-email". This makes
review easier, and allows our patchwork tracking tool
(http://patchwork.ozlabs.org/project/buildroot/list/) to properly
record the patch.
- You could slightly tweak the commit log, with something like: "The
ping and traceroute6 programs need to be SUID-root to work
correctly."
Could you fix those minor details and send an updated version?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-12 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 9:29 [Buildroot] Iputils not setting suid root? Einar Jón
2018-01-12 9:50 ` Thomas Petazzoni
2018-01-12 10:54 ` Einar Jón
2018-01-12 10:57 ` Thomas Petazzoni [this message]
2018-01-12 11:47 ` Einar Jón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112115749.1fee6110@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.