From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Christian Ludwig <chrissicool@googlemail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: Support separate Reply-To address
Date: Fri, 12 Jan 2018 13:39:43 +0100 [thread overview]
Message-ID: <20180112123943.21227-1-szeder.dev@gmail.com> (raw)
In-Reply-To: <20180112104751.28263-1-chrissicool@gmail.com>
> In some projects contributions from groups are only accepted from a
> common group email address. But every individual may want to recieve
> replies to her own personal address. That's what we have 'Reply-To'
> headers for in SMTP.
>
> Introduce an optional '--reply-to' command line option. Unfortunately
> the $reply_to variable name was already taken for the 'In-Reply-To'
> header field. To reduce code churn, use $reply_address as variable
> name instead.
That $reply_to variable is only accessed in 6 lines. I wouldn't
consider it that much of a code churn to rename it in a preparatory
patch.
> Signed-off-by: Christian Ludwig <chrissicool@gmail.com>
> ---
> Documentation/git-send-email.txt | 5 +++++
> git-send-email.perl | 18 +++++++++++++++++-
> t/t9001-send-email.sh | 2 ++
> 3 files changed, 24 insertions(+), 1 deletion(-)
Please add the new option to the completion script as well, to keep it
up to date.
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt
> index 8060ea35c..c3bc622b1 100644
> --- a/Documentation/git-send-email.txt
> +++ b/Documentation/git-send-email.txt
> @@ -84,6 +84,11 @@ See the CONFIGURATION section for `sendemail.multiEdit`.
> the value of GIT_AUTHOR_IDENT, or GIT_COMMITTER_IDENT if that is not
> set, as returned by "git var -l".
>
> +--reply-to=<address>::
> + Specify the address that replies from reciepients should
s/reciepients/recipients/
And I don't like that "that" and would prefer e.g. "where" instead,
but I'd rather leave this to the native English speakers.
> + to go. Use this if replies to messages should go to another
s/to go/go to/
prev parent reply other threads:[~2018-01-12 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 10:47 [PATCH] send-email: Support separate Reply-To address Christian Ludwig
2018-01-12 12:39 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112123943.21227-1-szeder.dev@gmail.com \
--to=szeder.dev@gmail.com \
--cc=chrissicool@googlemail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.