From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3] USB: serial: option: add id for Motorola Solutions TETRA PEI From: Johan Hovold Message-Id: <20180112171902.GC5992@localhost> Date: Fri, 12 Jan 2018 18:19:02 +0100 To: Max Schulze Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gRnJpLCBKYW4gMTIsIDIwMTggYXQgMTA6Mjk6NTRBTSArMDEwMCwgTWF4IFNjaHVsemUgd3Jv dGU6Cj4gQWRkIE1vdG9yb2xhIERldmljZSBJRCBhbmQgYmxhY2tsaXN0IGVudHJ5IHRvIHRoZSBk cml2ZXIgdXNiL3NlcmlhbC9vcHRpb24KPiAKPiBUaGUgZGV2aWNlIHJlc3BvbmRzIHdpdGggVVJC IHN0YXR1czogQnJva2VuIHBpcGUgKC1FUElQRSkgKC0zMikKPiB0byBVUkIgc2V0dXAgcmVxdWVz dHMgZm9yIHNldHRpbmcgZHRyL3J0cy4KClRoaXMgaW5kaWNhdGVzIHRoYXQgb3B0aW9uIGlzbid0 IHRoZSByaWdodCBkcml2ZXIgZm9yIHRoaXMgZm9yIGRldmljZS4KCkkgdGhpbmsgd2Ugc2hvdWxk IGFkZCBhIG5ldyBzaW1wbGUgZHJpdmVyIGZvciBpdCBpbnN0ZWFkLCB3aGljaCByZXBvcnRzCnRo YXQgbW9kZW0gY29udHJvbCBpc24ndCAoeWV0KSBzdXBwb3J0ZWQgKHllcywgeW91ciBweXRob24g c2NyaXB0IHdvdWxkCm5lZWQgdG8gYmUgdXBkYXRlZCkuIFRoaXMgY2FuIGJlIGV4dGVuZGVkIGlu dG8gYSAicmVhbCIgZHJpdmVyLCBzaG91bGQKd2UgbGVhcm4gbW9yZSBhYm91dCB0aGUgcHJvdG9j b2wgdXNlZC4KClBsZWFzZSBnaXZlIHRoZSBiZWxvdyBwYXRjaCBhIHRyeS4KCj4gU28gYmxhY2ts aXN0aW5nIHRvIGF2b2lkIHRoZSB1c2Jfd3dhbl9zZW5kX3NldHVwIGluIHVzYl93d2FuX2R0cl9y dHMgb2YgdXNiX3d3YW4uCj4gVGVzdGVkIG5vdyB0byB3b3JrIHdpdGggbWluaXRlcm0ucHkgYW5k IG1pbmljb20gd2l0aG91dCBlcnJvcnMuCj4gCj4gRDogIFZlcj0gMi4wMCBDbHM9MDAoPmlmYyAp IFN1Yj0wMCBQcm90PTAwIE14UFM9NjQgI0NmZ3M9ICAxCj4gUDogIFZlbmRvcj0wY2FkIFByb2RJ RD05MDExIFJldj0yNC4xNgo+IFM6ICBNYW51ZmFjdHVyZXI9TW90b3JvbGEgU29sdXRpb25zIElu Yy4KPiBTOiAgUHJvZHVjdD1Nb3Rvcm9sYSBTb2x1dGlvbnMgVEVUUkEgUEVJIGludGVyZmFjZQo+ IEM6ICAjSWZzPSAyIENmZyM9IDEgQXRyPTgwIE14UHdyPTUwMG1BCj4gSTogIElmIz0gMCBBbHQ9 IDAgI0VQcz0gMiBDbHM9ZmYodmVuZC4pIFN1Yj0wMCBQcm90PTAwIERyaXZlcj0obm9uZSkKPiBJ OiAgSWYjPSAxIEFsdD0gMCAjRVBzPSAyIENscz1mZih2ZW5kLikgU3ViPTAwIFByb3Q9MDAgRHJp dmVyPShub25lKQo+IAo+IAo+IFNpZ25lZC1vZmYtYnk6IE1heCBTY2h1bHplIDxtYXguc2NodWx6 ZUBwb3N0ZW8uZGU+CgpFdmVuIGlmIHRoaXMgaXMgYSB0cml2aWFsIHBhdGNoLCB5b3UgY2xlYXJs eSBiYXNlZCBpdCBvbiB0aGUgcGF0Y2ggSQpzZW50IHlvdSBhbmQgdGhpcyBpcyBzb21ldGhpbmcg dGhhdCBzaG91bGQgYXQgbGVhc3QgaGF2ZSBiZWVuIG1lbnRpb25lZAppbiB0aGUgY29tbWl0IG1l c3NhZ2UuIFNvbWV0aGluZyB0byBrZWVwIGluIG1pbmQgZm9yIGZ1dHVyZSBzdWJtaXNzaW9ucy4K ClRoYW5rcywKSm9oYW4KCgo+RnJvbSBhN2FiODdhY2Y4NWI2NzMwM2U3YmY2MDY3MzQxNzZhMzY1 YWFlOWNkIE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKb2hhbiBIb3ZvbGQgPGpvaGFu QGtlcm5lbC5vcmc+CkRhdGU6IEZyaSwgMTIgSmFuIDIwMTggMTc6NTM6MzUgKzAxMDAKU3ViamVj dDogW1BBVENIXSBVU0I6IHNlcmlhbDogc2ltcGxlOiBhZGQgTW90b3JvbGEgVGV0cmEgZHJpdmVy CgpBZGQgbmV3IE1vdG9yb2xhIFRldHJhIChzaW1wbGUpIGRyaXZlciBmb3IgTW90b3JvbGEgU29s dXRpb25zIFRFVFJBIFBFSQpkZXZpY2VzLgoKRDogIFZlcj0gMi4wMCBDbHM9MDAoPmlmYyApIFN1 Yj0wMCBQcm90PTAwIE14UFM9NjQgI0NmZ3M9ICAxClA6ICBWZW5kb3I9MGNhZCBQcm9kSUQ9OTAx MSBSZXY9MjQuMTYKUzogIE1hbnVmYWN0dXJlcj1Nb3Rvcm9sYSBTb2x1dGlvbnMgSW5jLgpTOiAg UHJvZHVjdD1Nb3Rvcm9sYSBTb2x1dGlvbnMgVEVUUkEgUEVJIGludGVyZmFjZQpDOiAgI0lmcz0g MiBDZmcjPSAxIEF0cj04MCBNeFB3cj01MDBtQQpJOiAgSWYjPSAwIEFsdD0gMCAjRVBzPSAyIENs cz1mZih2ZW5kLikgU3ViPTAwIFByb3Q9MDAgRHJpdmVyPShub25lKQpJOiAgSWYjPSAxIEFsdD0g MCAjRVBzPSAyIENscz1mZih2ZW5kLikgU3ViPTAwIFByb3Q9MDAgRHJpdmVyPShub25lKQoKTm90 ZSB0aGF0IHRoZXNlIGRldmljZXMgZG8gbm90IHN1cHBvcnQgdGhlIENEQyBTRVRfQ09OVFJPTF9M SU5FX1NUQVRFCnJlcXVlc3QgKGZvciBhbnkgaW50ZXJmYWNlKS4KClJlcG9ydGVkLWJ5OiBNYXgg U2NodWx6ZSA8bWF4LnNjaHVsemVAcG9zdGVvLmRlPgpDYzogc3RhYmxlIDxzdGFibGVAdmdlci5r ZXJuZWwub3JnPgpTaWduZWQtb2ZmLWJ5OiBKb2hhbiBIb3ZvbGQgPGpvaGFuQGtlcm5lbC5vcmc+ Ci0tLQogZHJpdmVycy91c2Ivc2VyaWFsL0tjb25maWcgICAgICAgICAgICAgfCAxICsKIGRyaXZl cnMvdXNiL3NlcmlhbC91c2Itc2VyaWFsLXNpbXBsZS5jIHwgNyArKysrKysrCiAyIGZpbGVzIGNo YW5nZWQsIDggaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3NlcmlhbC9L Y29uZmlnIGIvZHJpdmVycy91c2Ivc2VyaWFsL0tjb25maWcKaW5kZXggYThkNWYyZTQ4NzhkLi5j NjZiOTM2NjRkNTQgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL3NlcmlhbC9LY29uZmlnCisrKyBi L2RyaXZlcnMvdXNiL3NlcmlhbC9LY29uZmlnCkBAIC02Myw2ICs2Myw3IEBAIGNvbmZpZyBVU0Jf U0VSSUFMX1NJTVBMRQogCQktIEdvb2dsZSBVU0Igc2VyaWFsIGRldmljZXMKIAkJLSBIUDR4IGNh bGN1bGF0b3JzCiAJCS0gYSBudW1iZXIgb2YgTW90b3JvbGEgcGhvbmVzCisJCS0gTW90b3JvbGEg VGV0cmEgZGV2aWNlcwogCQktIE5vdmF0ZWwgV2lyZWxlc3MgR1BTIHJlY2VpdmVycwogCQktIFNp ZW1lbnMgVVNCL01QSSBhZGFwdGVyLgogCQktIFZpVk90ZWNoIFZpVk9wYXkgVVNCIGRldmljZS4K ZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL3NlcmlhbC91c2Itc2VyaWFsLXNpbXBsZS5jIGIvZHJp dmVycy91c2Ivc2VyaWFsL3VzYi1zZXJpYWwtc2ltcGxlLmMKaW5kZXggNzQxNzJmZTE1OGRmLi40 ZWY3OWUyOWNiMjYgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvdXNiL3NlcmlhbC91c2Itc2VyaWFsLXNp bXBsZS5jCisrKyBiL2RyaXZlcnMvdXNiL3NlcmlhbC91c2Itc2VyaWFsLXNpbXBsZS5jCkBAIC03 Nyw2ICs3NywxMSBAQCBERVZJQ0Uodml2b3BheSwgVklWT1BBWV9JRFMpOwogCXsgVVNCX0RFVklD RSgweDIyYjgsIDB4MmM2NCkgfQkvKiBNb3Rvcm9sYSBWOTUwIHBob25lICovCiBERVZJQ0UobW90 b19tb2RlbSwgTU9UT19JRFMpOwogCisvKiBNb3Rvcm9sYSBUZXRyYSBkcml2ZXIgKi8KKyNkZWZp bmUgTU9UT1JPTEFfVEVUUkFfSURTKCkJCQlcCisJeyBVU0JfREVWSUNFKDB4MGNhZCwgMHg5MDEx KSB9CS8qIE1vdG9yb2xhIFNvbHV0aW9ucyBURVRSQSBQRUkgKi8KK0RFVklDRShtb3Rvcm9sYV90 ZXRyYSwgTU9UT1JPTEFfVEVUUkFfSURTKTsKKwogLyogTm92YXRlbCBXaXJlbGVzcyBHUFMgZHJp dmVyICovCiAjZGVmaW5lIE5PVkFURUxfSURTKCkJCQlcCiAJeyBVU0JfREVWSUNFKDB4MDlkNywg MHgwMTAwKSB9CS8qIE5vdkF0ZWwgRmxleFBhY2sgR1BTICovCkBAIC0xMDcsNiArMTEyLDcgQEAg c3RhdGljIHN0cnVjdCB1c2Jfc2VyaWFsX2RyaXZlciAqIGNvbnN0IHNlcmlhbF9kcml2ZXJzW10g PSB7CiAJJmdvb2dsZV9kZXZpY2UsCiAJJnZpdm9wYXlfZGV2aWNlLAogCSZtb3RvX21vZGVtX2Rl dmljZSwKKwkmbW90b3JvbGFfdGV0cmFfZGV2aWNlLAogCSZub3ZhdGVsX2dwc19kZXZpY2UsCiAJ JmhwNHhfZGV2aWNlLAogCSZzdXVudG9fZGV2aWNlLApAQCAtMTIyLDYgKzEyOCw3IEBAIHN0YXRp YyBjb25zdCBzdHJ1Y3QgdXNiX2RldmljZV9pZCBpZF90YWJsZVtdID0gewogCUdPT0dMRV9JRFMo KSwKIAlWSVZPUEFZX0lEUygpLAogCU1PVE9fSURTKCksCisJTU9UT1JPTEFfVEVUUkFfSURTKCks CiAJTk9WQVRFTF9JRFMoKSwKIAlIUDRYX0lEUygpLAogCVNVVU5UT19JRFMoKSwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964953AbeALRTI (ORCPT + 1 other); Fri, 12 Jan 2018 12:19:08 -0500 Received: from mail-lf0-f68.google.com ([209.85.215.68]:45798 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964842AbeALRTF (ORCPT ); Fri, 12 Jan 2018 12:19:05 -0500 X-Google-Smtp-Source: ACJfBouSyOOsgo9oYdSCUWyZuWjPHyoXUeLbpNG+HAN3tFfMZIKodVZ1sF6YSjmccZfAqpXSeMr3UA== Date: Fri, 12 Jan 2018 18:19:02 +0100 From: Johan Hovold To: Max Schulze Cc: johan@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] USB: serial: option: add id for Motorola Solutions TETRA PEI Message-ID: <20180112171902.GC5992@localhost> References: <20180112092954.9161-1-max.schulze@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180112092954.9161-1-max.schulze@posteo.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Fri, Jan 12, 2018 at 10:29:54AM +0100, Max Schulze wrote: > Add Motorola Device ID and blacklist entry to the driver usb/serial/option > > The device responds with URB status: Broken pipe (-EPIPE) (-32) > to URB setup requests for setting dtr/rts. This indicates that option isn't the right driver for this for device. I think we should add a new simple driver for it instead, which reports that modem control isn't (yet) supported (yes, your python script would need to be updated). This can be extended into a "real" driver, should we learn more about the protocol used. Please give the below patch a try. > So blacklisting to avoid the usb_wwan_send_setup in usb_wwan_dtr_rts of usb_wwan. > Tested now to work with miniterm.py and minicom without errors. > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > P: Vendor=0cad ProdID=9011 Rev=24.16 > S: Manufacturer=Motorola Solutions Inc. > S: Product=Motorola Solutions TETRA PEI interface > C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA > I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > > > Signed-off-by: Max Schulze Even if this is a trivial patch, you clearly based it on the patch I sent you and this is something that should at least have been mentioned in the commit message. Something to keep in mind for future submissions. Thanks, Johan >>From a7ab87acf85b67303e7bf606734176a365aae9cd Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Fri, 12 Jan 2018 17:53:35 +0100 Subject: [PATCH] USB: serial: simple: add Motorola Tetra driver Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI devices. D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=0cad ProdID=9011 Rev=24.16 S: Manufacturer=Motorola Solutions Inc. S: Product=Motorola Solutions TETRA PEI interface C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) Note that these devices do not support the CDC SET_CONTROL_LINE_STATE request (for any interface). Reported-by: Max Schulze Cc: stable Signed-off-by: Johan Hovold --- drivers/usb/serial/Kconfig | 1 + drivers/usb/serial/usb-serial-simple.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig index a8d5f2e4878d..c66b93664d54 100644 --- a/drivers/usb/serial/Kconfig +++ b/drivers/usb/serial/Kconfig @@ -63,6 +63,7 @@ config USB_SERIAL_SIMPLE - Google USB serial devices - HP4x calculators - a number of Motorola phones + - Motorola Tetra devices - Novatel Wireless GPS receivers - Siemens USB/MPI adapter. - ViVOtech ViVOpay USB device. diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c index 74172fe158df..4ef79e29cb26 100644 --- a/drivers/usb/serial/usb-serial-simple.c +++ b/drivers/usb/serial/usb-serial-simple.c @@ -77,6 +77,11 @@ DEVICE(vivopay, VIVOPAY_IDS); { USB_DEVICE(0x22b8, 0x2c64) } /* Motorola V950 phone */ DEVICE(moto_modem, MOTO_IDS); +/* Motorola Tetra driver */ +#define MOTOROLA_TETRA_IDS() \ + { USB_DEVICE(0x0cad, 0x9011) } /* Motorola Solutions TETRA PEI */ +DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS); + /* Novatel Wireless GPS driver */ #define NOVATEL_IDS() \ { USB_DEVICE(0x09d7, 0x0100) } /* NovAtel FlexPack GPS */ @@ -107,6 +112,7 @@ static struct usb_serial_driver * const serial_drivers[] = { &google_device, &vivopay_device, &moto_modem_device, + &motorola_tetra_device, &novatel_gps_device, &hp4x_device, &suunto_device, @@ -122,6 +128,7 @@ static const struct usb_device_id id_table[] = { GOOGLE_IDS(), VIVOPAY_IDS(), MOTO_IDS(), + MOTOROLA_TETRA_IDS(), NOVATEL_IDS(), HP4X_IDS(), SUUNTO_IDS(), -- 2.15.1