From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups <cgroups@vger.kernel.org>,
Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>,
Arnd Bergmann <arnd@arndb.de>,
Chris Metcalf <cmetcalf@ezchip.com>
Subject: Re: [PATCH] string: drop __must_check from strscpy() and restore strscpy() usages in cgroup
Date: Fri, 12 Jan 2018 11:38:18 -0800 [thread overview]
Message-ID: <20180112193818.GM3460072@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180109152115.GH3668920@devbig577.frc2.facebook.com>
Hello, Linus.
On Tue, Jan 09, 2018 at 07:21:15AM -0800, Tejun Heo wrote:
> From ceb2d2b2e496f180be95adb670337bb254f89323 Mon Sep 17 00:00:00 2001
> From: Tejun Heo <tj@kernel.org>
> Date: Tue, 9 Jan 2018 07:00:29 -0800
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
>
> e7fd37ba1217 ("cgroup: avoid copying strings longer than the buffers")
> converted possibly unsafe strncpy() usages in cgroup to strscpy().
> However, although the callsites are completely fine with truncated
> copied, because strscpy() is marked __must_check, it led to the
> following warnings.
Do you want to pick up this patch? If not, I can route it through
cgroup tree.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-01-12 19:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 14:52 [GIT PULL] cgroup fixes for v4.15-rc7 Tejun Heo
[not found] ` <20180108145223.GS3668920-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2018-01-08 19:20 ` Linus Torvalds
2018-01-08 19:20 ` Linus Torvalds
2018-01-08 19:23 ` Linus Torvalds
[not found] ` <CA+55aFxSbAJe9gnL7jXHUO8KzY8TbrvSt7+jWsTZTJt7EMMzuw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-08 19:28 ` Tejun Heo
2018-01-08 19:28 ` Tejun Heo
2018-01-08 19:41 ` Linus Torvalds
[not found] ` <CA+55aFyQu8wTOJ8HdUjRA2NnLLdXRPvPyEyaws=5VULVJrDSxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-09 15:21 ` [PATCH] string: drop __must_check from strscpy() and restore strscpy() usages in cgroup Tejun Heo
2018-01-09 15:21 ` Tejun Heo
2018-01-12 19:38 ` Tejun Heo [this message]
[not found] ` <20180109152115.GH3668920-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2018-01-19 16:50 ` Tejun Heo
2018-01-19 16:50 ` Tejun Heo
[not found] ` <20180119165044.GA3460072-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2018-01-19 17:27 ` Linus Torvalds
2018-01-19 17:27 ` Linus Torvalds
2018-01-19 17:31 ` Tejun Heo
[not found] ` <20180119173141.GF3460072-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2018-01-19 17:35 ` Linus Torvalds
2018-01-19 17:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112193818.GM3460072@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=cgroups@vger.kernel.org \
--cc=cmetcalf@ezchip.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mashimiao.fnst@cn.fujitsu.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.