From: Lepton Wu <ytht.net@gmail.com>
To: stable@vger.kernel.org
Cc: gregkh@linuxfoundation.org, groeck@chromium.org,
hshan@google.com, Lepton Wu <ytht.net@gmail.com>
Subject: [PATCH 4.4-stable v4] kaiser: Set _PAGE_NX only if supported
Date: Fri, 12 Jan 2018 13:42:56 -0800 [thread overview]
Message-ID: <20180112214256.257463-1-ytht.net@gmail.com> (raw)
In-Reply-To: <20180112213150.250374-1-ytht.net@gmail.com>
This finally resolve crash if loaded under qemu + haxm. Haitao Shan pointed
out that the reason of that crash is that NX bit get set for page tables.
It seems we missed checking if _PAGE_NX is supported in kaiser_add_user_map
Link: https://www.spinics.net/lists/kernel/msg2689835.html
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Lepton Wu <ytht.net@gmail.com>
---
arch/x86/mm/kaiser.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/mm/kaiser.c b/arch/x86/mm/kaiser.c
index 6a7a77929a8c..8af98513d36c 100644
--- a/arch/x86/mm/kaiser.c
+++ b/arch/x86/mm/kaiser.c
@@ -198,6 +198,8 @@ static int kaiser_add_user_map(const void *__start_addr, unsigned long size,
* requires that not to be #defined to 0): so mask it off here.
*/
flags &= ~_PAGE_GLOBAL;
+ if (!(__supported_pte_mask & _PAGE_NX))
+ flags &= ~_PAGE_NX;
for (; address < end_addr; address += PAGE_SIZE) {
target_address = get_pa_from_mapping(address);
--
2.16.0.rc1.238.g530d649a79-goog
next prev parent reply other threads:[~2018-01-12 21:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 21:31 [PATCH 4.4-stable] kaiser: Set _PAGE_NX only if supported Lepton Wu
2018-01-12 21:38 ` [PATCH 4.4-stable v2] " Lepton Wu
2018-01-12 21:39 ` [PATCH 4.4-stable] " Guenter Roeck
2018-01-12 21:41 ` [PATCH 4.4-stable v3] " Lepton Wu
2018-01-12 21:46 ` Guenter Roeck
2018-01-12 21:48 ` lepton
2018-01-12 23:05 ` lepton
2018-01-13 14:51 ` Greg Kroah-Hartman
2018-01-13 18:47 ` lepton
2018-01-13 19:10 ` Greg Kroah-Hartman
2018-01-16 14:18 ` [PATCH 3.2-stable 1/2] " Juerg Haefliger
2018-01-16 14:18 ` [PATCH 3.2-stable 2/2] " Juerg Haefliger
2018-01-16 14:19 ` [PATCH 3.16-stable 1/2] " Juerg Haefliger
2018-02-05 19:26 ` Ben Hutchings
2018-01-16 14:19 ` [PATCH 3.16-stable 2/2] " Juerg Haefliger
2018-01-12 21:42 ` Lepton Wu [this message]
2018-01-13 14:53 ` Patch "kaiser: Set _PAGE_NX only if supported" has been added to the 4.4-stable tree gregkh
2018-01-13 14:53 ` Patch "kaiser: Set _PAGE_NX only if supported" has been added to the 4.9-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112214256.257463-1-ytht.net@gmail.com \
--to=ytht.net@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=hshan@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.