From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, rsanford@akamai.com
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/1] timer: fix reset on service cores
Date: Sat, 13 Jan 2018 10:36:33 +0530 [thread overview]
Message-ID: <20180113050632.cexa2hlfnscoq2im@Pavan-LT> (raw)
In-Reply-To: <1515792665-6890-1-git-send-email-erik.g.carrillo@intel.com>
On Fri, Jan 12, 2018 at 03:31:05PM -0600, Erik Gabriel Carrillo wrote:
> The return value of rte_lcore_has_role is misinterpreted in the timer
> reset function. The return values of rte_lcore_has_role will be changed
> in a future DPDK release, but this commit fixes this call site until
> that happens.
>
> Fixes: 351f463456f8 ("timer: allow reset on service cores")
> Cc: stable@dpdk.org
>
> Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> ---
> lib/librte_timer/rte_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
> index 604ecab..4bbcd06 100644
> --- a/lib/librte_timer/rte_timer.c
> +++ b/lib/librte_timer/rte_timer.c
> @@ -403,7 +403,7 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
>
> if (unlikely((tim_lcore != (unsigned)LCORE_ID_ANY) &&
> !(rte_lcore_is_enabled(tim_lcore) ||
> - rte_lcore_has_role(tim_lcore, ROLE_SERVICE))))
> + rte_lcore_has_role(tim_lcore, ROLE_SERVICE) == 0)))
> return -1;
>
> if (type == PERIODICAL)
> --
> 2.6.4
>
Acked-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
next prev parent reply other threads:[~2018-01-13 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 21:31 [PATCH 1/1] timer: fix reset on service cores Erik Gabriel Carrillo
2018-01-13 5:06 ` Pavan Nikhilesh [this message]
2018-01-16 0:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180113050632.cexa2hlfnscoq2im@Pavan-LT \
--to=pbhagavatula@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=rsanford@akamai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.