diff for duplicates of <20180114120716.320526c1@archlinux> diff --git a/a/1.txt b/N1/1.txt index f5c0d6a..1fd372d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,8 +15,8 @@ Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: > >> Fixes: bed73904e76f ("IIO: ADC: add stm32 DFSDM core support") > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> --- -> >> drivers/iio/adc/stm32-dfsdm-core.c | 3 +-- -> >> 1 file changed, 1 insertion(+), 2 deletions(-) +> >> ? drivers/iio/adc/stm32-dfsdm-core.c | 3 +-- +> >> ? 1 file changed, 1 insertion(+), 2 deletions(-) > >> > >> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c > >> b/drivers/iio/adc/stm32-dfsdm-core.c @@ -24,21 +24,21 @@ Arnaud Pouliquen <arnaud.pouliquen@st.com> wrote: > >> --- a/drivers/iio/adc/stm32-dfsdm-core.c > >> +++ b/drivers/iio/adc/stm32-dfsdm-core.c > >> @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match); -> >> static int stm32_dfsdm_probe(struct platform_device *pdev) -> >> { -> >> struct dfsdm_priv *priv; -> >> - struct device_node *pnode = pdev->dev.of_node; -> >> const struct of_device_id *of_id; -> >> const struct stm32_dfsdm_dev_data *dev_data; -> >> struct stm32_dfsdm *dfsdm; +> >> ? static int stm32_dfsdm_probe(struct platform_device *pdev) +> >> ? { +> >> ????? struct dfsdm_priv *priv; +> >> -??? struct device_node *pnode = pdev->dev.of_node; +> >> ????? const struct of_device_id *of_id; +> >> ????? const struct stm32_dfsdm_dev_data *dev_data; +> >> ????? struct stm32_dfsdm *dfsdm; > >> @@ -254,7 +253,7 @@ static int stm32_dfsdm_probe(struct > >> platform_device *pdev) -> >> priv->pdev = pdev; -> >> - of_id = of_match_node(stm32_dfsdm_of_match, pnode); -> >> + of_id = of_match_node(stm32_dfsdm_of_match, pdev->dev.of_node); -> >> if (!of_id->data) { -> >> dev_err(&pdev->dev, "Data associated to device is missing\n"); -> >> return -EINVAL; +> >> ? ????? priv->pdev = pdev; +> >> ? -??? of_id = of_match_node(stm32_dfsdm_of_match, pnode); +> >> +??? of_id = of_match_node(stm32_dfsdm_of_match, pdev->dev.of_node); +> >> ????? if (!of_id->data) { +> >> ????????? dev_err(&pdev->dev, "Data associated to device is missing\n"); +> >> ????????? return -EINVAL; > > > > FWIW, it looks like this whole lot could be cleaned up by using > > of_device_get_match_data(). diff --git a/a/content_digest b/N1/content_digest index b15c9ef..fb91939 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,21 +1,10 @@ "ref\020180111103510.1408292-1-arnd@arndb.de\0" "ref\0866335ff-d9a8-99c0-0946-82b3f207f266@arm.com\0" "ref\0838ace12-2722-33aa-0ed8-2e8e7494b2ae@st.com\0" - "From\0Jonathan Cameron <jic23@kernel.org>\0" - "Subject\0Re: [PATCH] IIO: ADC: stm32-dfsdm: avoid unused-variable warning\0" + "From\0jic23@kernel.org (Jonathan Cameron)\0" + "Subject\0[PATCH] IIO: ADC: stm32-dfsdm: avoid unused-variable warning\0" "Date\0Sun, 14 Jan 2018 12:07:16 +0000\0" - "To\0Arnaud Pouliquen <arnaud.pouliquen@st.com>\0" - "Cc\0Robin Murphy <robin.murphy@arm.com>" - Arnd Bergmann <arnd@arndb.de> - Mark Brown <broonie@kernel.org> - Lars-Peter Clausen <lars@metafoo.de> - Peter Meerwald-Stadler <pmeerw@pmeerw.net> - <linux-iio@vger.kernel.org> - <linux-kernel@vger.kernel.org> - <linux-arm-kernel@lists.infradead.org> - Maxime Coquelin <mcoquelin.stm32@gmail.com> - Hartmut Knaack <knaack.h@gmx.de> - " Alexandre Torgue <alexandre.torgue@st.com>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, 11 Jan 2018 18:38:49 +0100\n" @@ -35,8 +24,8 @@ "> >> Fixes: bed73904e76f (\"IIO: ADC: add stm32 DFSDM core support\")\n" "> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>\n" "> >> ---\n" - "> >> \302\240 drivers/iio/adc/stm32-dfsdm-core.c | 3 +--\n" - "> >> \302\240 1 file changed, 1 insertion(+), 2 deletions(-)\n" + "> >> ? drivers/iio/adc/stm32-dfsdm-core.c | 3 +--\n" + "> >> ? 1 file changed, 1 insertion(+), 2 deletions(-)\n" "> >>\n" "> >> diff --git a/drivers/iio/adc/stm32-dfsdm-core.c\n" "> >> b/drivers/iio/adc/stm32-dfsdm-core.c\n" @@ -44,21 +33,21 @@ "> >> --- a/drivers/iio/adc/stm32-dfsdm-core.c\n" "> >> +++ b/drivers/iio/adc/stm32-dfsdm-core.c\n" "> >> @@ -242,7 +242,6 @@ MODULE_DEVICE_TABLE(of, stm32_dfsdm_of_match);\n" - "> >> \302\240 static int stm32_dfsdm_probe(struct platform_device *pdev)\n" - "> >> \302\240 {\n" - "> >> \302\240\302\240\302\240\302\240\302\240 struct dfsdm_priv *priv;\n" - "> >> -\302\240\302\240\302\240 struct device_node *pnode = pdev->dev.of_node;\n" - "> >> \302\240\302\240\302\240\302\240\302\240 const struct of_device_id *of_id;\n" - "> >> \302\240\302\240\302\240\302\240\302\240 const struct stm32_dfsdm_dev_data *dev_data;\n" - "> >> \302\240\302\240\302\240\302\240\302\240 struct stm32_dfsdm *dfsdm;\n" + "> >> ? static int stm32_dfsdm_probe(struct platform_device *pdev)\n" + "> >> ? {\n" + "> >> ????? struct dfsdm_priv *priv;\n" + "> >> -??? struct device_node *pnode = pdev->dev.of_node;\n" + "> >> ????? const struct of_device_id *of_id;\n" + "> >> ????? const struct stm32_dfsdm_dev_data *dev_data;\n" + "> >> ????? struct stm32_dfsdm *dfsdm;\n" "> >> @@ -254,7 +253,7 @@ static int stm32_dfsdm_probe(struct\n" "> >> platform_device *pdev)\n" - "> >> \302\240 \302\240\302\240\302\240\302\240\302\240 priv->pdev = pdev;\n" - "> >> \302\240 -\302\240\302\240\302\240 of_id = of_match_node(stm32_dfsdm_of_match, pnode);\n" - "> >> +\302\240\302\240\302\240 of_id = of_match_node(stm32_dfsdm_of_match, pdev->dev.of_node);\n" - "> >> \302\240\302\240\302\240\302\240\302\240 if (!of_id->data) {\n" - "> >> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 dev_err(&pdev->dev, \"Data associated to device is missing\\n\");\n" - "> >> \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 return -EINVAL; \n" + "> >> ? ????? priv->pdev = pdev;\n" + "> >> ? -??? of_id = of_match_node(stm32_dfsdm_of_match, pnode);\n" + "> >> +??? of_id = of_match_node(stm32_dfsdm_of_match, pdev->dev.of_node);\n" + "> >> ????? if (!of_id->data) {\n" + "> >> ????????? dev_err(&pdev->dev, \"Data associated to device is missing\\n\");\n" + "> >> ????????? return -EINVAL; \n" "> > \n" "> > FWIW, it looks like this whole lot could be cleaned up by using\n" "> > of_device_get_match_data().\n" @@ -141,4 +130,4 @@ "> \tdfsdm->fl_list = devm_kcalloc(&pdev->dev, dev_data->num_filters,\n" "> \t\t\t\t sizeof(*dfsdm->fl_list), GFP_KERNEL);" -0737e8aca1c50e6c1a5cd785a5b7a38c095ef3bccb274b08698a4e517004b67d +4ebf42086ed6ee22544273643a9e99c23a24977b3075ffa4ca2c5cbb16bf0369
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.