From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 4/6] x86/boot: Assume MMIO if serial base address supplied via earlyprintk
Date: Sun, 14 Jan 2018 16:32:52 +0200 [thread overview]
Message-ID: <20180114143254.15429-4-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20180114143254.15429-1-andriy.shevchenko@linux.intel.com>
If user supplied serial base address via kernel command line and value
is higher than IO space limit (64k boundary), assume for now that MMIO
byte access is required.
Later we might expand or modify this if needed.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/boot/early_serial_console.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 8b091919b3b9..8cb7b0e8fe98 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -33,6 +33,22 @@ static void io_serial_out(unsigned long addr, int offset, int value)
outb(value, addr + offset);
}
+#define IO_SPACE_LIMIT 0xffff
+
+static void mem8_serial_out(unsigned long addr, int offset, int value)
+{
+ u8 __iomem *vaddr = (u8 __iomem *)addr;
+ /* shift implied by pointer type */
+ writeb(value, vaddr + offset);
+}
+
+static unsigned int mem8_serial_in(unsigned long addr, int offset)
+{
+ u8 __iomem *vaddr = (u8 __iomem *)addr;
+ /* shift implied by pointer type */
+ return readb(vaddr + offset);
+}
+
static void early_serial_configure(unsigned long port, int baud)
{
unsigned char c;
@@ -54,7 +70,11 @@ static void early_serial_configure(unsigned long port, int baud)
static void early_serial_init(unsigned long port, int baud)
{
/* Assign serial I/O accessors */
- if (port) {
+ if (port > IO_SPACE_LIMIT) {
+ /* It is memory mapped - assume 8-bit alignment */
+ serial_in = mem8_serial_in;
+ serial_out = mem8_serial_out;
+ } else if (port) {
/* These will always be IO based ports */
serial_in = io_serial_in;
serial_out = io_serial_out;
--
2.15.1
next prev parent reply other threads:[~2018-01-14 14:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 14:32 [PATCH v1 1/6] x86/boot: Convert early_serial_base to unsigned long Andy Shevchenko
2018-01-14 14:32 ` [PATCH v1 2/6] x86/boot: Introduce helpers for serial I/O Andy Shevchenko
2018-01-14 14:32 ` [PATCH v1 3/6] x86/boot: Add MMIO byte accessors Andy Shevchenko
2018-01-14 14:32 ` Andy Shevchenko [this message]
2018-01-16 3:13 ` [PATCH v1 4/6] x86/boot: Assume MMIO if serial base address supplied via earlyprintk Ingo Molnar
2018-01-16 10:55 ` Andy Shevchenko
2018-01-16 15:55 ` Ingo Molnar
2018-05-03 10:45 ` Andy Shevchenko
2018-01-14 14:32 ` [PATCH v1 5/6] x86/boot: Allow longer parameter list for earlyprintk Andy Shevchenko
2018-01-16 3:11 ` Ingo Molnar
2018-01-16 10:57 ` Andy Shevchenko
2018-01-16 15:51 ` Ingo Molnar
2018-05-03 11:48 ` Andy Shevchenko
2018-01-14 14:32 ` [PATCH v1 6/6] x86/boot: Support nocfg parameter " Andy Shevchenko
2018-01-16 3:12 ` Ingo Molnar
2018-01-16 11:00 ` Andy Shevchenko
2018-01-16 15:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114143254.15429-4-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.