From: Peter Chen <hzpeterchen@gmail.com>
To: Michael Trimarchi <michael@amarulasolutions.com>
Cc: Peter Chen <Peter.Chen@nxp.com>,
linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [RFC,3/3] usb: chipidea: usbmisc: small clean up
Date: Mon, 15 Jan 2018 11:08:01 +0800 [thread overview]
Message-ID: <20180115030801.GC5968@b29397-desktop> (raw)
On Sat, Jan 13, 2018 at 04:41:48PM +0100, Michael Trimarchi wrote:
> The register write can be done outside the if and else condition
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> drivers/usb/chipidea/usbmisc_imx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/chipidea/usbmisc_imx.c b/drivers/usb/chipidea/usbmisc_imx.c
> index 1f47ef6..34ad5bf 100644
> --- a/drivers/usb/chipidea/usbmisc_imx.c
> +++ b/drivers/usb/chipidea/usbmisc_imx.c
> @@ -315,13 +315,12 @@ static int usbmisc_imx6q_set_wakeup
> val = readl(usbmisc->base + data->index * 4);
> if (enabled) {
> val |= wakeup_setting;
> - writel(val, usbmisc->base + data->index * 4);
> } else {
> if (val & MX6_BM_WAKEUP_INTR)
> pr_debug("wakeup int at ci_hdrc.%d\n", data->index);
> val &= ~wakeup_setting;
> - writel(val, usbmisc->base + data->index * 4);
> }
> + writel(val, usbmisc->base + data->index * 4);
> spin_unlock_irqrestore(&usbmisc->lock, flags);
>
> return ret;
Acked-by: Peter Chen <peter.chen@nxp.com>
next reply other threads:[~2018-01-15 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 3:08 Peter Chen [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-01-13 15:41 [RFC,3/3] usb: chipidea: usbmisc: small clean up Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115030801.GC5968@b29397-desktop \
--to=hzpeterchen@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.