From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [Nouveau] [PATCH] fix drm-get-put.cocci warnings Date: Mon, 15 Jan 2018 14:51:02 +0100 Message-ID: <20180115135102.GA5519@ulmo> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0711309910==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Julia Lawall Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kbuild-all@01.org, Thierry Reding , Ben Skeggs List-Id: nouveau.vger.kernel.org --===============0711309910== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > From: Fengguang Wu >=20 > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. >=20 > Generated by: scripts/coccinelle/api/drm-get-put.cocci >=20 > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- >=20 > tree: https://github.com/thierryreding/linux for-4.16/work > head: 6c86494bb2f670293f6137b0a4b3c53c8886eba4 > commit: 34f022b2d11f91a323d3e7d15893d480646f3fad [149/161] WIP >=20 > nouveau_gem.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Hi Julia, thanks for the patch. However, the tree that you generated it against is a personal development tree and it happens to have a bunch of commits in it that are very experimental and some of which are very unlikely to go upstream. There's an IOCTL addition patch (touched by hunk 7 in this patch) that is used only for testing purposes. All of the other hunks do pply properly to linux-next, so I think those can be posted. Nouveau is maintained by Ben Skeggs, though, so they should be addressed to him. I don't personally mind getting these patches, and I don't mind people seeing the personal development tree (it's publicly available, after all) but I think patches against this tree will be confusing to anyone but me because they are likely not going to apply anywhere other than that tree. Thanks, Thierry --17pEHd4RhPHOinZp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlpcscMACgkQ3SOs138+ s6GIhg//W/vHD5LA/xn7wz0BkmIyH3OaxRLJ3Kj2a/dhUR7DEPG8UN5bCsfA8xEE m9vTFpRBxKgia6jw7hn2kua4QOmNJW9qwktlQT2/fbKvxcrASRh4LrjunPzHaojx z0BXpfCtizQqHo7mhPtqK4fGrm27mxMQwsN+ySfcFqJfyiBJb1UEoUn0DE4pL+iE h/fMPr7Vk+Yas7PR1MnlX93qjBbCDwqDWCnuAAzBobz2c0EKbOlssuuV1e9my4yT ZY29eIFt09wW21F8ZAOP3s9aUX8orYm0cwgeC+PIrys1Dx5Vv9QnDsDyBgjBLU2v gRw0WxsEAu816gTdjDhlO24lM6ob6Dl6rSBQYDe+jKBN/rVJ6QpthatiVJaGp5OD vbtgekVj4tTbq9jPnRDh6ln4ZIWKa5AhZlcI7npbp0pPYbR+U6AHCI5RBBnMmS1f LgAqmGVEvgcbxo/IR3fdpvVqAgu76/qHuAWSfVyCJrjJ1nGhh7HS0ZCOacD9x/yS B/wVwgT5JWqxBxb1DWRykM+M+2tlJP1HAEs7zyfCt3eRYDp62c1mFiJIwViPOx28 7xPYI322v9uR5iP895tDxLqUWLL6rEu4Dbi2TI5rudkVxaaXvlCJaOdtfpvQUnm/ xUaJYf/y9T3sGiRweJGZcZAl6RxwHc9YJFKtFaOKHU+bFhPo5Kg= =V8es -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp-- --===============0711309910== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0711309910==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966422AbeAONvM (ORCPT + 1 other); Mon, 15 Jan 2018 08:51:12 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:38153 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934589AbeAONvG (ORCPT ); Mon, 15 Jan 2018 08:51:06 -0500 X-Google-Smtp-Source: ACJfBotmlcFiTXRUhqwbxbVWVVsKV5lwhQeSMBbNFadmf6o86kxELHpOeNAV8yEgDWWuW3siUxrJmQ== Date: Mon, 15 Jan 2018 14:51:02 +0100 From: Thierry Reding To: Julia Lawall Cc: Thierry Reding , David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kbuild-all@01.org, Ben Skeggs Subject: Re: [Nouveau] [PATCH] fix drm-get-put.cocci warnings Message-ID: <20180115135102.GA5519@ulmo> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="17pEHd4RhPHOinZp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: --17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > From: Fengguang Wu >=20 > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. >=20 > Generated by: scripts/coccinelle/api/drm-get-put.cocci >=20 > Signed-off-by: Fengguang Wu > Signed-off-by: Julia Lawall > --- >=20 > tree: https://github.com/thierryreding/linux for-4.16/work > head: 6c86494bb2f670293f6137b0a4b3c53c8886eba4 > commit: 34f022b2d11f91a323d3e7d15893d480646f3fad [149/161] WIP >=20 > nouveau_gem.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) Hi Julia, thanks for the patch. However, the tree that you generated it against is a personal development tree and it happens to have a bunch of commits in it that are very experimental and some of which are very unlikely to go upstream. There's an IOCTL addition patch (touched by hunk 7 in this patch) that is used only for testing purposes. All of the other hunks do pply properly to linux-next, so I think those can be posted. Nouveau is maintained by Ben Skeggs, though, so they should be addressed to him. I don't personally mind getting these patches, and I don't mind people seeing the personal development tree (it's publicly available, after all) but I think patches against this tree will be confusing to anyone but me because they are likely not going to apply anywhere other than that tree. Thanks, Thierry --17pEHd4RhPHOinZp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlpcscMACgkQ3SOs138+ s6GIhg//W/vHD5LA/xn7wz0BkmIyH3OaxRLJ3Kj2a/dhUR7DEPG8UN5bCsfA8xEE m9vTFpRBxKgia6jw7hn2kua4QOmNJW9qwktlQT2/fbKvxcrASRh4LrjunPzHaojx z0BXpfCtizQqHo7mhPtqK4fGrm27mxMQwsN+ySfcFqJfyiBJb1UEoUn0DE4pL+iE h/fMPr7Vk+Yas7PR1MnlX93qjBbCDwqDWCnuAAzBobz2c0EKbOlssuuV1e9my4yT ZY29eIFt09wW21F8ZAOP3s9aUX8orYm0cwgeC+PIrys1Dx5Vv9QnDsDyBgjBLU2v gRw0WxsEAu816gTdjDhlO24lM6ob6Dl6rSBQYDe+jKBN/rVJ6QpthatiVJaGp5OD vbtgekVj4tTbq9jPnRDh6ln4ZIWKa5AhZlcI7npbp0pPYbR+U6AHCI5RBBnMmS1f LgAqmGVEvgcbxo/IR3fdpvVqAgu76/qHuAWSfVyCJrjJ1nGhh7HS0ZCOacD9x/yS B/wVwgT5JWqxBxb1DWRykM+M+2tlJP1HAEs7zyfCt3eRYDp62c1mFiJIwViPOx28 7xPYI322v9uR5iP895tDxLqUWLL6rEu4Dbi2TI5rudkVxaaXvlCJaOdtfpvQUnm/ xUaJYf/y9T3sGiRweJGZcZAl6RxwHc9YJFKtFaOKHU+bFhPo5Kg= =V8es -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--