From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] kconfig: Apply upstream nconfig ncurses/ncursesw fix
Date: Mon, 15 Jan 2018 21:37:06 +0100 [thread overview]
Message-ID: <20180115213706.61ee21b5@windsurf> (raw)
In-Reply-To: <20180114172807.28196-1-g@maral.me>
Hello,
On Sun, 14 Jan 2018 09:28:07 -0800, Guillermo A. Amaral wrote:
> Buildroot's "make nconfig" command stopped working a while ago on all my
> Gentoo systems. Running the command would result in a crash.
>
> I found that the issue was caused by lxdialog's cflags which are also
> used to build nconfig; It would detect *ncursesw* and turn on WIDECHAR
> support -- but the Makefile would still link to plain *ncurses* while
> building nconfig (which was built without WIDECHAR support).
>
> This would cause a crash after using *wattrset* on a WINDOW instance.
> WIDECHAR *wattrset* would try to set the _color member in the WINDOW
> struct which does not exist in the NON-WIDECHAR ncurses instance. It
> would end up clobbering data outside the struct (usually _line entries).
>
> I found an upstream patch fixing the issue, so I'm applying it to
> Buildroot's kconfig.
>
> Signed-off-by: Guillermo A. Amaral <g@maral.me>
> ---
> support/kconfig/Makefile | 3 +-
> ...onfig-nconfig-fix-multi-byte-UTF-handling.patch | 45 ++++++++++++++++++++++
> support/kconfig/patches/series | 1 +
> 3 files changed, 48 insertions(+), 1 deletion(-)
> create mode 100644 support/kconfig/patches/18-kconfig-nconfig-fix-multi-byte-UTF-handling.patch
I've applied after tweaking a bit the commit title ("support/kconfig"
instead of "kconfig") and the commit log (using the singular first
person is not very common).
Thanks a lot for this contribution!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-15 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 3:12 [Buildroot] [PATCH 1/1] Fix nconfig for systems with both ncurses and ncursesw Guillermo A. Amaral
2018-01-14 13:34 ` Thomas Petazzoni
2018-01-14 16:39 ` Guillermo A. Amaral
2018-01-14 17:28 ` [Buildroot] [PATCH 1/1] kconfig: Apply upstream nconfig ncurses/ncursesw fix Guillermo A. Amaral
2018-01-15 20:37 ` Thomas Petazzoni [this message]
2018-01-16 3:14 ` Guillermo A. Amaral
2018-01-16 22:25 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115213706.61ee21b5@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.