From: Al Viro <viro@ZenIV.linux.org.uk>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Thayer <michael.thayer@oracle.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Mon, 15 Jan 2018 22:36:45 +0000 [thread overview]
Message-ID: <20180115223644.GN13338@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180115175116.4130-2-hdegoede@redhat.com>
* what hch said about mount options. Get rid of that before the thing
goes into mainline.
* all "inode = GET_F_DENTRY(f)->d_inode;" are complete BS; it's called
file_inode(f). Kill GET_F_DENTRY() off and be done with that.
* your ->rename() can race with ->get_link(). Look at the place where
the former reassigns ->path and frees the old value and think what
happens if the latter is called just prior to that kfree().
* the same goes for sf_inode_revalidate() vs. rename().
* just what happens to ->path of inode when e.g. its grandparent
directory is renamed?
* AFAICS, you consider all negative dentries invalid. Why do you even
hash them, then?
next prev parent reply other threads:[~2018-01-15 22:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 17:51 [PATCH v2 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support Hans de Goede
2018-01-15 17:51 ` [PATCH v2] " Hans de Goede
2018-01-15 17:55 ` Christoph Hellwig
2018-01-15 18:01 ` Hans de Goede
2018-01-15 19:32 ` Amir Goldstein
2018-01-15 19:41 ` Hans de Goede
2018-01-15 20:22 ` Amir Goldstein
2018-01-15 22:36 ` Al Viro [this message]
2018-01-16 10:15 ` Hans de Goede
2018-01-17 3:19 ` Al Viro
2018-01-17 10:45 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180115223644.GN13338@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.thayer@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.