Re: [PATCH rdma-next 2/3] RDMA/cma: Introduce API to read GIDs for multiple transports

[Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>]

On Mon, Jan 15, 2018 at 10:43:31PM +0000, Parav Pandit wrote:

> > And the prior patch makes a bit more sense after looking here, but the series
> > seems in the wrong order -> the patch to break rdma_addr_get_sgid should go

> rdma_addr_get_sgid() worked only in very limited case.  Since all
> patches are in same series, I don't see order breaks anything. But
> changing order is fine in revised series.

When you order the patches in a series you are trying to tell a story
to the reviewer. It isn't just a random collection of related patches.

Here the story is fixing the few places that are hard wired to use
GIDs to have sane GID information for RoCE.

Every patch should advance that story withou outgoing backwards. In
this case the first patch totally breaks the GIDs in RoCE which breaks
the understandability of the story - if you had put this patch at the
end of the list and said:

 Now that all RoCE users of rdma_addr_get_sgid() call rdma_read_gids()
 we can remove the sketchy RoCE specific support from
 rdma_addr_get_sgid()

Then the entire story makes a lot more sense, and the patch becomes a
conclusion, not a confusing starting point.

This also aide bisect-ability - we don't want to see patches break
working functionality in the middle of a series because 'git bisect'
does not know about series boundaries.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html