All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux-kernel-dev at beckhoff.com <linux-kernel-dev@beckhoff.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 0/4] arm: imx53: remove usage of mx53_dram_size
Date: Tue, 16 Jan 2018 07:59:00 +0100	[thread overview]
Message-ID: <20180116065905.5348-1-linux-kernel-dev@beckhoff.com> (raw)

From: Patrick Bruenn <p.bruenn@beckhoff.com>

Global variables are not available during board_init_f().
The i.MX53 boards m53evk, mx53cx9020 and mx53loco are using the exact
same dram initialization code, which uses
'static uint32_t mx53_dram_size[2];' in dram_init(),
dram_init_banksize() and get_effective_memsize() to avoid multiple
calls to get_ram_size().

This series replaces the static variable with multiple calls to
get_ram_size() and moves the shared code into arch/arm/mach-imx/mx5/.

The first patch is required to let cx9020 boot again. Please include at
least this one. Without that patch u-boot on cx9020 is broken.

The second patch moves that code to a common place to be reused by
m53evk and mx53loco. Pick it only if you think this change is useful for
one of these boards and you are willing to include the third and/or last
patch.
Pick the third patch if you want to use the changed code for m53evk.
Pick the last patch if you want to use the changed code for mx53loco.


Changes in v3:
- rebase to v2018.01
- fix the cover-letter to make it more clear that the first patch is
  required to make the cx9020 boot again. All other patches are
  optional.

Changes in v2:
- move dram initialization into common location
- reuse fixed dram initialization for m53evk and mx53loco

Patrick Bruenn (4):
  arm: imx: cx9020: remove usage of mx53_dram_size
  arm: imx: cx9020: move dram init into common place
  arm: imx: m53evk: remove usage of mx53_dram_size
  arm: imx: mx53loco: remove usage of mx53_dram_size

 arch/arm/mach-imx/mx5/Makefile         |  5 ++++
 arch/arm/mach-imx/mx5/mx53_dram.c      | 45 ++++++++++++++++++++++++++++++++++
 board/aries/m53evk/m53evk.c            | 39 -----------------------------
 board/beckhoff/mx53cx9020/mx53cx9020.c | 39 -----------------------------
 board/freescale/mx53loco/mx53loco.c    | 39 -----------------------------
 5 files changed, 50 insertions(+), 117 deletions(-)
 create mode 100644 arch/arm/mach-imx/mx5/mx53_dram.c

-- 
2.11.0

             reply	other threads:[~2018-01-16  6:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  6:59 linux-kernel-dev at beckhoff.com [this message]
2018-01-16  6:59 ` [U-Boot] [PATCH v3 1/4] arm: imx: cx9020: remove usage of mx53_dram_size linux-kernel-dev at beckhoff.com
2018-01-16  6:59 ` [U-Boot] [PATCH v3 2/4] arm: imx: cx9020: move dram init into common place linux-kernel-dev at beckhoff.com
2018-01-16  6:59 ` [U-Boot] [PATCH v3 3/4] arm: imx: m53evk: remove usage of mx53_dram_size linux-kernel-dev at beckhoff.com
2018-01-16  6:59 ` [U-Boot] [PATCH v3 4/4] arm: imx: mx53loco: " linux-kernel-dev at beckhoff.com
2018-02-04 10:01 ` [U-Boot] [PATCH v3 0/4] arm: imx53: " Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180116065905.5348-1-linux-kernel-dev@beckhoff.com \
    --to=linux-kernel-dev@beckhoff.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.