From: Andrew Lunn <andrew@lunn.ch>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"madalin.bucur@nxp.com" <madalin.bucur@nxp.com>,
"madskateman@gmail.com" <madskateman@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: DPAA Ethernet traffice troubles with Linux kernel
Date: Tue, 16 Jan 2018 15:38:36 +0100 [thread overview]
Message-ID: <20180116143836.GC22903@lunn.ch> (raw)
In-Reply-To: <1516035556.18795.71.camel@infinera.com>
> Hi, just saw this and thought of a small patch I just wrote for mdio bus, o idea
> if it is relevant but here goes:
>
> From fe0b98d54a79779482700676331b4d10a0f3cada Mon Sep 17 00:00:00 2001
> From: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Date: Sun, 14 Jan 2018 21:27:20 +0100
> Subject: [PATCH] of_mdiobus_register: Continue after error
>
> of_mdiobus_register unregister itself if one phy fails to register
> which is bad for system having all its PHYs on the same MDIO bus.
> Just log the error and continue with the remaining PHYs instead.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Hi Joakim
You appear to be using an old kernel. Take a look at:
commit 95f566de0269a0c59fd6a737a147731302136429
Author: Madalin Bucur <madalin.bucur@nxp.com>
Date: Tue Jan 9 14:43:34 2018 +0200
of_mdio: avoid MDIO bus removal when a PHY is missing
If one of the child devices is missing the of_mdiobus_register_phy()
call will return -ENODEV. When a missing device is encountered the
registration of the remaining PHYs is stopped and the MDIO bus will
fail to register. Propagate all errors except ENODEV to avoid it.
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Andrew
next prev parent reply other threads:[~2018-01-16 15:16 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 20:39 DPAA Ethernet traffice troubles with Linux kernel mad skateman
2018-01-15 16:38 ` Madalin-cristian Bucur
2018-01-15 16:38 ` Madalin-cristian Bucur
2018-01-15 16:59 ` Joakim Tjernlund
2018-01-15 16:59 ` Joakim Tjernlund
2018-01-15 19:03 ` Christian Zigotzky
2018-01-15 19:09 ` Christian Zigotzky
2018-01-15 20:21 ` mad skateman
2018-01-15 20:21 ` mad skateman
2018-01-15 21:32 ` mad skateman
2018-01-15 21:32 ` mad skateman
2018-01-16 15:04 ` Andrew Lunn
2018-01-16 17:07 ` Madalin-cristian Bucur
2018-01-16 17:07 ` Madalin-cristian Bucur
2018-01-16 14:38 ` Andrew Lunn [this message]
2018-01-16 17:57 ` Joakim Tjernlund
2018-01-16 17:57 ` Joakim Tjernlund
2018-01-16 18:16 ` mad skateman
2018-01-16 18:16 ` mad skateman
2018-01-16 18:38 ` mad skateman
2018-01-16 18:38 ` mad skateman
2018-01-16 18:39 ` mad skateman
2018-01-16 18:39 ` mad skateman
2018-01-17 5:54 ` Christian Zigotzky
2018-01-17 5:54 ` Christian Zigotzky
[not found] ` <ABA45EE3-92E3-4706-90F9-516E227646E2@xenosoft.de>
2018-01-17 7:22 ` Christian Zigotzky
2018-01-16 18:44 ` mad skateman
2018-01-16 21:00 ` Andrew Lunn
2018-01-16 21:15 ` mad skateman
2018-01-16 20:53 ` Andrew Lunn
2018-01-17 11:47 ` Joakim Tjernlund
2018-01-17 11:47 ` Joakim Tjernlund
2018-01-17 12:06 ` mad skateman
2018-01-17 12:06 ` mad skateman
2018-01-17 13:43 ` Andrew Lunn
2018-01-17 14:15 ` Madalin-cristian Bucur
2018-01-17 14:15 ` Madalin-cristian Bucur
2018-01-17 14:24 ` Madalin-cristian Bucur
2018-01-17 14:24 ` Madalin-cristian Bucur
2018-01-17 14:43 ` Madalin-cristian Bucur
2018-01-17 14:43 ` Madalin-cristian Bucur
2018-02-03 11:54 ` mad skateman
2018-02-06 11:20 ` Christian Zigotzky
2018-02-07 21:00 ` mad skateman
2018-02-07 21:17 ` Andrew Lunn
2018-02-07 22:13 ` Christian Zigotzky
2018-01-17 14:11 ` Madalin-cristian Bucur
2018-01-17 14:11 ` Madalin-cristian Bucur
2018-01-17 15:00 ` Joakim Tjernlund
2018-01-17 15:00 ` Joakim Tjernlund
2018-01-18 9:04 ` Joakim Tjernlund
2018-01-18 9:04 ` Joakim Tjernlund
2018-01-19 8:00 ` Joakim Tjernlund
2018-01-19 8:00 ` Joakim Tjernlund
2018-01-19 13:22 ` Andrew Lunn
2018-01-19 13:42 ` Joakim Tjernlund
2018-01-19 13:42 ` Joakim Tjernlund
2018-02-04 16:47 ` PA Semi PWRficient Gigabit Ethernet doesn't work anymore since the first networking updates for the kernel 4.16 Christian Zigotzky
2018-02-04 17:16 ` Andrew Lunn
2018-02-04 20:01 ` Florian Fainelli
2018-02-05 9:38 ` Christian Zigotzky
2018-02-05 14:29 ` Andrew Lunn
2018-02-05 15:27 ` Christian Zigotzky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116143836.GC22903@lunn.ch \
--to=andrew@lunn.ch \
--cc=Joakim.Tjernlund@infinera.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=madskateman@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.