From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH v3] firmware: qcom: scm: Fix incorrect of_node_put calls
 in scm_init
Date: Tue, 16 Jan 2018 08:45:49 -0800
Message-ID: <20180116164549.GE478@tuxbook>
References: <1513345214-22835-1-git-send-email-lollivier@baylibre.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-arm-msm-owner@vger.kernel.org>
Received: from mail-pf0-f195.google.com ([209.85.192.195]:36037 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750823AbeAPQpx (ORCPT
        <rfc822;linux-arm-msm@vger.kernel.org>);
        Tue, 16 Jan 2018 11:45:53 -0500
Received: by mail-pf0-f195.google.com with SMTP id 23so9978330pfp.3
        for <linux-arm-msm@vger.kernel.org>; Tue, 16 Jan 2018 08:45:52 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1513345214-22835-1-git-send-email-lollivier@baylibre.com>
Sender: linux-arm-msm-owner@vger.kernel.org
List-Id: linux-arm-msm@vger.kernel.org
To: Loys Ollivier <lollivier@baylibre.com>
Cc: Andy Gross <andy.gross@linaro.org>, David Brown <david.brown@linaro.org>, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Jerome Brunet <jbrunet@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>

On Fri 15 Dec 05:40 PST 2017, Loys Ollivier wrote:

> When using other platform architectures, in the init of the qcom_scm
> driver, of_node_put is called on /firmware if no qcom dt is found.
> This results in a kernel error: Bad of_node_put() on /firmware.
> 
> These calls to of_node_put from the qcom_scm init are unnecessary as
> of_find_matching_node and of_platform_populate are calling it
> automatically.
> 
> Remove the calls to of_node_put() on fw_np.
> 
> Fixes: d0f6fa7ba2d6 ("firmware: qcom: scm: Convert SCM to platform driver")
> Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Loys Ollivier <lollivier@baylibre.com>

Hi Loys,

Your patch is correct! We are however removing all this logic from
qcom_scm_init() in v4.16.

See:
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/commit/?h=for-next&id=3aa0582fdb824139630298880fbf78d4ac774d3c
https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/commit/?h=for-next&id=3aa0582fdb824139630298880fbf78d4ac774d3c

Regards,
Bjorn