From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:55338 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751004AbeAPQ6k (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 16 Jan 2018 11:58:40 -0500
Date: Tue, 16 Jan 2018 17:58:40 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Jeff Mahoney <jeffm@suse.com>
Cc: stable@vger.kernel.org, Anand Jain <anand.jain@oracle.com>
Subject: Re: [PATCH 3.10.y] [FIX BAD BACKPORT] Btrfs: add missing brelse when
 superblock checksum fails
Message-ID: <20180116165840.GA7840@kroah.com>
References: <a6b0ad35-c2d1-63dc-c28d-3f327a7aaae2@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a6b0ad35-c2d1-63dc-c28d-3f327a7aaae2@suse.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, Jan 16, 2018 at 11:25:17AM -0500, Jeff Mahoney wrote:
> Commit b2acdddfad13c38a1e8b927d83c3cf321f63601a upstream.
> 
> linux-3.10.y commit bf00d124e07 (Btrfs: add missing brelse when
> superblock checksum fails) was misapplied to a later error handling
> site.  The result is that it doesn't actually free the buffer on
> checksum failure but does attempt to double free the buffer if
> unsupported features are used.
> 
> The backport of b2acdddfad1 in other branches is correct.
> 
> Cc: <stable@vger.kernel.org> # 3.10
> Cc: Anand Jain <anand.jain@oracle.com>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
>  fs/btrfs/disk-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

3.10 is long obsolete, sorry.

greg k-h