From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write() Date: Tue, 16 Jan 2018 10:57:37 -0800 Message-ID: <20180116185736.GA149565@google.com> References: <20180109203248.139249-1-briannorris@chromium.org> <20180109203248.139249-2-briannorris@chromium.org> <199f9097-736e-afe8-2093-bb28fba8b308@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: hl@rock-chips.com, linux-rockchip@lists.infradead.org, David Airlie , hoegsberg@gmail.com, Philippe Cornu , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yannick Fertre , Nickey Yang , mka@chromium.org, Laurent Pinchart , zyw@rock-chips.com, xbl@rock-chips.com, Vincent Abriou List-Id: linux-rockchip.vger.kernel.org T24gVHVlLCBKYW4gMTYsIDIwMTggYXQgMTI6MjI6NTJQTSArMDUzMCwgQXJjaGl0IFRhbmVqYSB3 cm90ZToKPiBPbiAwMS8xMC8yMDE4IDA4OjAzIFBNLCBBbmRyemVqIEhhamRhIHdyb3RlOgo+ID5P biAwOS4wMS4yMDE4IDIxOjMyLCBCcmlhbiBOb3JyaXMgd3JvdGU6Cj4gPj5AQCAtMzg2LDkgKzM4 Niw5IEBAIHN0YXRpYyBpbnQgZHdfbWlwaV9kc2lfd3JpdGUoc3RydWN0IGR3X21pcGlfZHNpICpk c2ksCj4gPj4gIAkJfQo+ID4+ICAJfQo+ID4+LQlyZW1haW5kZXIgPSAwOwo+ID4+LQltZW1jcHko JnJlbWFpbmRlciwgcGFja2V0LT5oZWFkZXIsIHNpemVvZihwYWNrZXQtPmhlYWRlcikpOwo+ID4+ LQlyZXR1cm4gZHdfbWlwaV9kc2lfZ2VuX3BrdF9oZHJfd3JpdGUoZHNpLCByZW1haW5kZXIpOwo+ ID4+Kwl3b3JkID0gMDsKPiA+PisJbWVtY3B5KCZ3b3JkLCBwYWNrZXQtPmhlYWRlciwgc2l6ZW9m KHBhY2tldC0+aGVhZGVyKSk7Cj4gPj4rCXJldHVybiBkd19taXBpX2RzaV9nZW5fcGt0X2hkcl93 cml0ZShkc2ksIGxlMzJfdG9fY3B1KHdvcmQpKTsKPiA+Cj4gPllvdSBjb3VsZCBjcmVhdGUgYW5k IHVzZSBhcHByb3ByaWF0ZSBoZWxwZXIsIGxldHMgc2F5Ogo+ID4KPiA+dTMyIGxlX3RvX2NwdXAo Y29uc3QgdTggKnAsIGludCBjb3VudCkKPiA+ewo+ID4gwqDCoMKgIF9fbGUzMiByID0gMDsKPiA+ Cj4gPiDCoMKgwqAgbWVtY3B5KCZyLCBwLCBjb3VudCk7Cj4gPiDCoMKgwqAgcmV0dXJuIGxlMzJf dG9fY3B1KHIpOwo+ID59CgpJIHN1cHBvc2UgdGhhdCBjb3VsZCBiZSBhIHNtYWxsIGltcHJvdmVt ZW50LCBmb3IgZnV0dXJlIGNvbnNpZGVyYXRpb24sCmlmIHRoaXMgZ2V0cyB0b28gb3V0IG9mIGhh bmQuCgo+ID5XaXRoIG9yIHdpdGhvdXQgdGhpcyBjaGFuZ2U6Cj4gPlJldmlld2VkLWJ5OiBBbmRy emVqIEhhamRhIDxhLmhhamRhQHNhbXN1bmcuY29tPgoKVGhhbmtzIQoKPiBRdWV1ZWQgdG8gZHJt LW1pc2MtbmV4dCBhcyBpcy4KClRoYW5rcyEKCkJyaWFuCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751700AbeAPS5n (ORCPT + 1 other); Tue, 16 Jan 2018 13:57:43 -0500 Received: from mail-pl0-f68.google.com ([209.85.160.68]:40937 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbeAPS5l (ORCPT ); Tue, 16 Jan 2018 13:57:41 -0500 X-Google-Smtp-Source: ACJfBovkMNYO6LjcvrxFSrnUrkrY0slAaD5t7gm1asbYCztfrSwhybFUznRvsYDoF61eVC0fyBXDbw== Date: Tue, 16 Jan 2018 10:57:37 -0800 From: Brian Norris To: Archit Taneja Cc: Andrzej Hajda , Laurent Pinchart , David Airlie , Yannick Fertre , Philippe Cornu , Vincent Abriou , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sean Paul , Nickey Yang , hl@rock-chips.com, linux-rockchip@lists.infradead.org, mka@chromium.org, hoegsberg@gmail.com, zyw@rock-chips.com, xbl@rock-chips.com Subject: Re: [PATCH v2 2/2] drm/bridge/synopsys: dsi: handle endianness correctly in dw_mipi_dsi_write() Message-ID: <20180116185736.GA149565@google.com> References: <20180109203248.139249-1-briannorris@chromium.org> <20180109203248.139249-2-briannorris@chromium.org> <199f9097-736e-afe8-2093-bb28fba8b308@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Tue, Jan 16, 2018 at 12:22:52PM +0530, Archit Taneja wrote: > On 01/10/2018 08:03 PM, Andrzej Hajda wrote: > >On 09.01.2018 21:32, Brian Norris wrote: > >>@@ -386,9 +386,9 @@ static int dw_mipi_dsi_write(struct dw_mipi_dsi *dsi, > >> } > >> } > >>- remainder = 0; > >>- memcpy(&remainder, packet->header, sizeof(packet->header)); > >>- return dw_mipi_dsi_gen_pkt_hdr_write(dsi, remainder); > >>+ word = 0; > >>+ memcpy(&word, packet->header, sizeof(packet->header)); > >>+ return dw_mipi_dsi_gen_pkt_hdr_write(dsi, le32_to_cpu(word)); > > > >You could create and use appropriate helper, lets say: > > > >u32 le_to_cpup(const u8 *p, int count) > >{ > >     __le32 r = 0; > > > >     memcpy(&r, p, count); > >     return le32_to_cpu(r); > >} I suppose that could be a small improvement, for future consideration, if this gets too out of hand. > >With or without this change: > >Reviewed-by: Andrzej Hajda Thanks! > Queued to drm-misc-next as is. Thanks! Brian