From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: Woody Suwalski <terraluna977@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/vmwgfx: Fix a boot time warning
Date: Wed, 17 Jan 2018 09:47:17 +0100 [thread overview]
Message-ID: <20180117084717.GJ2759@phenom.ffwll.local> (raw)
In-Reply-To: <1516177285-2384-1-git-send-email-thellstrom@vmware.com>
On Wed, Jan 17, 2018 at 09:21:25AM +0100, Thomas Hellstrom wrote:
> From: Woody Suwalski <terraluna977@gmail.com>
>
> The 4.15 vmwgfx driver shows a warning during boot.
> It is caused by a mismatch between the result of vmw_enable_vblank()
> and what the drm_atomic_helper expects.
>
> Signed-off by: Woody Suwalski <terraluna977@gmail.com>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Just curious question, but why do you even have all that code? Not
enabling any of the vblank stuff should also work with atomic drivers, and
would require much less boilerplate ...
Either way: Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 641294a..fcd5814 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -1863,7 +1863,7 @@ u32 vmw_get_vblank_counter(struct drm_device *dev, unsigned int pipe)
> */
> int vmw_enable_vblank(struct drm_device *dev, unsigned int pipe)
> {
> - return -ENOSYS;
> + return -EINVAL;
> }
>
> /**
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-17 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 8:21 [PATCH] drm/vmwgfx: Fix a boot time warning Thomas Hellstrom
2018-01-17 8:47 ` Daniel Vetter [this message]
2018-01-17 8:49 ` Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117084717.GJ2759@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=terraluna977@gmail.com \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.