From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH] Documentation: Fix misconversion of #if
Date: Wed, 17 Jan 2018 09:04:49 -0200 [thread overview]
Message-ID: <20180117090449.04785d5b@vento.lan> (raw)
In-Reply-To: <20180117034055.11053-1-willy@infradead.org>
Em Tue, 16 Jan 2018 19:40:55 -0800
Matthew Wilcox <willy@infradead.org> escreveu:
> From: Matthew Wilcox <mawilcox@microsoft.com>
>
> At some stage of the conversion pipeline, something thought that the
> DocBook entity # should be rendered as NUM instead of #.
>
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
> Documentation/kernel-hacking/hacking.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/kernel-hacking/hacking.rst b/Documentation/kernel-hacking/hacking.rst
> index daf3883b2694..5c4d30e81b7f 100644
> --- a/Documentation/kernel-hacking/hacking.rst
> +++ b/Documentation/kernel-hacking/hacking.rst
> @@ -690,8 +690,8 @@ not provide the necessary runtime environment and the include files are
> not tested for it. It is still possible, but not recommended. If you
> really want to do this, forget about exceptions at least.
>
> -NUMif
> ------
> +#if
> +---
>
> It is generally considered cleaner to use macros in header files (or at
> the top of .c files) to abstract away functions rather than using \`#if'
Thanks,
Mauro
next prev parent reply other threads:[~2018-01-17 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 3:40 [PATCH] Documentation: Fix misconversion of #if Matthew Wilcox
2018-01-17 11:04 ` Mauro Carvalho Chehab [this message]
2018-01-17 23:46 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117090449.04785d5b@vento.lan \
--to=mchehab@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.