From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: dmaengine: rcar-dmac: Make DMAC reinit during system resume explicit From: Vinod Koul Message-Id: <20180117101917.GN18649@localhost> Date: Wed, 17 Jan 2018 15:49:17 +0530 To: Geert Uytterhoeven Cc: Dan Williams , Ulf Hansson , "Rafael J . Wysocki" , dmaengine@vger.kernel.org, linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org List-ID: T24gV2VkLCBKYW4gMTcsIDIwMTggYXQgMTA6Mzg6MjhBTSArMDEwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IFRoZSBjdXJyZW50IChlbXB0eSkgc3lzdGVtIHNsZWVwIGNhbGxiYWNrcyBy ZWx5IG9uIHRoZSBQTSBjb3JlIHRvIGZvcmNlCj4gYSBydW50aW1lIHJlc3VtZSB0byByZWluaXRp YWxpemUgdGhlIERNQUMgcmVnaXN0ZXJzIGR1cmluZyBzeXN0ZW0KPiByZXN1bWUuICBXaXRob3V0 IGEgcmVpbml0aWFsaXphdGlvbiwgZS5nLiBTQ0lGIERNQSB3aWxsIGhhbmcgc2lsZW50bHkKPiBh ZnRlciBhIHN5c3RlbSByZXN1bWUgb24gUi1DYXIgR2VuMy4KPiAKPiBNYWtlIHRoaXMgZXhwbGlj aXQgYnkgdXNpbmcgcG1fcnVudGltZV9mb3JjZV97c3VzcGVuZCxyZXN1bWV9KCkgYXMgdGhlCj4g c3lzdGVtIHNsZWVwIGNhbGxiYWNrcyBpbnN0ZWFkLiAgVXNlIFNFVF9MQVRFX1NZU1RFTV9TTEVF UF9QTV9PUFMoKSBhcwo+IERNQSBlbmdpbmVzIG11c3QgYmUgaW5pdGlhbGl6ZWQgYmVmb3JlIGFs bCBETUEgc2xhdmUgZGV2aWNlcy4KPiAKPiBTdWdnZXN0ZWQtYnk6IFVsZiBIYW5zc29uIDx1bGYu aGFuc3NvbkBsaW5hcm8ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IEdlZXJ0IFV5dHRlcmhvZXZlbiA8 Z2VlcnQrcmVuZXNhc0BnbGlkZXIuYmU+Cj4gLS0tCj4gVGhpcyBpcyBhIGRlcGVuZGVuY3kgZm9y ICJbUEFUQ0ggMS8yXSBQTSAvIGdlbnBkOiBTdG9wL3N0YXJ0IGRldmljZXMKPiB3aXRob3V0IHBt X3J1bnRpbWVfZm9yY2Vfc3VzcGVuZC9yZXN1bWUoKSIKPiAoaHR0cHM6Ly93d3cuc3Bpbmljcy5u ZXQvbGlzdHMva2VybmVsL21zZzI2OTY4MDIuaHRtbCksIHNvIHBlcmhhcHMgaXQKPiBtYWtlcyBt b3N0IHNlbnNlIGlmIFJhZmFlbCB0YWtlcyBpdCB0aHJvdWdoIHRoZSBQTSB0cmVlPwoKU291bmRz IG9rYXkgdG8gbWUuCgpBY2tlZC1CeTogVmlub2QgS291bCA8dmlub2Qua291bEBpbnRlbC5jb20+ Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] dmaengine: rcar-dmac: Make DMAC reinit during system resume explicit Date: Wed, 17 Jan 2018 15:49:17 +0530 Message-ID: <20180117101917.GN18649@localhost> References: <1516181908-16930-1-git-send-email-geert+renesas@glider.be> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1516181908-16930-1-git-send-email-geert+renesas@glider.be> Sender: linux-renesas-soc-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Dan Williams , Ulf Hansson , "Rafael J . Wysocki" , dmaengine@vger.kernel.org, linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Wed, Jan 17, 2018 at 10:38:28AM +0100, Geert Uytterhoeven wrote: > The current (empty) system sleep callbacks rely on the PM core to force > a runtime resume to reinitialize the DMAC registers during system > resume. Without a reinitialization, e.g. SCIF DMA will hang silently > after a system resume on R-Car Gen3. > > Make this explicit by using pm_runtime_force_{suspend,resume}() as the > system sleep callbacks instead. Use SET_LATE_SYSTEM_SLEEP_PM_OPS() as > DMA engines must be initialized before all DMA slave devices. > > Suggested-by: Ulf Hansson > Signed-off-by: Geert Uytterhoeven > --- > This is a dependency for "[PATCH 1/2] PM / genpd: Stop/start devices > without pm_runtime_force_suspend/resume()" > (https://www.spinics.net/lists/kernel/msg2696802.html), so perhaps it > makes most sense if Rafael takes it through the PM tree? Sounds okay to me. Acked-By: Vinod Koul -- ~Vinod