From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook
Date: Wed, 17 Jan 2018 19:11:15 +0200 [thread overview]
Message-ID: <20180117171115.GN10981@intel.com> (raw)
In-Reply-To: <20180115115119.16747.48922@emeril.freedesktop.org>
On Mon, Jan 15, 2018 at 11:51:19AM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/3] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook
> URL : https://patchwork.freedesktop.org/series/36431/
> State : failure
>
> == Summary ==
>
> Series 36431v1 series starting with [1/3] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook
> https://patchwork.freedesktop.org/api/1.0/series/36431/revisions/1/mbox/
>
> Test debugfs_test:
> Subgroup read_all_entries:
> incomplete -> PASS (fi-snb-2520m) fdo#103713
> pass -> DMESG-WARN (fi-bdw-gvtdvm) fdo#103938 +1
> Test kms_cursor_legacy:
> Subgroup basic-busy-flip-before-cursor-atomic:
> pass -> FAIL (fi-skl-6770hq)
> Subgroup basic-busy-flip-before-cursor-legacy:
> pass -> FAIL (fi-skl-6770hq)
> Subgroup basic-flip-after-cursor-atomic:
> pass -> FAIL (fi-skl-6770hq)
> Subgroup basic-flip-after-cursor-legacy:
> pass -> FAIL (fi-skl-6770hq)
> Subgroup basic-flip-after-cursor-varying-size:
> pass -> FAIL (fi-skl-6770hq)
> Subgroup basic-flip-before-cursor-atomic:
> pass -> FAIL (fi-skl-6770hq)
> Subgroup basic-flip-before-cursor-legacy:
> pass -> FAIL (fi-skl-6770hq)
> Subgroup basic-flip-before-cursor-varying-size:
> pass -> FAIL (fi-skl-6770hq)
This is LSPCON being silly. It throws a short HPD during the enable
sequence before link training. The short hpd handler then thinks
the link has fallen over and schedules the hotplug work to retrain
the link. The hotplug work will wait for the modeset to finish and
won't actually retrain the link needlessly though.
But all this is apparently sufficient amount of extra work to
throw the test off.
Not quite sure what to do about this. The whole point here was to make
the short hpd handler not take the modeset locks, so we'd need some
other way to deal with the concurrent modeset. I guess I could just
add some kind of 'bool link_trained;' type of thing to intel_dp to go
alongside the link params we already store there. But I've been hoping
we could eliminate this extra state being tracked in intel_dp. But
I can immediately think of anything better that would avoid the modeset
locks in the short pulse handler.
> Test kms_pipe_crc_basic:
> Subgroup suspend-read-crc-pipe-a:
> pass -> DMESG-WARN (fi-kbl-r) fdo#104172
>
> fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
> fdo#103938 https://bugs.freedesktop.org/show_bug.cgi?id=103938
> fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
>
> fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:419s
> fi-bdw-gvtdvm total:288 pass:262 dwarn:2 dfail:0 fail:0 skip:24 time:425s
> fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:372s
> fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:490s
> fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:279s
> fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:485s
> fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:470s
> fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:457s
> fi-cnl-y2 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:528s
> fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45
> fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:277s
> fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:512s
> fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:400s
> fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:462s
> fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:410s
> fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:469s
> fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:500s
> fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:456s
> fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:509s
> fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:576s
> fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:429s
> fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:516s
> fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:527s
> fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:491s
> fi-skl-6770hq total:288 pass:260 dwarn:0 dfail:0 fail:8 skip:20 time:488s
> fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:536s
> fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:399s
> Blacklisted hosts:
> fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:574s
> fi-glk-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:469s
>
> 254125b984264731491e1eafbe58bc50e84a032d drm-tip: 2018y-01m-15d-09h-31m-31s UTC integration manifest
> 40530efe1001 drm/i915: Move SST DP link retraining into the ->post_hotplug() hook
> 54738b5b5101 drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD
> 523afd823a2c drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7669/issues.html
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-01-17 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 21:04 [PATCH 1/3] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook Ville Syrjala
2018-01-12 21:04 ` [PATCH 2/3] drm/i915: Reinitialize sink scrambling/TMDS clock ratio on HPD Ville Syrjala
2018-01-22 6:37 ` Sharma, Shashank
2018-01-22 19:15 ` Ville Syrjälä
2018-01-12 21:04 ` [PATCH 3/3] drm/i915: Move SST DP link retraining into the ->post_hotplug() hook Ville Syrjala
2018-01-12 21:27 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Convert intel_hpd_irq_event() into an encoder hotplug hook Patchwork
2018-01-15 11:51 ` Patchwork
2018-01-17 17:11 ` Ville Syrjälä [this message]
2018-01-16 10:40 ` [PATCH 1/3] " Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180117171115.GN10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.