All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Benjamin Marzinski" <bmarzins@redhat.com>
To: Julian Andres Klode <julian.klode@canonical.com>
Cc: Guan Junxiong <guanjunxiong@huawei.com>,
	Martin Wilck <mwilck@suse.com>,
	development mailing list <dm-devel@redhat.com>
Subject: Re: multipath-tools 0.7.4 failure to remove device
Date: Wed, 17 Jan 2018 12:45:30 -0600	[thread overview]
Message-ID: <20180117184530.GS5638@octiron.msp.redhat.com> (raw)
In-Reply-To: <20180117093842.ywogyfsztihwaie7@jak-x230>

On Wed, Jan 17, 2018 at 10:38:42AM +0100, Julian Andres Klode wrote:
> On Tue, Jan 16, 2018 at 02:30:46PM -0600, Benjamin Marzinski wrote:
> > 
> > RedHat also removes your patches to force ignore_wwids off and imply -n
> > 
> > 64e27ec066a001012f44550f095c93443e91d845
> > ffbb886a8a16cb063d669cd76a1e656fd3ec8c4b
> 
> I only see you reverting the former, in  
> 
>   0013-RH-trigger-change-uevent-on-new-device-creation.patch
> 

Oops. It appears that the other patch got lost in the shuffle of
converting over to the new git repo, and rebasing, and since nothing
uses -i anymore, its absence was never noticed.

I suppose that sort of undercuts my argument that we need to keep -i
working the way I orginally envisioned.

Thanks for noticing.

> 
> > As a side note, RedHat also adds code to automatically fire off a change
> > uevent on all the path devices on the first time a multipath device is
> > created, so that all the path devices get correctly claimed by multipath
> > after the fact, on the first create. It's currently part of the same
> > patch that reverts the two commits listed above, but I have no problem
> > with posting it as a seperate patch. I obviously have no problem with
> > reverting those two commits upstream either. But I don't feel horribly
> > burdened with carrying them as RedHat patches.
> 
> I like that patch, that sounds like a good idea.

I'll post this as an RFC, and we can sort it out along with the other
patches.

-Ben

> 
> -- 
> debian developer - deb.li/jak | jak-linux.org - free software dev
> ubuntu core developer                              i speak de, en

  reply	other threads:[~2018-01-17 18:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-12  8:38 multipath-tools 0.7.4 failure to remove device Julian Andres Klode
2018-01-12 20:35 ` Martin Wilck
2018-01-12 21:47   ` Julian Andres Klode
2018-01-12 22:18     ` Martin Wilck
2018-01-12 22:26       ` Julian Andres Klode
2018-01-15 15:44       ` Julian Andres Klode
2018-01-15 16:12         ` Martin Wilck
2018-01-15 16:26           ` Julian Andres Klode
2018-01-15 16:46             ` Martin Wilck
2018-01-16 20:30               ` Benjamin Marzinski
2018-01-16 22:05                 ` Xose Vazquez Perez
2018-01-17  0:43                 ` Martin Wilck
2018-01-17 18:38                   ` Benjamin Marzinski
2018-01-18  3:50                     ` Benjamin Marzinski
2018-01-18  8:11                       ` Martin Wilck
2018-01-18 15:22                         ` Benjamin Marzinski
2018-01-18 16:32                           ` Martin Wilck
2018-01-17  9:38                 ` Julian Andres Klode
2018-01-17 18:45                   ` Benjamin Marzinski [this message]
2018-01-17 16:27                 ` Multipath path classification revisited Martin Wilck
2018-01-18 22:35                   ` Benjamin Marzinski
2018-01-13 19:46     ` multipath-tools 0.7.4 failure to remove device Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117184530.GS5638@octiron.msp.redhat.com \
    --to=bmarzins@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=guanjunxiong@huawei.com \
    --cc=julian.klode@canonical.com \
    --cc=mwilck@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.