From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3] USB: serial: option: add id for Motorola Solutions TETRA PEI From: Johan Hovold Message-Id: <20180118032607.GF3286@localhost> Date: Thu, 18 Jan 2018 14:26:07 +1100 To: Max Schulze Cc: Johan Hovold , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gVHVlLCBKYW4gMTYsIDIwMTggYXQgMTI6MTI6MzNBTSArMDEwMCwgTWF4IFNjaHVsemUgd3Jv dGU6Cj4gCj4gPiBUaGlzIGluZGljYXRlcyB0aGF0IG9wdGlvbiBpc24ndCB0aGUgcmlnaHQgZHJp dmVyIGZvciB0aGlzIGZvciBkZXZpY2UuCj4gPgo+ID4gSSB0aGluayB3ZSBzaG91bGQgYWRkIGEg bmV3IHNpbXBsZSBkcml2ZXIgZm9yIGl0IGluc3RlYWQsIHdoaWNoIHJlcG9ydHMKPiA+IHRoYXQg bW9kZW0gY29udHJvbCBpc24ndCAoeWV0KSBzdXBwb3J0ZWQgKHllcywgeW91ciBweXRob24gc2Ny aXB0IHdvdWxkCj4gPiBuZWVkIHRvIGJlIHVwZGF0ZWQpLiBUaGlzIGNhbiBiZSBleHRlbmRlZCBp bnRvIGEgInJlYWwiIGRyaXZlciwgc2hvdWxkCj4gPiB3ZSBsZWFybiBtb3JlIGFib3V0IHRoZSBw cm90b2NvbCB1c2VkLgo+IAo+IFRoYW5rIHlvdS4gVGVzdGVkIHdpdGggbWluaXRlcm0ucHkgLSBp dCBkb2Vzbid0IG5lZWQgYW55IGNoYW5nZXMgYmVjYXVzZQo+IG5vIGVycm9uZW91cyBVUkIncyBh cmUgc2VudC4KClRoYXQncyBnb29kLiBJbiB5b3VyIGluaXRpYWwgbWFpbCB5b3UgbWVudGlvbmVk IHRoYXQgaXQgd2FzIGRvaW5nIGEKVElPQ01CSVMgdGhhdCB3YXMgZmFpbGluZyB3aXRoIHRoZSBn ZW5lcmljIGRyaXZlciAod2hpY2ggaXMgZXNzZW50aWFsbHkKdGhlIHNhbWUgdGhpbmcgYXMgYSAi c2ltcGxlIiBkcml2ZXIpLgoKPiBbwqAgMTcyLjI0OTI5N10gdXNiX3NlcmlhbF9zaW1wbGUgMS0x LjQ6MS4wOiBtb3Rvcm9sYV90ZXRyYSBjb252ZXJ0ZXIKPiBkZXRlY3RlZAo+IFvCoCAxNzIuMjQ5 NDAzXSB1c2IgMS0xLjQ6IG1vdG9yb2xhX3RldHJhIGNvbnZlcnRlciBub3cgYXR0YWNoZWQgdG8g dHR5VVNCMAo+IFvCoCAxNzIuMjQ5NTAyXSB1c2Jfc2VyaWFsX3NpbXBsZSAxLTEuNDoxLjE6IG1v dG9yb2xhX3RldHJhIGNvbnZlcnRlcgo+IGRldGVjdGVkCj4gW8KgIDE3Mi4yNDk1NzhdIHVzYiAx LTEuNDogbW90b3JvbGFfdGV0cmEgY29udmVydGVyIG5vdyBhdHRhY2hlZCB0byB0dHlVU0IxCj4g Cj4gPiA+RnJvbSBhN2FiODdhY2Y4NWI2NzMwM2U3YmY2MDY3MzQxNzZhMzY1YWFlOWNkIE1vbiBT ZXAgMTcgMDA6MDA6MDAgMjAwMQo+ID4gRnJvbTogSm9oYW4gSG92b2xkIDxqb2hhbkBrZXJuZWwu b3JnPgo+ID4gRGF0ZTogRnJpLCAxMiBKYW4gMjAxOCAxNzo1MzozNSArMDEwMAo+ID4gU3ViamVj dDogW1BBVENIXSBVU0I6IHNlcmlhbDogc2ltcGxlOiBhZGQgTW90b3JvbGEgVGV0cmEgZHJpdmVy Cj4gPgo+ID4gQWRkIG5ldyBNb3Rvcm9sYSBUZXRyYSAoc2ltcGxlKSBkcml2ZXIgZm9yIE1vdG9y b2xhIFNvbHV0aW9ucyBURVRSQSBQRUkKPiA+IGRldmljZXMuCj4gPgo+ID4gRDogIFZlcj0gMi4w MCBDbHM9MDAoPmlmYyApIFN1Yj0wMCBQcm90PTAwIE14UFM9NjQgI0NmZ3M9ICAxCj4gPiBQOiAg VmVuZG9yPTBjYWQgUHJvZElEPTkwMTEgUmV2PTI0LjE2Cj4gPiBTOiAgTWFudWZhY3R1cmVyPU1v dG9yb2xhIFNvbHV0aW9ucyBJbmMuCj4gPiBTOiAgUHJvZHVjdD1Nb3Rvcm9sYSBTb2x1dGlvbnMg VEVUUkEgUEVJIGludGVyZmFjZQo+ID4gQzogICNJZnM9IDIgQ2ZnIz0gMSBBdHI9ODAgTXhQd3I9 NTAwbUEKPiA+IEk6ICBJZiM9IDAgQWx0PSAwICNFUHM9IDIgQ2xzPWZmKHZlbmQuKSBTdWI9MDAg UHJvdD0wMCBEcml2ZXI9KG5vbmUpCj4gPiBJOiAgSWYjPSAxIEFsdD0gMCAjRVBzPSAyIENscz1m Zih2ZW5kLikgU3ViPTAwIFByb3Q9MDAgRHJpdmVyPShub25lKQo+ID4KPiA+IE5vdGUgdGhhdCB0 aGVzZSBkZXZpY2VzIGRvIG5vdCBzdXBwb3J0IHRoZSBDREMgU0VUX0NPTlRST0xfTElORV9TVEFU RQo+ID4gcmVxdWVzdCAoZm9yIGFueSBpbnRlcmZhY2UpLgo+ID4KPiA+IFJlcG9ydGVkLWJ5OiBN YXggU2NodWx6ZSA8bWF4LnNjaHVsemVAcG9zdGVvLmRlPgo+ID4gQ2M6IHN0YWJsZSA8c3RhYmxl QHZnZXIua2VybmVsLm9yZz4KPiA+IFNpZ25lZC1vZmYtYnk6IEpvaGFuIEhvdm9sZCA8am9oYW5A a2VybmVsLm9yZz4KCj4gV29ya3MgYXMtaXMuIFRlc3RlZCBpbiBtaW5pdGVybS5weSBhbmQgbWlu aWNvbS4KPiAKPiBUZXN0ZWQtYnk6IE1heCBTY2h1bHplIDxtYXguc2NodWx6ZUBwb3N0ZW8uZGU+ CgpUaGFua3MgZm9yIHRlc3RpbmchCgpKb2hhbgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlz IGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkg b2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8g aW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1516246012; cv=none; d=google.com; s=arc-20160816; b=haWcHBJBh2I/rHIJPvwoNTQWo2ZAiC30yj9RQXDkOzUbRa88EClvWX4crI9KIAkWOB lukaacAh8LNTQlUqdubYZ2j5F90VHOgHH+t9gGwLpWes+Q/RIAxtPjRkRr1HfHzpmwwZ DlCk8VdWgG2WBnvC6PlYdChB46QoMv15j6qV/VyOwzwCV3YAIGKBILeSzD+x/6jHLrX7 OVJY2iOG6yoFdKHHKUMYVUzbEgHWyIOX6/GYykQt8p26FjfKGL8JcyXCfiZpZKoYLi4Z uSIBudoHWflqbpMns+WAS32fYdJA/v4hMCHeSiNSFB74DcdYhN3yCM11FiRXX6b5t59Z au+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:sender:dkim-signature:arc-authentication-results; bh=p6as6glQwWHCgPkBw2P3z4R7XvNrNZRJ9mTKYXLu7h0=; b=rUxCOW6aTVIt33fUqsTASyCCKFY9S/9063QgCrVyIC2CB6bJet/MdI5NRkHdID0/WX UCdVQ3RBipHp+0DElDs7eUrGFP/xrWupWfjApE0MFotmy52oOYpXGjCldVAe9IKlLMCP LaZ1bzSJ9Ivp+MZakmRo7HORit3J7o7BwT0cCMU/3x8Ng10bjWs1GkBN+xxooE0vB5ic hC3UV1FClgMyXNpFgVImrm1uefr8T3U73TahkT/cqneBmNOMl6gpdnDTLxxO50ojEKMs 9FsINQ8wbpbNabS3GZtKMQVTjFuzD9gVtu+Vcer5Yb6vF5DCOxBk6fffvmaTbVnAfuR5 8iiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jBHgInEG; spf=pass (google.com: domain of jhovold@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jhovold@gmail.com Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=jBHgInEG; spf=pass (google.com: domain of jhovold@gmail.com designates 209.85.220.41 as permitted sender) smtp.mailfrom=jhovold@gmail.com X-Google-Smtp-Source: ACJfBovh9JDcez+C3oz0gKpAdJ7QxPZRxzmD+Y+qkdcOl3VXQHSVEDPvxY6y5O3bK+1tiZkzDJt4bg== Sender: Johan Hovold X-Google-Original-Sender: Date: Thu, 18 Jan 2018 14:26:07 +1100 From: Johan Hovold To: Max Schulze Cc: Johan Hovold , gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] USB: serial: option: add id for Motorola Solutions TETRA PEI Message-ID: <20180118032607.GF3286@localhost> References: <20180112092954.9161-1-max.schulze@posteo.de> <20180112171902.GC5992@localhost> <1405adb5-8e74-b02a-bf75-cf83bf6b3c91@posteo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1405adb5-8e74-b02a-bf75-cf83bf6b3c91@posteo.de> User-Agent: Mutt/1.7.2 (2016-11-26) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1589339787466110669?= X-GMAIL-MSGID: =?utf-8?q?1589899179246209964?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Tue, Jan 16, 2018 at 12:12:33AM +0100, Max Schulze wrote: > > > This indicates that option isn't the right driver for this for device. > > > > I think we should add a new simple driver for it instead, which reports > > that modem control isn't (yet) supported (yes, your python script would > > need to be updated). This can be extended into a "real" driver, should > > we learn more about the protocol used. > > Thank you. Tested with miniterm.py - it doesn't need any changes because > no erroneous URB's are sent. That's good. In your initial mail you mentioned that it was doing a TIOCMBIS that was failing with the generic driver (which is essentially the same thing as a "simple" driver). > [  172.249297] usb_serial_simple 1-1.4:1.0: motorola_tetra converter > detected > [  172.249403] usb 1-1.4: motorola_tetra converter now attached to ttyUSB0 > [  172.249502] usb_serial_simple 1-1.4:1.1: motorola_tetra converter > detected > [  172.249578] usb 1-1.4: motorola_tetra converter now attached to ttyUSB1 > > > >From a7ab87acf85b67303e7bf606734176a365aae9cd Mon Sep 17 00:00:00 2001 > > From: Johan Hovold > > Date: Fri, 12 Jan 2018 17:53:35 +0100 > > Subject: [PATCH] USB: serial: simple: add Motorola Tetra driver > > > > Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI > > devices. > > > > D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 > > P: Vendor=0cad ProdID=9011 Rev=24.16 > > S: Manufacturer=Motorola Solutions Inc. > > S: Product=Motorola Solutions TETRA PEI interface > > C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA > > I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) > > > > Note that these devices do not support the CDC SET_CONTROL_LINE_STATE > > request (for any interface). > > > > Reported-by: Max Schulze > > Cc: stable > > Signed-off-by: Johan Hovold > Works as-is. Tested in miniterm.py and minicom. > > Tested-by: Max Schulze Thanks for testing! Johan