From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: serial: simple: add Motorola Tetra driver From: Johan Hovold Message-Id: <20180118034641.18293-1-johan@kernel.org> Date: Thu, 18 Jan 2018 14:46:41 +1100 To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Johan Hovold , stable List-ID: QWRkIG5ldyBNb3Rvcm9sYSBUZXRyYSAoc2ltcGxlKSBkcml2ZXIgZm9yIE1vdG9yb2xhIFNvbHV0 aW9ucyBURVRSQSBQRUkKZGV2aWNlcy4KCkQ6ICBWZXI9IDIuMDAgQ2xzPTAwKD5pZmMgKSBTdWI9 MDAgUHJvdD0wMCBNeFBTPTY0ICNDZmdzPSAgMQpQOiAgVmVuZG9yPTBjYWQgUHJvZElEPTkwMTEg UmV2PTI0LjE2ClM6ICBNYW51ZmFjdHVyZXI9TW90b3JvbGEgU29sdXRpb25zIEluYy4KUzogIFBy b2R1Y3Q9TW90b3JvbGEgU29sdXRpb25zIFRFVFJBIFBFSSBpbnRlcmZhY2UKQzogICNJZnM9IDIg Q2ZnIz0gMSBBdHI9ODAgTXhQd3I9NTAwbUEKSTogIElmIz0gMCBBbHQ9IDAgI0VQcz0gMiBDbHM9 ZmYodmVuZC4pIFN1Yj0wMCBQcm90PTAwIERyaXZlcj0obm9uZSkKSTogIElmIz0gMSBBbHQ9IDAg I0VQcz0gMiBDbHM9ZmYodmVuZC4pIFN1Yj0wMCBQcm90PTAwIERyaXZlcj0obm9uZSkKCk5vdGUg dGhhdCB0aGVzZSBkZXZpY2VzIGRvIG5vdCBzdXBwb3J0IHRoZSBDREMgU0VUX0NPTlRST0xfTElO RV9TVEFURQpyZXF1ZXN0IChmb3IgYW55IGludGVyZmFjZSkuCgpSZXBvcnRlZC1ieTogTWF4IFNj aHVsemUgPG1heC5zY2h1bHplQHBvc3Rlby5kZT4KVGVzdGVkLWJ5OiBNYXggU2NodWx6ZSA8bWF4 LnNjaHVsemVAcG9zdGVvLmRlPgpDYzogc3RhYmxlIDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgpT aWduZWQtb2ZmLWJ5OiBKb2hhbiBIb3ZvbGQgPGpvaGFuQGtlcm5lbC5vcmc+Ci0tLQoKR3JlZywg aWYgeW91IHdhbnQgeW91IGNhbiBwaWNrIHRoaXMgb25lIHVwIGZvciA0LjE2IGRpcmVjdGx5IGFz IHdlbGwuCgpUaGFua3MsCkpvaGFuCgoKCiBkcml2ZXJzL3VzYi9zZXJpYWwvS2NvbmZpZyAgICAg ICAgICAgICB8IDEgKwogZHJpdmVycy91c2Ivc2VyaWFsL3VzYi1zZXJpYWwtc2ltcGxlLmMgfCA3 ICsrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv ZHJpdmVycy91c2Ivc2VyaWFsL0tjb25maWcgYi9kcml2ZXJzL3VzYi9zZXJpYWwvS2NvbmZpZwpp bmRleCBhOGQ1ZjJlNDg3OGQuLmM2NmI5MzY2NGQ1NCAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2Iv c2VyaWFsL0tjb25maWcKKysrIGIvZHJpdmVycy91c2Ivc2VyaWFsL0tjb25maWcKQEAgLTYzLDYg KzYzLDcgQEAgY29uZmlnIFVTQl9TRVJJQUxfU0lNUExFCiAJCS0gR29vZ2xlIFVTQiBzZXJpYWwg ZGV2aWNlcwogCQktIEhQNHggY2FsY3VsYXRvcnMKIAkJLSBhIG51bWJlciBvZiBNb3Rvcm9sYSBw aG9uZXMKKwkJLSBNb3Rvcm9sYSBUZXRyYSBkZXZpY2VzCiAJCS0gTm92YXRlbCBXaXJlbGVzcyBH UFMgcmVjZWl2ZXJzCiAJCS0gU2llbWVucyBVU0IvTVBJIGFkYXB0ZXIuCiAJCS0gVmlWT3RlY2gg VmlWT3BheSBVU0IgZGV2aWNlLgpkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc2VyaWFsL3VzYi1z ZXJpYWwtc2ltcGxlLmMgYi9kcml2ZXJzL3VzYi9zZXJpYWwvdXNiLXNlcmlhbC1zaW1wbGUuYwpp bmRleCA3NDE3MmZlMTU4ZGYuLjRlZjc5ZTI5Y2IyNiAxMDA2NDQKLS0tIGEvZHJpdmVycy91c2Iv c2VyaWFsL3VzYi1zZXJpYWwtc2ltcGxlLmMKKysrIGIvZHJpdmVycy91c2Ivc2VyaWFsL3VzYi1z ZXJpYWwtc2ltcGxlLmMKQEAgLTc3LDYgKzc3LDExIEBAIERFVklDRSh2aXZvcGF5LCBWSVZPUEFZ X0lEUyk7CiAJeyBVU0JfREVWSUNFKDB4MjJiOCwgMHgyYzY0KSB9CS8qIE1vdG9yb2xhIFY5NTAg cGhvbmUgKi8KIERFVklDRShtb3RvX21vZGVtLCBNT1RPX0lEUyk7CiAKKy8qIE1vdG9yb2xhIFRl dHJhIGRyaXZlciAqLworI2RlZmluZSBNT1RPUk9MQV9URVRSQV9JRFMoKQkJCVwKKwl7IFVTQl9E RVZJQ0UoMHgwY2FkLCAweDkwMTEpIH0JLyogTW90b3JvbGEgU29sdXRpb25zIFRFVFJBIFBFSSAq LworREVWSUNFKG1vdG9yb2xhX3RldHJhLCBNT1RPUk9MQV9URVRSQV9JRFMpOworCiAvKiBOb3Zh dGVsIFdpcmVsZXNzIEdQUyBkcml2ZXIgKi8KICNkZWZpbmUgTk9WQVRFTF9JRFMoKQkJCVwKIAl7 IFVTQl9ERVZJQ0UoMHgwOWQ3LCAweDAxMDApIH0JLyogTm92QXRlbCBGbGV4UGFjayBHUFMgKi8K QEAgLTEwNyw2ICsxMTIsNyBAQCBzdGF0aWMgc3RydWN0IHVzYl9zZXJpYWxfZHJpdmVyICogY29u c3Qgc2VyaWFsX2RyaXZlcnNbXSA9IHsKIAkmZ29vZ2xlX2RldmljZSwKIAkmdml2b3BheV9kZXZp Y2UsCiAJJm1vdG9fbW9kZW1fZGV2aWNlLAorCSZtb3Rvcm9sYV90ZXRyYV9kZXZpY2UsCiAJJm5v dmF0ZWxfZ3BzX2RldmljZSwKIAkmaHA0eF9kZXZpY2UsCiAJJnN1dW50b19kZXZpY2UsCkBAIC0x MjIsNiArMTI4LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB1c2JfZGV2aWNlX2lkIGlkX3RhYmxl W10gPSB7CiAJR09PR0xFX0lEUygpLAogCVZJVk9QQVlfSURTKCksCiAJTU9UT19JRFMoKSwKKwlN T1RPUk9MQV9URVRSQV9JRFMoKSwKIAlOT1ZBVEVMX0lEUygpLAogCUhQNFhfSURTKCksCiAJU1VV TlRPX0lEUygpLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:38525 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753017AbeARDrg (ORCPT ); Wed, 17 Jan 2018 22:47:36 -0500 From: Johan Hovold To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Johan Hovold , stable Subject: [PATCH] USB: serial: simple: add Motorola Tetra driver Date: Thu, 18 Jan 2018 14:46:41 +1100 Message-Id: <20180118034641.18293-1-johan@kernel.org> Sender: stable-owner@vger.kernel.org List-ID: Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI devices. D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1 P: Vendor=0cad ProdID=9011 Rev=24.16 S: Manufacturer=Motorola Solutions Inc. S: Product=Motorola Solutions TETRA PEI interface C: #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA I: If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none) Note that these devices do not support the CDC SET_CONTROL_LINE_STATE request (for any interface). Reported-by: Max Schulze Tested-by: Max Schulze Cc: stable Signed-off-by: Johan Hovold --- Greg, if you want you can pick this one up for 4.16 directly as well. Thanks, Johan drivers/usb/serial/Kconfig | 1 + drivers/usb/serial/usb-serial-simple.c | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/drivers/usb/serial/Kconfig b/drivers/usb/serial/Kconfig index a8d5f2e4878d..c66b93664d54 100644 --- a/drivers/usb/serial/Kconfig +++ b/drivers/usb/serial/Kconfig @@ -63,6 +63,7 @@ config USB_SERIAL_SIMPLE - Google USB serial devices - HP4x calculators - a number of Motorola phones + - Motorola Tetra devices - Novatel Wireless GPS receivers - Siemens USB/MPI adapter. - ViVOtech ViVOpay USB device. diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c index 74172fe158df..4ef79e29cb26 100644 --- a/drivers/usb/serial/usb-serial-simple.c +++ b/drivers/usb/serial/usb-serial-simple.c @@ -77,6 +77,11 @@ DEVICE(vivopay, VIVOPAY_IDS); { USB_DEVICE(0x22b8, 0x2c64) } /* Motorola V950 phone */ DEVICE(moto_modem, MOTO_IDS); +/* Motorola Tetra driver */ +#define MOTOROLA_TETRA_IDS() \ + { USB_DEVICE(0x0cad, 0x9011) } /* Motorola Solutions TETRA PEI */ +DEVICE(motorola_tetra, MOTOROLA_TETRA_IDS); + /* Novatel Wireless GPS driver */ #define NOVATEL_IDS() \ { USB_DEVICE(0x09d7, 0x0100) } /* NovAtel FlexPack GPS */ @@ -107,6 +112,7 @@ static struct usb_serial_driver * const serial_drivers[] = { &google_device, &vivopay_device, &moto_modem_device, + &motorola_tetra_device, &novatel_gps_device, &hp4x_device, &suunto_device, @@ -122,6 +128,7 @@ static const struct usb_device_id id_table[] = { GOOGLE_IDS(), VIVOPAY_IDS(), MOTO_IDS(), + MOTOROLA_TETRA_IDS(), NOVATEL_IDS(), HP4X_IDS(), SUUNTO_IDS(), -- 2.13.6