From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jiri Benc <jbenc@redhat.com>
Subject: Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II
 support
Date: Thu, 18 Jan 2018 11:13:49 +0100
Message-ID: <20180118111349.74e90798@redhat.com>
References: <1516210371-20732-1-git-send-email-u9012063@gmail.com>
        <1516210371-20732-3-git-send-email-u9012063@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, pshelar@ovn.org
To: William Tu <u9012063@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:40188 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753505AbeARKNw (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 18 Jan 2018 05:13:52 -0500
In-Reply-To: <1516210371-20732-3-git-send-email-u9012063@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Looks much better.

On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote:
> +	OVS_ERSPAN_OPT_IDX,	/* be32 index */

Why don't you convert this to u32 while passing to/from user space?

> +	[OVS_ERSPAN_OPT_IDX]	= { .len = sizeof(u32) },

sizeof(__be32) but see above.

Thanks,

 Jiri