All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Junjie Chen <junjie.j.chen@intel.com>,
	jianfen.tan@intel.com, dev@dpdk.org
Subject: Re: [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool
Date: Thu, 18 Jan 2018 21:16:47 +0800	[thread overview]
Message-ID: <20180118131647.GF29540@yliu-mob> (raw)
In-Reply-To: <0f5ea2ca-5684-8c12-a123-dacab2b071d5@redhat.com>

On Thu, Jan 18, 2018 at 09:44:41AM +0100, Maxime Coquelin wrote:
> 
> 
> On 01/17/2018 04:45 PM, Junjie Chen wrote:
> >dequeue zero copy change buf_addr and buf_iova of mbuf, and return
> >to mbuf pool without restore them, it breaks vm memory if others allocate
> >mbuf from same pool since mbuf reset doesn't reset buf_addr and buf_iova.
> >
> >Signed-off-by: Junjie Chen <junjie.j.chen@intel.com>
> >---
> >v2 changes:
> >Remove useless restore
> >  lib/librte_vhost/virtio_net.c | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-virtio, with below addings:

Fixes: b0a985d1f340 ("vhost: add dequeue zero copy")
Cc: stable@dpdk.org

Thanks.

	--yliu

      reply	other threads:[~2018-01-18 13:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 10:42 [PATCH] vhost: dequeue zero copy should restore mbuf before return to pool Junjie Chen
2018-01-17  7:29 ` Tan, Jianfeng
2018-01-17  8:10   ` Chen, Junjie J
2018-01-17 15:45 ` [PATCH v2] " Junjie Chen
2018-01-18  8:44   ` Maxime Coquelin
2018-01-18 13:16     ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118131647.GF29540@yliu-mob \
    --to=yliu@fridaylinux.org \
    --cc=dev@dpdk.org \
    --cc=jianfen.tan@intel.com \
    --cc=junjie.j.chen@intel.com \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.