From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ladislav Michl Subject: Re: [PATCH v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found Date: Thu, 18 Jan 2018 16:26:13 +0100 Message-ID: <20180118152613.GA22493@lenoch> References: <20180118080453.GA2205@lenoch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Stern Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Greg Kroah-Hartman List-Id: linux-omap@vger.kernel.org On Thu, Jan 18, 2018 at 10:18:41AM -0500, Alan Stern wrote: > On Thu, 18 Jan 2018, Ladislav Michl wrote: > > > Don't complain on -EPROBE_DEFER when no PHY found, the driver > > probe will be retried later. > > > > Signed-off-by: Ladislav Michl > > Acked-by: Tony Lindgren > > Acked-by: Roger Quadros > > --- > > Changes: > > - v2: None, just added Tony's ack > > - v3: Fixed commit message typo spotted by Jaejoong Kim, added Roger's ack > > Although there's nothing wrong with making this change, people don't > like to see character strings broken up just to avoid long lines. Can > you redo the patch without breaking the error message string? Sure I could, but I broke that long line intentionaly. Line lenght rule is normally broken for string just to allow people grepping for error message in source files and I guess everyone sane would grep for "Can't get PHY device for port" which is on single line. So this way we: 1) respect 80 chars limit 2) have error message grepable. Do you still insist on making this one long line? (I have no problem sending v4, just wanted to give some rationale before I eventually do so) Best regards, ladis > > drivers/usb/host/ehci-omap.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c > > index 854b146a457d..fd6170962a1a 100644 > > --- a/drivers/usb/host/ehci-omap.c > > +++ b/drivers/usb/host/ehci-omap.c > > @@ -167,8 +167,9 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) > > continue; > > > > ret = PTR_ERR(phy); > > - dev_err(dev, "Can't get PHY device for port %d: %d\n", > > - i, ret); > > + if (ret != -EPROBE_DEFER) > > + dev_err(dev, "Can't get PHY device for port " > > + "%d: %d\n", i, ret); > > goto err_phy; > > } -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3] usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found From: Ladislav Michl Message-Id: <20180118152613.GA22493@lenoch> Date: Thu, 18 Jan 2018 16:26:13 +0100 To: Alan Stern Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, Greg Kroah-Hartman List-ID: T24gVGh1LCBKYW4gMTgsIDIwMTggYXQgMTA6MTg6NDFBTSAtMDUwMCwgQWxhbiBTdGVybiB3cm90 ZToKPiBPbiBUaHUsIDE4IEphbiAyMDE4LCBMYWRpc2xhdiBNaWNobCB3cm90ZToKPiAKPiA+IERv bid0IGNvbXBsYWluIG9uIC1FUFJPQkVfREVGRVIgd2hlbiBubyBQSFkgZm91bmQsIHRoZSBkcml2 ZXIKPiA+IHByb2JlIHdpbGwgYmUgcmV0cmllZCBsYXRlci4KPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogTGFkaXNsYXYgTWljaGwgPGxhZGlzQGxpbnV4LW1pcHMub3JnPgo+ID4gQWNrZWQtYnk6IFRv bnkgTGluZGdyZW4gPHRvbnlAYXRvbWlkZS5jb20+Cj4gPiBBY2tlZC1ieTogUm9nZXIgUXVhZHJv cyA8cm9nZXJxQHRpLmNvbT4KPiA+IC0tLQo+ID4gIENoYW5nZXM6Cj4gPiAgLSB2MjogTm9uZSwg anVzdCBhZGRlZCBUb255J3MgYWNrCj4gPiAgLSB2MzogRml4ZWQgY29tbWl0IG1lc3NhZ2UgdHlw byBzcG90dGVkIGJ5IEphZWpvb25nIEtpbSwgYWRkZWQgUm9nZXIncyBhY2sKPiAKPiBBbHRob3Vn aCB0aGVyZSdzIG5vdGhpbmcgd3Jvbmcgd2l0aCBtYWtpbmcgdGhpcyBjaGFuZ2UsIHBlb3BsZSBk b24ndCAKPiBsaWtlIHRvIHNlZSBjaGFyYWN0ZXIgc3RyaW5ncyBicm9rZW4gdXAganVzdCB0byBh dm9pZCBsb25nIGxpbmVzLiAgQ2FuIAo+IHlvdSByZWRvIHRoZSBwYXRjaCB3aXRob3V0IGJyZWFr aW5nIHRoZSBlcnJvciBtZXNzYWdlIHN0cmluZz8KClN1cmUgSSBjb3VsZCwgYnV0IEkgYnJva2Ug dGhhdCBsb25nIGxpbmUgaW50ZW50aW9uYWx5LiBMaW5lIGxlbmdodCBydWxlIGlzCm5vcm1hbGx5 IGJyb2tlbiBmb3Igc3RyaW5nIGp1c3QgdG8gYWxsb3cgcGVvcGxlIGdyZXBwaW5nIGZvciBlcnJv ciBtZXNzYWdlIGluCnNvdXJjZSBmaWxlcyBhbmQgSSBndWVzcyBldmVyeW9uZSBzYW5lIHdvdWxk IGdyZXAgZm9yICJDYW4ndCBnZXQgUEhZIGRldmljZSBmb3IKcG9ydCIgd2hpY2ggaXMgb24gc2lu Z2xlIGxpbmUuIFNvIHRoaXMgd2F5IHdlOgoxKSByZXNwZWN0IDgwIGNoYXJzIGxpbWl0CjIpIGhh dmUgZXJyb3IgbWVzc2FnZSBncmVwYWJsZS4KCkRvIHlvdSBzdGlsbCBpbnNpc3Qgb24gbWFraW5n IHRoaXMgb25lIGxvbmcgbGluZT8gKEkgaGF2ZSBubyBwcm9ibGVtIHNlbmRpbmcKdjQsIGp1c3Qg d2FudGVkIHRvIGdpdmUgc29tZSByYXRpb25hbGUgYmVmb3JlIEkgZXZlbnR1YWxseSBkbyBzbykK CkJlc3QgcmVnYXJkcywKCWxhZGlzCgo+ID4gIGRyaXZlcnMvdXNiL2hvc3QvZWhjaS1vbWFwLmMg fCA1ICsrKy0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlv bnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNiL2hvc3QvZWhjaS1vbWFwLmMg Yi9kcml2ZXJzL3VzYi9ob3N0L2VoY2ktb21hcC5jCj4gPiBpbmRleCA4NTRiMTQ2YTQ1N2QuLmZk NjE3MDk2MmExYSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvdXNiL2hvc3QvZWhjaS1vbWFwLmMK PiA+ICsrKyBiL2RyaXZlcnMvdXNiL2hvc3QvZWhjaS1vbWFwLmMKPiA+IEBAIC0xNjcsOCArMTY3 LDkgQEAgc3RhdGljIGludCBlaGNpX2hjZF9vbWFwX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCj4gPiAgCQkJCWNvbnRpbnVlOwo+ID4gIAo+ID4gIAkJCXJldCA9IFBUUl9FUlIo cGh5KTsKPiA+IC0JCQlkZXZfZXJyKGRldiwgIkNhbid0IGdldCBQSFkgZGV2aWNlIGZvciBwb3J0 ICVkOiAlZFxuIiwKPiA+IC0JCQkJCWksIHJldCk7Cj4gPiArCQkJaWYgKHJldCAhPSAtRVBST0JF X0RFRkVSKQo+ID4gKwkJCQlkZXZfZXJyKGRldiwgIkNhbid0IGdldCBQSFkgZGV2aWNlIGZvciBw b3J0ICIKPiA+ICsJCQkJCSIlZDogJWRcbiIsIGksIHJldCk7Cj4gPiAgCQkJZ290byBlcnJfcGh5 Owo+ID4gIAkJfQotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxp bmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1h am9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3Zn ZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==