From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jURbgeTawy4pEitIxjOGsXZBrIGOITvRNhgnR15KCFw=; b=c9E9sAWpMIPjjxc48gezdP4vdOQY9jDG+DQCkaSUEdZDTwE3cAZmHLUwyg4IoLBEes 3sDNtKTC3FmmC4KuLkFa3zUbChboE/0yApYuWTFEVkvMzuQMT+9zfpDUtwhcIcigoo6J zR82+gK9oQSaXNwRlO1eamkQAehb0B9Qie4PQFvefoL5iAkbjNu0l0Y9HNyNuuu/9M2Y I2DswIRCzvpKinjHy3qHOWitLKnzTPmpPP1U4XE13GWNv+WP+DpY2Q4X/KSZGZqywpAz 26L+w9X2DMshsIOl/C77D/feNoLcFl1Wvc3fq/Y9P/l1ok3GQDAqU6vZ3rglsVtm7PIu HyRw== Date: Thu, 18 Jan 2018 16:22:50 -0800 From: Stephen Hemminger Message-ID: <20180118162250.013954dd@xeon-e3> In-Reply-To: <20180118233745.GA23355@embeddedor.com> References: <20180118233745.GA23355@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Bridge] [PATCH] bridge: return boolean instead of integer in br_multicast_is_router List-Id: Linux Ethernet Bridging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gustavo A. R. Silva" Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, "David S. Miller" , linux-kernel@vger.kernel.org On Thu, 18 Jan 2018 17:37:45 -0600 "Gustavo A. R. Silva" wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva LGTM Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled") Reviewed-by: Stephen Hemminger From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932683AbeASAXJ (ORCPT ); Thu, 18 Jan 2018 19:23:09 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:37217 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753476AbeASAW6 (ORCPT ); Thu, 18 Jan 2018 19:22:58 -0500 X-Google-Smtp-Source: ACJfBovXJ58iaXSXEMvVg8bswW/+JYHs885XZL60ndO2H1CzYn70/aAosOUlIuYzNBKxKq2b/4nylg== Date: Thu, 18 Jan 2018 16:22:50 -0800 From: Stephen Hemminger To: "Gustavo A. R. Silva" Cc: "David S. Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bridge: return boolean instead of integer in br_multicast_is_router Message-ID: <20180118162250.013954dd@xeon-e3> In-Reply-To: <20180118233745.GA23355@embeddedor.com> References: <20180118233745.GA23355@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Jan 2018 17:37:45 -0600 "Gustavo A. R. Silva" wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva LGTM Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled") Reviewed-by: Stephen Hemminger