All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guillermo A. Amaral <g@maral.me>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/sdl2: Fix Raspberry Pi support in package SDL2
Date: Thu, 18 Jan 2018 08:35:51 -0800	[thread overview]
Message-ID: <20180118163551.GA18359@enterprise.starfleet> (raw)
In-Reply-To: <20180118172216.31d59b4c@windsurf.lan>

On Thu, Jan 18, 2018 at 05:22:16PM +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Thu, 18 Jan 2018 15:44:41 +0000, Adrian Perez de Castro wrote:
> 
> > Historically in WebKitGTK+ we have had our share of issues with environment
> > variables, mainly due to ?setenv()? not being thread-safe: the only case in
> > which it does really work is at the very beginning of program execution,
> > before any threads or secondary processes are started. Otherwise it's easy
> > to shoot oneself on the foot and end up with threads/processes that ?see?
> > different values for the same environment variable.
> > 
> > Provided that the patch is adding to ?LD_LIBRARY_PATH?, maybe one option could
> > be using ?patchelf? to add the path to the DT_RUNPATH entry in the ELF header
> > of ?libSDL2.so? in a post-build (or post-install?) hook. Or, if possible,
> > arrange to pass the needed linker flags to get the path added there.
> > 
> > Or, even better, add ?/opt/vc/lib? in DT_RUNPATH when the RPi VideoCore
> > libraries are installed into ?/opt/vc? ? somehow that sounds more correct
> > in my head. WDYT?
> 
> Yes, I agree it would be much better to add a -Wl,-rpath,/opt/vc/lib to
> the LDFLAGS if the libraries are in /opt/vc/lib.
> 

After 6-7 years, I hoped that darn path wouldn't be an issue anymore.
If only Raspbian and friends would all add /opt/vc/lib to their
ld.so.conf...

Anyway, I'll try the rpath approach, using LD_LIBRARY_PATH did hurt a
little, but at the moment it looked like the lesser of two evils; They
already added in another workaround for more library locations for the
RPi and it's starting to look even more like a hodgepodge.

Cheers,
G

-- 
gamaral

  reply	other threads:[~2018-01-18 16:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16  3:34 [Buildroot] [PATCH 1/2] package/sdl2: Fix Raspberry Pi support for SDL2 Guillermo A. Amaral
2018-01-16  3:34 ` [Buildroot] [PATCH 2/2] package/rpi-fbcp: Added package for Raspberry Pi Guillermo A. Amaral
2018-01-16  8:26   ` Thomas Petazzoni
2018-01-16 18:05     ` Guillermo A. Amaral
2018-01-16  8:23 ` [Buildroot] [PATCH 1/2] package/sdl2: Fix Raspberry Pi support for SDL2 Thomas Petazzoni
2018-01-16 17:50   ` Guillermo A. Amaral
2018-01-18  8:15     ` [Buildroot] [PATCH 1/1] package/sdl2: Fix Raspberry Pi support in package SDL2 Guillermo A. Amaral
2018-01-18  8:19       ` Guillermo A. Amaral
2018-01-18 15:05       ` Thomas Petazzoni
2018-01-18 15:44         ` Adrian Perez de Castro
2018-01-18 16:22           ` Thomas Petazzoni
2018-01-18 16:35             ` Guillermo A. Amaral [this message]
2018-01-18 16:43               ` Thomas Petazzoni
2018-01-18 17:54                 ` [Buildroot] [PATCH 1/1] package/sdl2: Fix Raspberry Pi support for SDL2 Guillermo A. Amaral
2018-01-18 17:56                   ` Guillermo A. Amaral
2018-01-18 21:17                   ` Thomas Petazzoni
2018-01-19  6:25                     ` Guillermo A. Amaral
2018-01-19 17:11                   ` Ryan Coe
     [not found]                     ` <CAPeEpDouAm5vqoQQ3PmHcJwvssMe=3yyyrQUvc4zoaw3ehandw@mail.gmail.com>
     [not found]                       ` <CAPeEpDrdRC2eDW5Q=YEc8naVfNz6aLq7zbd4Wcx=FUmEmfdswQ@mail.gmail.com>
     [not found]                         ` <CAPeEpDqrw8369-bhX0j3+5T-ZWo_1bW6=tnYpw8SiWUj5KMBAQ@mail.gmail.com>
     [not found]                           ` <CAPeEpDoZ64=_wE=4OXQvZ_hJdZN9u7eAzOEbXP-+bH05dF1WGg@mail.gmail.com>
2018-01-19 19:24                             ` Guillermo Amaral
2018-01-19 21:40                               ` Peter Korsgaard
2018-01-20 21:25                                 ` [Buildroot] [PATCH 1/1] package/sdl2: Remove trailing backslash Guillermo A. Amaral
2018-01-22 21:29                                   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118163551.GA18359@enterprise.starfleet \
    --to=g@maral.me \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.