From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755264AbeARRG3 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 Jan 2018 12:06:29 -0500
Received: from foss.arm.com ([217.140.101.70]:58598 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754909AbeARRG2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 Jan 2018 12:06:28 -0500
Date: Thu, 18 Jan 2018 17:06:33 +0000
From: Will Deacon <will.deacon@arm.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Vince Weaver <vince@deater.net>, Stephane Eranian <eranian@google.com>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/3] perf, pt, coresight: Clean up address filter
 structure
Message-ID: <20180118170633.GG12394@arm.com>
References: <20170126094057.13805-2-alexander.shishkin@linux.intel.com>
 <20170126182645.GA1991@linaro.org>
 <87h94kbt29.fsf@ashishki-desk.ger.corp.intel.com>
 <CANLsYkwUa+B6nrP+6gJ=U5a9NnxyohS2wCVstHR2O7gLryWbDw@mail.gmail.com>
 <87wpda9iyv.fsf@ashishki-desk.ger.corp.intel.com>
 <CANLsYkz2iU2dUwshj8zYd1ix0yKtNYkMmYZ=cr4nLdq3efvUMQ@mail.gmail.com>
 <87d1f0a7g9.fsf@ashishki-desk.ger.corp.intel.com>
 <CANLsYkxPgQtJJWk=17mF0TgRNj+nH1ePgMMtYdek9Pero-C0rQ@mail.gmail.com>
 <20180117123137.3hlmudzu5eogl53n@ukko.fi.intel.com>
 <CANLsYkxO=cDgX=rNQkHZ6=NoZPpRiazBqXSkyejsfVFOs0T_2w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANLsYkxO=cDgX=rNQkHZ6=NoZPpRiazBqXSkyejsfVFOs0T_2w@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 18, 2018 at 09:59:26AM -0700, Mathieu Poirier wrote:
> On 17 January 2018 at 05:31, Alexander Shishkin
> <alexander.shishkin@linux.intel.com> wrote:
> > On Tue, Feb 07, 2017 at 10:50:50AM -0700, Mathieu Poirier wrote:
> >> > index 39106ae61b..d7a11faac1 100644
> >> > --- a/kernel/events/core.c
> >> > +++ b/kernel/events/core.c
> >> > @@ -8194,7 +8194,8 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
> >> >   *  * for kernel addresses: <start address>[/<size>]
> >> >   *  * for object files:     <start address>[/<size>]@</path/to/object/file>
> >> >   *
> >> > - * if <size> is not specified, the range is treated as a single address.
> >> > + * if <size> is not specified or is zero, the range is treated as a single
> >> > + * address; not valid for ACTION=="filter".
> >>
> >> Now that a size of 0 can't be specified with a "filter" action, I'm
> >> good with that statement.
> >
> > Hi Mathieu, I completely lost track of this.
> >
> > Following is the commit I found dangilng in one of my local branches.
> > Does this make sense to you? Thanks!
> 
> Oh boy!  That's a whole year ago...  Give me some time to wrap my
> brain around it again.

Do we need anything for SPE, or is this only applicable to certain types of
tracing PMUs?

Will