Re: [PATCH 1/2] remove delay_(watch|wait)_checks

["Benjamin Marzinski" <bmarzins@redhat.com>]

On Fri, Jan 12, 2018 at 10:09:00PM +0100, Martin Wilck wrote:
> Hi Ben,
> 
> On Wed, 2017-12-13 at 12:08 -0600, Benjamin Marzinski wrote:
> > These configuration options do essentially the same thing as the
> > marginal paths options do, but since they don't do the increased IO
> > testing, they are less likely to find the marginal paths. Guan, if
> > you
> > left these in for a reason (such as to deal with devices that don't
> > do
> > well with IO testing, such as passive paths) I'm open to keeping
> > them.
> > But it seems like the marginal paths options options do a better job
> > than they do, and if there are cases that they doesn't handle well,
> > they
> > should be expanded to do so.
> 
> I think we should wait a bit more before removing this stuff. The
> marginal paths code hasn't seen much testing yet AFAICS.

That's fine. There's no rush to remove them.

-Ben

> 
> Regards
> Martin
> 
> -- 
> Dr. Martin Wilck <mwilck@suse.com>, Tel. +49 (0)911 74053 2107
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
> HRB 21284 (AG Nürnberg)