From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/4] dmaengine: qcom: bam_dma: make bam clk optional From: Vinod Koul Message-Id: <20180119055221.GV18649@localhost> Date: Fri, 19 Jan 2018 11:22:21 +0530 To: srinivas.kandagatla@linaro.org Cc: Andy Gross , dmaengine@vger.kernel.org, Rob Herring , Mark Rutland , David Brown , Dan Williams , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, yanhe@quicinc.com, ramkri@qti.qualcomm.com, sdharia@quicinc.com List-ID: T24gVHVlLCBKYW4gMTYsIDIwMTggYXQgMDc6MDI6MzNQTSArMDAwMCwgc3Jpbml2YXMua2FuZGFn YXRsYUBsaW5hcm8ub3JnIHdyb3RlOgo+IEZyb206IFNyaW5pdmFzIEthbmRhZ2F0bGEgPHNyaW5p dmFzLmthbmRhZ2F0bGFAbGluYXJvLm9yZz4KPiAKPiBXaGVuIEJBTSBpcyByZW1vdGVseSBjb250 cm9sbGVkIGl0IGRvZXMgbm90IHNvdW5kIGNvcnJlY3QgdG8gY29udHJvbAo+IGl0cyBjbGsgb24g TGludXggc2lkZS4gTWFrZSBpdCBvcHRpb25hbCwgc28gdGhhdCBpdHMgbm90IG1hZGF0b3J5Cgpz L21hZGF0b3J5L21hbmRhdG9yeQoKPiBmb3IgcmVtb3RlIGNvbnRyb2xsZWQgQkFNIGluc3RhbmNl cy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBTcmluaXZhcyBLYW5kYWdhdGxhIDxzcmluaXZhcy5rYW5k YWdhdGxhQGxpbmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZG1hL3Fjb20vYmFtX2RtYS5jIHwg MTUgKysrKysrKystLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hL3Fjb20vYmFtX2RtYS5j IGIvZHJpdmVycy9kbWEvcWNvbS9iYW1fZG1hLmMKPiBpbmRleCAwM2M0ZWIzZmQzMTQuLjc4ZTQ4 OGU4Zjk2ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2RtYS9xY29tL2JhbV9kbWEuYwo+ICsrKyBi L2RyaXZlcnMvZG1hL3Fjb20vYmFtX2RtYS5jCj4gQEAgLTExODAsMTMgKzExODAsMTQgQEAgc3Rh dGljIGludCBiYW1fZG1hX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAkJ CQkJCSJxY29tLGNvbnRyb2xsZWQtcmVtb3RlbHkiKTsKPiAgCj4gIAliZGV2LT5iYW1jbGsgPSBk ZXZtX2Nsa19nZXQoYmRldi0+ZGV2LCAiYmFtX2NsayIpOwoKYnV0IHlvdSBzdGlsbCBkbyBjbGtf Z2V0IHVuY29uZGl0aW9uYWxseT8KCj4gLQlpZiAoSVNfRVJSKGJkZXYtPmJhbWNsaykpCj4gLQkJ cmV0dXJuIFBUUl9FUlIoYmRldi0+YmFtY2xrKTsKPiAtCj4gLQlyZXQgPSBjbGtfcHJlcGFyZV9l bmFibGUoYmRldi0+YmFtY2xrKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlkZXZfZXJyKGJkZXYtPmRl diwgImZhaWxlZCB0byBwcmVwYXJlL2VuYWJsZSBjbG9ja1xuIik7Cj4gLQkJcmV0dXJuIHJldDsK PiArCWlmIChJU19FUlIoYmRldi0+YmFtY2xrKSkgewo+ICsJCWJkZXYtPmJhbWNsayA9IE5VTEw7 Cj4gKwl9IGVsc2Ugewo+ICsJCXJldCA9IGNsa19wcmVwYXJlX2VuYWJsZShiZGV2LT5iYW1jbGsp Owo+ICsJCWlmIChyZXQpIHsKPiArCQkJZGV2X2VycihiZGV2LT5kZXYsICJmYWlsZWQgdG8gcHJl cGFyZS9lbmFibGUgY2xvY2tcbiIpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJCX0KCndvdWxkbid0 IGl0IGJlIGJldHRlciB0byBzZXQgdGhhdCBhbiBpbnN0YW5jZSBpcyByZW1vdGUgY29udHJvbGxl ZCBhbmQgdGh1cwpub3QgYXQgYWxsIHZpc2libGUgdG8gTGludXg/Cgo+ICAJfQo+ICAKPiAgCXJl dCA9IGJhbV9pbml0KGJkZXYpOwo+IC0tIAo+IDIuMTUuMQo+IAo+IC0tCj4gVG8gdW5zdWJzY3Jp YmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGRtYWVuZ2luZSIg aW4KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwo+ IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21v LWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 1/4] dmaengine: qcom: bam_dma: make bam clk optional Date: Fri, 19 Jan 2018 11:22:21 +0530 Message-ID: <20180119055221.GV18649@localhost> References: <20180116190236.14558-1-srinivas.kandagatla@linaro.org> <20180116190236.14558-2-srinivas.kandagatla@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga02.intel.com ([134.134.136.20]:59354 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbeASFsC (ORCPT ); Fri, 19 Jan 2018 00:48:02 -0500 Content-Disposition: inline In-Reply-To: <20180116190236.14558-2-srinivas.kandagatla@linaro.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: srinivas.kandagatla@linaro.org Cc: Andy Gross , dmaengine@vger.kernel.org, Rob Herring , Mark Rutland , David Brown , Dan Williams , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, yanhe@quicinc.com, ramkri@qti.qualcomm.com, sdharia@quicinc.com On Tue, Jan 16, 2018 at 07:02:33PM +0000, srinivas.kandagatla@linaro.org wrote: > From: Srinivas Kandagatla > > When BAM is remotely controlled it does not sound correct to control > its clk on Linux side. Make it optional, so that its not madatory s/madatory/mandatory > for remote controlled BAM instances. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/dma/qcom/bam_dma.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c > index 03c4eb3fd314..78e488e8f96d 100644 > --- a/drivers/dma/qcom/bam_dma.c > +++ b/drivers/dma/qcom/bam_dma.c > @@ -1180,13 +1180,14 @@ static int bam_dma_probe(struct platform_device *pdev) > "qcom,controlled-remotely"); > > bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk"); but you still do clk_get unconditionally? > - if (IS_ERR(bdev->bamclk)) > - return PTR_ERR(bdev->bamclk); > - > - ret = clk_prepare_enable(bdev->bamclk); > - if (ret) { > - dev_err(bdev->dev, "failed to prepare/enable clock\n"); > - return ret; > + if (IS_ERR(bdev->bamclk)) { > + bdev->bamclk = NULL; > + } else { > + ret = clk_prepare_enable(bdev->bamclk); > + if (ret) { > + dev_err(bdev->dev, "failed to prepare/enable clock\n"); > + return ret; > + } wouldn't it be better to set that an instance is remote controlled and thus not at all visible to Linux? > } > > ret = bam_init(bdev); > -- > 2.15.1 > > -- > To unsubscribe from this list: send the line "unsubscribe dmaengine" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- ~Vinod