diff for duplicates of <20180119095857.GA26765@lenoch> diff --git a/a/1.txt b/N1/1.txt index b877be0..3b9c24a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,7 +14,7 @@ On Thu, Jan 18, 2018 at 12:35:25PM -0600, Bjorn Helgaas wrote: > > > res = platform_get_resource_byname(pdev, t, n); > > > + if (!res) > > > + return -EINVAL; -> > > ... when != res = NULL +> > > ... when != res == NULL > > > e = devm_ioremap(e1, res->start, e2); > > > > Well, then it should be replaced with devm_ioremap_resource() @@ -54,7 +54,7 @@ index 5f2aedd58bc5..6315b07a608f 100644 + static int devm_ioremap_match(struct device *dev, void *res, void *match_data) { - return *(void **)res = match_data; + return *(void **)res == match_data; @@ -136,7 +145,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res) { resource_size_t size; diff --git a/a/content_digest b/N1/content_digest index df2b001..9459f0c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020180118183525.GG53542@bhelgaas-glaptop.roam.corp.google.com\0" "From\0Ladislav Michl <ladis@linux-mips.org>\0" "Subject\0Re: [PATCH -next] PCI: dra7xx: Fix potential NULL dereference\0" - "Date\0Fri, 19 Jan 2018 09:58:57 +0000\0" + "Date\0Fri, 19 Jan 2018 10:58:57 +0100\0" "To\0Bjorn Helgaas <helgaas@kernel.org>\0" "Cc\0Wei Yongjun <weiyongjun1@huawei.com>" Kishon Vijay Abraham I <kishon@ti.com> @@ -30,7 +30,7 @@ "> > > res = platform_get_resource_byname(pdev, t, n);\n" "> > > + if (!res)\n" "> > > + return -EINVAL;\n" - "> > > ... when != res = NULL\n" + "> > > ... when != res == NULL\n" "> > > e = devm_ioremap(e1, res->start, e2);\n" "> > \n" "> > Well, then it should be replaced with devm_ioremap_resource()\n" @@ -70,7 +70,7 @@ "+\n" " static int devm_ioremap_match(struct device *dev, void *res, void *match_data)\n" " {\n" - " \treturn *(void **)res = match_data;\n" + " \treturn *(void **)res == match_data;\n" "@@ -136,7 +145,7 @@ void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res)\n" " {\n" " \tresource_size_t size;\n" @@ -168,4 +168,4 @@ "> the body of a message to majordomo@vger.kernel.org\n" > More majordomo info at http://vger.kernel.org/majordomo-info.html -84686c7e67082895e8122e591a65ca0c41e3705c1e823ca2d85c7262cfccd28e +4cec73b4e1bf2e085c2798a88cf427ea015fcc9b9eb560348658210c1bf42dd1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.