Re: [Qemu-devel] [PATCH v2 1/1] s390x: fix storage attributes migration for non-small guests

[Cornelia Huck <cohuck@redhat.com>]

On Fri, 19 Jan 2018 13:17:29 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:

> On 01/18/2018 06:51 PM, Claudio Imbrenda wrote:
> > Fix storage attribute migration so that it does not fail for guests
> > with more than a few GB of RAM.
> > With such guests, the index in the buffer would go out of bounds,
> > usually by large amounts, thus receiving -EFAULT from the kernel.
> > Migration itself would be successful, but storage attributes would then
> > not be migrated completely.
> > 
> > This patch fixes the out of bounds access, and thus migration of all
> > storage attributes when the guest have large amounts of memory.
> > 
> > Signed-off-by: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
> > Fixes: 903fd80b03243476 ("s390x/migration: Storage attributes device")  
> 
> Cc: stable ?

Probably doesn't hurt for an out-of-bounds error.

> 
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
> 
> > ---
> >  hw/s390x/s390-stattrib-kvm.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)

Updated the queued patch, thanks.