All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: keith.busch@intel.com, stable@vger.kernel.org
Subject: Re: [PATCH stable backport 4.4/4.9] x86/apic/vector: Fix off by one in error path
Date: Fri, 19 Jan 2018 16:30:08 +0100	[thread overview]
Message-ID: <20180119153008.GA26781@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1801191603590.2181@nanos>

On Fri, Jan 19, 2018 at 04:10:56PM +0100, Thomas Gleixner wrote:
> Upstream commit 45d55e7bac4028af93f5fa324e69958a0b868e96
> 
> Keith reported the following warning:
> 
> WARNING: CPU: 28 PID: 1420 at kernel/irq/matrix.c:222 irq_matrix_remove_managed+0x10f/0x120
>   x86_vector_free_irqs+0xa1/0x180
>   x86_vector_alloc_irqs+0x1e4/0x3a0
>   msi_domain_alloc+0x62/0x130
> 
> The reason for this is that if the vector allocation fails the error
> handling code tries to free the failed vector as well, which causes the
> above imbalance warning to trigger.
> 
> Adjust the error path to handle this correctly.
> 
> Fixes: b5dc8e6c21e7 ("x86/irq: Use hierarchical irqdomain to manage CPU interrupt vectors")
> Reported-by: Keith Busch <keith.busch@intel.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Keith Busch <keith.busch@intel.com>
> Cc: stable@vger.kernel.org
> Link: https://lkml.kernel.org/r/alpine.DEB.2.20.1801161217300.1823@nanos

Thanks for the backports, now queued up.

greg k-h

      parent reply	other threads:[~2018-01-19 15:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19  9:25 FAILED: patch "[PATCH] x86/apic/vector: Fix off by one in error path" failed to apply to 4.14-stable tree gregkh
2018-01-19 12:02 ` Keith Busch
2018-01-19 15:10 ` [PATCH stable backport 4.4/4.9] x86/apic/vector: Fix off by one in error path Thomas Gleixner
2018-01-19 15:11   ` [PATCH stable backport 4.14] " Thomas Gleixner
2018-01-19 15:30   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119153008.GA26781@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=keith.busch@intel.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.