From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <viro@ftp.linux.org.uk>
X-Google-Smtp-Source: ACJfBouPRLmbTM8wWUD3XEHTZcor6oddxbP4X9BAHdbUIKK8GeUAof9OSGhSnsiWdWD2AXT8vCJg
ARC-Seal: i=1; a=rsa-sha256; t=1516382315; cv=none;
        d=google.com; s=arc-20160816;
        b=byOqsSXU9Y9Z2WBWBJdvN8HQHnrc4kMtLzp4R2AnwDVIk5Y7gZip0A59LncnUYxlOE
         i+TWd7MbYCLe4ne24tRVfAasAi2KysVMHvyOp7foDpJj69n4F3yvalsMQiGmIPH/t0UR
         bg657Op8Beq7DM1RCfXjMLDHNL0rAY9vmBNc/wCC1MrF7s0nmzYZebvFKpvHDHZTJiaj
         YjPdizZMCONZf2wq5KNPvd+nHpcgC5/ZqGfd1VUuLUz45WzA+wDNa0UteOlgJ2mJe/Xz
         iaUrWZofgiPNnz9P5361c19lDjhroePql2mzbK99ySp/tXrKXujb0TBrGz2wPVoPlx5E
         D3pg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=sender:user-agent:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date
         :arc-authentication-results;
        bh=ZJLAsO8vklmWXv9MAL6OH1O4cqkHRcLUA3lSZGzNMtk=;
        b=0SFOmweCotqcHMB4sHDob3q54DOghhdkb9gQnbie4EYFbu6eH481sZW7PH+zSvgegb
         F5u/XI3QVix/EIFSwqF5sAtdAN6vkMrV8EGCzM1Zl47ngqkrF+Q/2ITpphVOl3SuVm24
         FaoR3rW1lNe8Sp+Wk3Xs+AwT4hpLA0Ag67Wv1PSrKv/TU2qlgfuyvibQuMWOC/7jN6bB
         PUWJhhaQLj1mzgb1gOPYbG9TPvdhcaB6G5JARvc/JmMR0TDSn/WRhNLtFt2kW0H2poGL
         CHZ2Ft3TDxClCjEVANem+ts07P4MNmnoE0GeqjjNo/YMCrL3Z6W6/8kLE9Aj92Z6E3ZI
         0eBQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of viro@ftp.linux.org.uk designates 195.92.253.2 as permitted sender) smtp.mailfrom=viro@ftp.linux.org.uk
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of viro@ftp.linux.org.uk designates 195.92.253.2 as permitted sender) smtp.mailfrom=viro@ftp.linux.org.uk
Date: Fri, 19 Jan 2018 17:18:28 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tejun Heo <tj@kernel.org>
Cc: Ivan Vecera <ivecera@redhat.com>, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH driver-core] kernfs: fix regression in kernfs_fop_write
 caused by wrong type
Message-ID: <20180119171828.GJ13338@ZenIV.linux.org.uk>
References: <20180119081854.13609-1-ivecera@redhat.com>
 <20180119171636.GE3460072@devbig577.frc2.facebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180119171636.GE3460072@devbig577.frc2.facebook.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: Al Viro <viro@ftp.linux.org.uk>
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: =?utf-8?q?1590008152180270660?=
X-GMAIL-MSGID: =?utf-8?q?1590042101772409025?=
X-Mailing-List: linux-kernel@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>

On Fri, Jan 19, 2018 at 09:16:36AM -0800, Tejun Heo wrote:
> On Fri, Jan 19, 2018 at 09:18:54AM +0100, Ivan Vecera wrote:
> > Commit b7ce40cff0b9 ("kernfs: cache atomic_write_len in
> > kernfs_open_file") changes type of local variable 'len' from ssize_t
> > to size_t. This change caused that the *ppos value is updated also
> > when the previous write callback failed.
> > 
> > Mentioned snippet:
> > ...
> > len = ops->write(...); <- return value can be negative
> > ...
> > if (len > 0)           <- true here in this case
> >         *ppos += len;
> > ...
> > 
> > Fixes: b7ce40cff0b9 ("kernfs: cache atomic_write_len in kernfs_open_file")
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> 
> Oops.
> 
>   Acked-by: Tejun Heo <tj@kernel.org>

Applied.